Changeset 230694 in webkit

Timestamp:

Apr 16, 2018 6:20:43 PM (6 years ago)

Author:

aestes@apple.com

Message:

[iOS] Enable WKPDFView by default
​https://bugs.webkit.org/show_bug.cgi?id=184675
<rdar://problem/27885452>

Reviewed by Darin Adler.

Source/WebKit:

• UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry init]):

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:

Location:

trunk

Files:

• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/FeatureDefines.h (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-04-16  Andy Estes  <aestes@apple.com>
+
+        [iOS] Enable WKPDFView by default
+        https://bugs.webkit.org/show_bug.cgi?id=184675
+        <rdar://problem/27885452>
+
+        Reviewed by Darin Adler.
+
+        * wtf/FeatureDefines.h:
+
 2018-04-16  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WTF/wtf/FeatureDefines.h

@@ -168 +168 @@
 
 #if !defined(ENABLE_WKLEGACYPDFVIEW)
-#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !ENABLE(MINIMAL_SIMULATOR)
+#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !ENABLE(MINIMAL_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED < 120000
 #define ENABLE_WKLEGACYPDFVIEW 1
 #endif

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-16  Andy Estes  <aestes@apple.com>
+
+        [iOS] Enable WKPDFView by default
+        https://bugs.webkit.org/show_bug.cgi?id=184675
+        <rdar://problem/27885452>
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
+        (-[WKWebViewContentProviderRegistry init]):
+
 2018-04-16  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm

@@ -32 +32 @@
 
 #import "WKLegacyPDFView.h"
+#import "WKPDFView.h"
 #import "WKSystemPreviewView.h"
 #import "WKWebViewInternal.h"
@@ -57 +58 @@
         return nil;
 
-#if ENABLE(WKLEGACYPDFVIEW)
+#if ENABLE(WKPDFVIEW)
+    for (auto& mimeType : WebCore::MIMETypeRegistry::getPDFMIMETypes())
+        [self registerProvider:[WKPDFView class] forMIMEType:mimeType];
+#elif ENABLE(WKLEGACYPDFVIEW)
     for (auto& mimeType : WebCore::MIMETypeRegistry::getPDFMIMETypes())
         [self registerProvider:[WKLegacyPDFView class] forMIMEType:mimeType];

trunk/Tools/ChangeLog

@@ +1 @@
+2018-04-16  Andy Estes  <aestes@apple.com>
+
+        [iOS] Enable WKPDFView by default
+        https://bugs.webkit.org/show_bug.cgi?id=184675
+        <rdar://problem/27885452>
+
+        Reviewed by Darin Adler.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
+
 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm

@@ -27 +27 @@
 #import <WebKit/WKFoundation.h>
 
-#if WK_API_ENABLED && TARGET_OS_IPHONE
+// FIXME: Enable these tests on iOS 12 once rdar://problem/39475542 is resolved.
+#if WK_API_ENABLED && TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED < 120000
 
 #import "PlatformUtilities.h"