Changeset 231999 in webkit
- Timestamp:
- May 19, 2018 1:57:02 PM (6 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r231993 r231999 1 2018-05-19 Sihui Liu <sihui_liu@apple.com> 2 3 Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies 4 https://bugs.webkit.org/show_bug.cgi?id=185624 5 <rdar://problem/39111626> 6 7 Reviewed by Chris Dumez. 8 9 Modified expectation to make test more robust as cookies can be returned in different orders. 10 11 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: 12 (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): 13 (TEST): 14 1 15 2018-05-18 Commit Queue <commit-queue@webkit.org> 2 16 -
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
r231850 r231999 34 34 #import <WebKit/_WKWebsiteDataStoreConfiguration.h> 35 35 #import <wtf/RetainPtr.h> 36 #import <wtf/text/WTFString.h> 36 37 37 38 #if WK_API_ENABLED … … 377 378 - (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(void))completionHandler 378 379 { 379 EXPECT_STREQ("cookie:PersistentCookieName=CookieValue; SessionCookieName=CookieValue", message.UTF8String); 380 auto cookies = String(message.UTF8String); 381 ASSERT_TRUE(cookies == "PersistentCookieName=CookieValue; SessionCookieName=CookieValue" || cookies == "SessionCookieName=CookieValue; PersistentCookieName=CookieValue"); 380 382 finished = true; 381 383 completionHandler(); … … 398 400 NSHTTPCookieExpires: [NSDate distantFuture], 399 401 }]; 400 NSString *alertCookieHTML = @"<script>alert( 'cookie:'+document.cookie);</script>";402 NSString *alertCookieHTML = @"<script>alert(document.cookie);</script>"; 401 403 402 404 // NonPersistentDataStore
Note: See TracChangeset
for help on using the changeset viewer.