Changeset 252307 in webkit

Timestamp:

Nov 9, 2019 3:05:21 AM (4 years ago)

Author:

graouts@webkit.org

Message:

[Web Animations] Optimize animation resolution to not re-compute whether effects only contain accelerated animation properties
​https://bugs.webkit.org/show_bug.cgi?id=204009

Reviewed by Dean Jackson.

A KeyframeEffect already exposes whether it only affects CSS properties that can be accelerated, so use this information instead
of iterating over an effect's animated properties during resolution to get at the same information.

No tests or changes to existed test expectations as this should not yield any change in behavior.

• dom/Element.cpp:

(WebCore::Element::applyKeyframeEffects):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-11-08  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Optimize animation resolution to not re-compute whether effects only contain accelerated animation properties
+        https://bugs.webkit.org/show_bug.cgi?id=204009
+
+        Reviewed by Dean Jackson.
+
+        A KeyframeEffect already exposes whether it only affects CSS properties that can be accelerated, so use this information instead
+        of iterating over an effect's animated properties during resolution to get at the same information. 
+
+        No tests or changes to existed test expectations as this should not yield any change in behavior.
+
+        * dom/Element.cpp:
+        (WebCore::Element::applyKeyframeEffects):
+
 2019-11-08  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -32 +32 @@
 #include "CSSAnimationController.h"
 #include "CSSParser.h"
-#include "CSSPropertyAnimation.h"
 #include "Chrome.h"
 #include "ChromeClient.h"
@@ -3704 +3703 @@
         effect->animation()->resolve(targetStyle);
 
-        if (hasNonAcceleratedAnimationProperty)
-            continue;
-
-        // FIXME: https://bugs.webkit.org/show_bug.cgi?id=204009
-        // KeyframeEffectStack and KeyframeEffect should indicate whether it only contains accelerated animation properties
-        for (auto cssPropertyId : effect->animatedProperties()) {
-            if (!CSSPropertyAnimation::animationOfPropertyIsAccelerated(cssPropertyId)) {
-                hasNonAcceleratedAnimationProperty = true;
-                break;
-            }
-        }
+        if (!hasNonAcceleratedAnimationProperty && !effect->isAccelerated())
+            hasNonAcceleratedAnimationProperty = true;
     }