Changeset 254636 in webkit


Ignore:
Timestamp:
Jan 15, 2020 2:04:45 PM (4 years ago)
Author:
ddkilzer@apple.com
Message:

Enable -Wconditional-uninitialized in DumpRenderTree, WebKitTestRunner
<​https://webkit.org/b/206269>
<rdar://problem/58589158>

Reviewed by Brent Fulgham.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:

(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
Initialize imageRef stack variable to nullptr.

  • WebKitTestRunner/Configurations/Base.xcconfig:

(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r254632 r254636  
     12020-01-15  David Kilzer  <ddkilzer@apple.com>
     2
     3        Enable -Wconditional-uninitialized in DumpRenderTree, WebKitTestRunner
     4        <https://webkit.org/b/206269>
     5        <rdar://problem/58589158>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        * DumpRenderTree/mac/Configurations/Base.xcconfig:
     10        (WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
     11        * DumpRenderTree/mac/UIDelegate.mm:
     12        (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
     13        Initialize `imageRef` stack variable to `nullptr`.
     14        * WebKitTestRunner/Configurations/Base.xcconfig:
     15        (WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
     16
    1172020-01-15  Keith Miller  <keith_miller@apple.com>
    218

  • trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig

    r249312 r254636  
    8181GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
    8282GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
    83 WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
     83WARNING_CFLAGS = -Wall -W -Wconditional-uninitialized -Wno-unused-parameter -Wundef;
    8484
    8585DEBUG_DEFINES_debug = ;

  • trunk/Tools/DumpRenderTree/mac/UIDelegate.mm

    r244557 r254636  
    390390    NSString *displayString = firstURL.lastPathComponent;
    391391    const std::vector<char>& iconData = gTestRunner->openPanelFilesMediaIcon();
    392     CGImageRef imageRef;
     392    CGImageRef imageRef = nullptr;
    393393    if (!iconData.empty()) {
    394394        RetainPtr<CFDataRef> dataRef = adoptCF(CFDataCreate(nullptr, (unsigned char *)iconData.data(), iconData.size()));

  • trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig

    r253396 r254636  
    7373GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO;
    7474GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO;
    75 WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
     75WARNING_CFLAGS = -Wall -W -Wconditional-uninitialized -Wno-unused-parameter -Wundef;
    7676GCC_PREFIX_HEADER = WebKitTestRunnerPrefix.h
    7777
Note: See TracChangeset for help on using the changeset viewer.