Changeset 256233 in webkit

Timestamp:

Feb 10, 2020 5:13:01 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
<​https://webkit.org/b/207519>
<rdar://problem/59043436>

Reviewed by Brent Fulgham.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::initializeClassesForParameterCoding):

• Change className to keep a copy of the CString object.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-02-10  David Kilzer  <ddkilzer@apple.com>
+
+        WebKit::WebProcessPool::initializeClassesForParameterCoding() should keep a copy of CString
+        <https://webkit.org/b/207519>
+        <rdar://problem/59043436>
+
+        Reviewed by Brent Fulgham.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::initializeClassesForParameterCoding):
+        - Change `className` to keep a copy of the CString object.
+
 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -713 +713 @@
 
     for (const auto& customClass : customClasses) {
-        const auto* className = customClass.utf8().data();
-        Class objectClass = objc_lookUpClass(className);
+        auto className = customClass.utf8();
+        Class objectClass = objc_lookUpClass(className.data());
         if (!objectClass) {
-            WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className);
+            WTFLogAlways("InjectedBundle::extendClassesForParameterCoder - Class %s is not a valid Objective C class.\n", className.data());
             break;
         }