Changeset 256696 in webkit

Timestamp:

Feb 14, 2020 7:02:55 PM (4 years ago)

Author:

Russell Epstein

Message:

Cherry-pick r256636. rdar://problem/59478734

[Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
​https://bugs.webkit.org/show_bug.cgi?id=207784
<rdar://problem/59251858>

Patch by Antoine Quint <​graouts@webkit.org> on 2020-02-14
Reviewed by Dean Jackson.

After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
call should the Web Animations flag be on.

• page/Frame.cpp: (WebCore::Frame::resumeActiveDOMObjectsAndAnimations):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@256636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-609-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Frame.cpp (modified) (1 diff)

branches/safari-609-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2020-02-14  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r256636. rdar://problem/59478734
+
+    [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
+    https://bugs.webkit.org/show_bug.cgi?id=207784
+    <rdar://problem/59251858>
+    
+    Patch by Antoine Quint <graouts@webkit.org> on 2020-02-14
+    Reviewed by Dean Jackson.
+    
+    After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
+    call should the Web Animations flag be on.
+    
+    * page/Frame.cpp:
+    (WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-02-14  Antoine Quint  <graouts@webkit.org>
+
+            [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
+            https://bugs.webkit.org/show_bug.cgi?id=207784
+            <rdar://problem/59251858>
+
+            Reviewed by Dean Jackson.
+
+            After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
+            call should the Web Animations flag be on.
+
+            * page/Frame.cpp:
+            (WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
+
 2020-02-14  Russell Epstein  <repstein@apple.com>
 

branches/safari-609-branch/Source/WebCore/page/Frame.cpp

@@ -963 +963 @@
 
     // Frame::clearTimers() suspended animations and pending relayouts.
-    animation().resumeAnimationsForDocument(m_doc.get());
+
+    if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) {
+        if (auto* timeline = m_doc->existingTimeline())
+            timeline->resumeAnimations();
+    } else
+        animation().resumeAnimationsForDocument(m_doc.get());
     if (m_view)
         m_view->layoutContext().scheduleLayout();