Changeset 262004 in webkit

Timestamp:

May 21, 2020 9:08:50 AM (4 years ago)

Author:

Chris Dumez

Message:

[WK2] WebKit abandons compiled sandbox profiles
​https://bugs.webkit.org/show_bug.cgi?id=212177
<rdar://problem/54613619>

Reviewed by Saam Barati.

WebKit generates new compiled sandbox profiles whenever sandbox profiles are updated or
whenever webkit directories change (which is super common for WebKitTestRunner). Previous
compiled sandbox profiles do not get deleted and therefore may accumulate.

To address the issue, we now save compiled sandbox profiles under _CS_DARWIN_USER_TEMP_DIR
instead of _CS_DARWIN_USER_CACHE_DIR. The system takes care of deleting the files under
_CS_DARWIN_USER_TEMP_DIR upon reboot or if they have not been accessed for 3 days.

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::sandboxDataVaultParentDirectory):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/AuxiliaryProcessMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-05-21  Chris Dumez  <cdumez@apple.com>
+
+        [WK2] WebKit abandons compiled sandbox profiles
+        https://bugs.webkit.org/show_bug.cgi?id=212177
+        <rdar://problem/54613619>
+
+        Reviewed by Saam Barati.
+
+        WebKit generates new compiled sandbox profiles whenever sandbox profiles are updated or
+        whenever webkit directories change (which is super common for WebKitTestRunner). Previous
+        compiled sandbox profiles do not get deleted and therefore may accumulate.
+
+        To address the issue, we now save compiled sandbox profiles under _CS_DARWIN_USER_TEMP_DIR
+        instead of _CS_DARWIN_USER_CACHE_DIR. The system takes care of deleting the files under
+        _CS_DARWIN_USER_TEMP_DIR upon reboot or if they have not been accessed for 3 days.
+
+        * Shared/mac/AuxiliaryProcessMac.mm:
+        (WebKit::sandboxDataVaultParentDirectory):
+
 2020-05-21  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm

@@ -257 +257 @@
 {
     char temp[PATH_MAX];
-    size_t length = confstr(_CS_DARWIN_USER_CACHE_DIR, temp, sizeof(temp));
+    // We save the profiles in the user tempory directory so that they get cleaned on reboot
+    // or if they are not accessed in 3 days. This avoids accumulating profiles whenever we change
+    // our sandbox rules or webkit cache directories (rdar://problem/54613619).
+    size_t length = confstr(_CS_DARWIN_USER_TEMP_DIR, temp, sizeof(temp));
     if (!length) {
         WTFLogAlways("%s: Could not retrieve user cache directory path: %s\n", getprogname(), strerror(errno));