Changeset 30704 in webkit

Timestamp:

Mar 2, 2008 6:02:28 PM (16 years ago)

Author:

kevino@webkit.org

Message:

Reviewed by Dave Hyatt.

Gracefully handle a CSS rule containing an invalid value.
(Fixes ​http://bugs.webkit.org/show_bug.cgi?id=16898)

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/invalid-rule-value-expected.txt (added)
• LayoutTests/fast/css/invalid-rule-value.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSGrammar.y (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-03-02  Kevin Ollivier  <kevino@theolliviers.com>
+
+        Reviewed by Dave Hyatt.
+
+        Gracefully handle a CSS rule containing an invalid value.
+        (Fixes http://bugs.webkit.org/show_bug.cgi?id=16898)
+
+        * fast/css/invalid-rule-value-expected.txt: Added.
+        * fast/css/invalid-rule-value.html: Added.
+
 2008-03-01  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-03-02  Kevin Ollivier  <kevino@theolliviers.com>
+
+        Reviewed by Dave Hyatt.
+
+        Gracefully handle a CSS rule containing an invalid value.
+        (Fixes http://bugs.webkit.org/show_bug.cgi?id=16898)
+
+        * css/CSSGrammar.y:
+
 2008-03-02  Alp Toker  <alp@atoker.com>
 

trunk/WebCore/css/CSSGrammar.y

@@ -986 +986 @@
         $$ = false;
     }
+    |
+    property ':' maybe_space error {
+        /* if we come across rules with invalid values like this case: p { weight: *; }, just discard the rule */
+        $$ = false;
+    }
   ;