Changeset 36810 in webkit


Ignore:
Timestamp:
Sep 23, 2008 1:30:58 PM (16 years ago)
Author:
mitz@apple.com
Message:

WebKit/mac:

Reviewed by Beth Dakin.

  • fix <rdar://problem/6233388> Crash beneath -[WebFrameView keyDown:]

Test: fast/events/keydown-remove-frame.html

  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a null check.

LayoutTests:

Reviewed by Beth Dakin.

  • test for <rdar://problem/6233388> Crash beneath -[WebFrameView keyDown:]
  • fast/events/keydown-remove-frame-expected.txt: Added.
  • fast/events/keydown-remove-frame.html: Added.
  • fast/events/resources/keydown-remove-frame-iframe.html: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r36807 r36810  
     12008-09-23  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4
     5        - test for <rdar://problem/6233388> Crash beneath -[WebFrameView keyDown:]
     6
     7        * fast/events/keydown-remove-frame-expected.txt: Added.
     8        * fast/events/keydown-remove-frame.html: Added.
     9        * fast/events/resources/keydown-remove-frame-iframe.html: Added.
     10
    1112008-09-23  Alexey Proskuryakov  <ap@webkit.org>
    212
  • trunk/WebKit/mac/ChangeLog

    r36734 r36810  
     12008-09-23  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4
     5        - fix <rdar://problem/6233388> Crash beneath -[WebFrameView keyDown:]
     6
     7        Test: fast/events/keydown-remove-frame.html
     8
     9        * WebView/WebFrameView.mm:
     10        (-[WebFrameView keyDown:]): Added a null check.
     11
    1122008-09-21  Dirk Schulze  <vbs85@gmx.de>
    213
  • trunk/WebKit/mac/WebView/WebFrameView.mm

    r36553 r36810  
    704704    int index, count;
    705705    BOOL callSuper = YES;
    706     BOOL maintainsBackForwardList = core([self webFrame])->page()->backForwardList()->enabled() ? YES : NO;
     706    Frame* coreFrame = [self _web_frame];
     707    BOOL maintainsBackForwardList = coreFrame && coreFrame->page()->backForwardList()->enabled() ? YES : NO;
    707708   
    708709    count = [characters length];
Note: See TracChangeset for help on using the changeset viewer.