Changeset 49131 in webkit


Ignore:
Timestamp:
Oct 5, 2009 4:37:22 PM (14 years ago)
Author:
mitz@apple.com
Message:

REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs
<rdar://problem/7269108>
https://bugs.webkit.org/show_bug.cgi?id=29982

Reviewed by Darin Adler.

WebCore:

Test: fast/repaint/line-in-scrolled-clipped-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Use the unclipped overflow rect
(including layout overflow) for the repaint rect calculation.

LayoutTests:

  • fast/repaint/line-in-scrolled-clipped-block.html: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r49129 r49131  
     12009-10-05  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs
     6        <rdar://problem/7269108>
     7        https://bugs.webkit.org/show_bug.cgi?id=29982
     8
     9        * fast/repaint/line-in-scrolled-clipped-block.html: Added.
     10        * platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum: Added.
     11        * platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
     12        * platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
     13
    1142009-10-05  Hironori Bono  <hbono@chromium.org>
    215
  • trunk/WebCore/ChangeLog

    r49130 r49131  
     12009-10-05  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs
     6        <rdar://problem/7269108>
     7        https://bugs.webkit.org/show_bug.cgi?id=29982
     8
     9        Test: fast/repaint/line-in-scrolled-clipped-block.html
     10
     11        * rendering/RenderBlock.cpp:
     12        (WebCore::RenderBlock::layoutBlock): Use the unclipped overflow rect
     13        (including layout overflow) for the repaint rect calculation.
     14
    1152009-10-05  Drew Wilson  <atwilson@google.com>
    216
  • trunk/WebCore/rendering/RenderBlock.cpp

    r48679 r49131  
    775775    bool didFullRepaint = repainter.repaintAfterLayout();
    776776    if (!didFullRepaint && repaintTop != repaintBottom && (style()->visibility() == VISIBLE || enclosingLayer()->hasVisibleContent())) {
    777         IntRect repaintRect(leftVisibleOverflow(), repaintTop, rightVisibleOverflow() - leftVisibleOverflow(), repaintBottom - repaintTop);
     777        int repaintLeft = min(leftVisualOverflow(), leftLayoutOverflow());
     778        int repaintRight = max(rightVisualOverflow(), rightLayoutOverflow());
     779        IntRect repaintRect(repaintLeft, repaintTop, repaintRight - repaintLeft, repaintBottom - repaintTop);
    778780
    779781        // FIXME: Deal with multiple column repainting.  We have to split the repaint
Note: See TracChangeset for help on using the changeset viewer.