Changeset 74099 in webkit


Ignore:
Timestamp:
Dec 14, 2010 11:10:28 PM (13 years ago)
Author:
mitz@apple.com
Message:

<rdar://problem/8767193> REGRESSION (r60822): caps-lock-indicator is accepted as a -webkit-appearance value
​https://bugs.webkit.org/show_bug.cgi?id=51096

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/css/appearance-caps-lock-indicator.html

  • css/CSSValueKeywords.in: Moved caps-lock-indicator outside the range of values that should be

accepted by the parser, and added comments about maintaining the list of appearance values.

  • platform/ThemeTypes.h: Moved CapsLockIndicatorPart to the end of the ControlPart enum.

LayoutTests:

  • fast/css/appearance-caps-lock-indicator-expected.txt: Added.
  • fast/css/appearance-caps-lock-indicator.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r74098 r74099  
     12010-12-14  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        <rdar://problem/8767193> REGRESSION (r60822): caps-lock-indicator is accepted as a -webkit-appearance value
     6        https://bugs.webkit.org/show_bug.cgi?id=51096
     7
     8        * fast/css/appearance-caps-lock-indicator-expected.txt: Added.
     9        * fast/css/appearance-caps-lock-indicator.html: Added.
     10
    1112010-12-14  takano takumi  <takano@apple.com>
     12
    213        Reviewed by Dan Bernstein.
    314

  • trunk/WebCore/ChangeLog

    r74098 r74099  
     12010-12-14  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        <rdar://problem/8767193> REGRESSION (r60822): caps-lock-indicator is accepted as a -webkit-appearance value
     6        https://bugs.webkit.org/show_bug.cgi?id=51096
     7
     8        Test: fast/css/appearance-caps-lock-indicator.html
     9
     10        * css/CSSValueKeywords.in: Moved caps-lock-indicator outside the range of values that should be
     11        accepted by the parser, and added comments about maintaining the list of appearance values.
     12        * platform/ThemeTypes.h: Moved CapsLockIndicatorPart to the end of the ControlPart enum.
     13
    1142010-12-14  takano takumi  <takano@apple.com>
    215

  • trunk/WebCore/css/CSSValueKeywords.in

    r74098 r74099  
    560560after-white-space
    561561
    562 #
    563 # CSS_PROP__KHTML_APPEARANCE
    564 #
     562# -webkit-appearance
     563# The order here should match the order in the ControlPart enum in ThemeTypes.h.
     564# All appearance values that should be accepted by the parser should be listed between 'checkbox' and 'textarea':
    565565checkbox
    566566radio
    … …  
    612612searchfield-cancel-button
    613613textfield
    614 caps-lock-indicator
    615614relevancy-level-indicator
    616615continuous-capacity-level-indicator
    … …  
    618617rating-level-indicator
    619618textarea
     619# An appearance value that should not be accepted by the parser:
     620caps-lock-indicator
    620621
    621622#

  • trunk/WebCore/platform/ThemeTypes.h

    r66251 r74099  
    5757    SliderThumbVerticalPart, CaretPart, SearchFieldPart, SearchFieldDecorationPart,
    5858    SearchFieldResultsDecorationPart, SearchFieldResultsButtonPart,
    59     SearchFieldCancelButtonPart, TextFieldPart, CapsLockIndicatorPart,
     59    SearchFieldCancelButtonPart, TextFieldPart,
    6060    RelevancyLevelIndicatorPart, ContinuousCapacityLevelIndicatorPart, DiscreteCapacityLevelIndicatorPart, RatingLevelIndicatorPart,
    61     TextAreaPart
     61    TextAreaPart, CapsLockIndicatorPart
    6262};
    6363
Note: See TracChangeset for help on using the changeset viewer.