Changeset 74326 in webkit

Timestamp:

Dec 19, 2010 1:29:35 PM (13 years ago)

Author:

mitz@apple.com

Message:

Text emphasis marks are not repainted correctly in flipped writing modes
​https://bugs.webkit.org/show_bug.cgi?id=51307

Reviewed by Cameron Zwarich.

WebCore:

Tests: fast/repaint/text-emphasis-h.html

fast/repaint/text-emphasis-v.html

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added flippedness check.

LayoutTests:

• fast/repaint/text-emphasis-h-expected.checksum: Added.
• fast/repaint/text-emphasis-h-expected.png: Added.
• fast/repaint/text-emphasis-h-expected.txt: Added.
• fast/repaint/text-emphasis-h.html: Added.
• fast/repaint/text-emphasis-v-expected.checksum: Added.
• fast/repaint/text-emphasis-v-expected.png: Added.
• fast/repaint/text-emphasis-v-expected.txt: Added.
• fast/repaint/text-emphasis-v.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/text-emphasis-h-expected.checksum (added)
• LayoutTests/fast/repaint/text-emphasis-h-expected.png (added)
• LayoutTests/fast/repaint/text-emphasis-h-expected.txt (added)
• LayoutTests/fast/repaint/text-emphasis-h.html (added)
• LayoutTests/fast/repaint/text-emphasis-v-expected.checksum (added)
• LayoutTests/fast/repaint/text-emphasis-v-expected.png (added)
• LayoutTests/fast/repaint/text-emphasis-v-expected.txt (added)
• LayoutTests/fast/repaint/text-emphasis-v.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/InlineFlowBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-12-19  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Cameron Zwarich.
+
+        Text emphasis marks are not repainted correctly in flipped writing modes
+        https://bugs.webkit.org/show_bug.cgi?id=51307
+
+        * fast/repaint/text-emphasis-h-expected.checksum: Added.
+        * fast/repaint/text-emphasis-h-expected.png: Added.
+        * fast/repaint/text-emphasis-h-expected.txt: Added.
+        * fast/repaint/text-emphasis-h.html: Added.
+        * fast/repaint/text-emphasis-v-expected.checksum: Added.
+        * fast/repaint/text-emphasis-v-expected.png: Added.
+        * fast/repaint/text-emphasis-v-expected.txt: Added.
+        * fast/repaint/text-emphasis-v.html: Added.
+
 2010-12-18  Tom Sepez  <tsepez@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-19  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Cameron Zwarich.
+
+        Text emphasis marks are not repainted correctly in flipped writing modes
+        https://bugs.webkit.org/show_bug.cgi?id=51307
+
+        Tests: fast/repaint/text-emphasis-h.html
+               fast/repaint/text-emphasis-v.html
+
+        * rendering/InlineFlowBox.cpp:
+        (WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added flippedness check.
+
 2010-12-19  Rob Buis  <rwlbuis@gmail.com>
 

trunk/WebCore/rendering/InlineFlowBox.cpp

@@ -748 +748 @@
     if (style->textEmphasisMark() != TextEmphasisMarkNone) {
         int emphasisMarkHeight = style->font().emphasisMarkHeight(style->textEmphasisMarkString());
-        if (style->textEmphasisPosition() == TextEmphasisPositionOver)
+        if ((style->textEmphasisPosition() == TextEmphasisPositionOver) == (!style->isFlippedLinesWritingMode()))
             topGlyphOverflow = min(topGlyphOverflow, -emphasisMarkHeight);
         else