Changeset 117537 in webkit

Timestamp:

May 17, 2012 9:33:59 PM (12 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/11419933> Problems with flipped writing modes and compositing
​https://bugs.webkit.org/show_bug.cgi?id=86032

Reviewed by Anders Carlsson.

Source/WebCore:

Test: compositing/bounds-in-flipped-writing-mode.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds): Apply a writing-mode flip to the bounding box
if needed.

LayoutTests:

• compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
• compositing/bounds-in-flipped-writing-mode.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/bounds-in-flipped-writing-mode-expected.txt (added)
• LayoutTests/compositing/bounds-in-flipped-writing-mode.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-17  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/11419933> Problems with flipped writing modes and compositing
+        https://bugs.webkit.org/show_bug.cgi?id=86032
+
+        Reviewed by Anders Carlsson.
+
+        * compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
+        * compositing/bounds-in-flipped-writing-mode.html: Added.
+
 2012-05-17  Peter Kasting  <pkasting@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/11419933> Problems with flipped writing modes and compositing
+        https://bugs.webkit.org/show_bug.cgi?id=86032
+
+        Reviewed by Anders Carlsson.
+
+        Test: compositing/bounds-in-flipped-writing-mode.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::calculateLayerBounds): Apply a writing-mode flip to the bounding box
+        if needed.
+
 2012-05-17  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -4150 +4150 @@
     if (!layer->isSelfPaintingLayer())
         return IntRect();
-    
+
     LayoutRect boundingBoxRect = layer->localBoundingBox();
+    if (layer->renderer()->isBox())
+        layer->renderBox()->flipForWritingMode(boundingBoxRect);
+    else
+        layer->renderer()->containingBlock()->flipForWritingMode(boundingBoxRect);
+
     if (layer->renderer()->isRoot()) {
         // If the root layer becomes composited (e.g. because some descendant with negative z-index is composited),