Changeset 145042 in webkit


Ignore:
Timestamp:
Mar 6, 2013 11:25:20 PM (11 years ago)
Author:
ap@apple.com
Message:

SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty
https://bugs.webkit.org/show_bug.cgi?id=111689

Reviewed by Filip Pizlo.

  • Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle): Use a function from WebCore platform layer instead of Foundation one equivalent. We already do this elsewhere in this file.
Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r145039 r145042  
     12013-03-06  Alexey Proskuryakov  <ap@apple.com>
     2
     3        SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty
     4        https://bugs.webkit.org/show_bug.cgi?id=111689
     5
     6        Reviewed by Filip Pizlo.
     7
     8        * Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle):
     9        Use a function from WebCore platform layer instead of Foundation one equivalent.
     10        We already do this elsewhere in this file.
     11
    1122013-03-06  Tim Horton  <timothy_horton@apple.com>
    213
  • trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm

    r144788 r145042  
    215215    ASSERT(!handle.m_sandboxExtension);
    216216
    217     CString standardizedPath = resolveSymlinksInPath([[(NSString *)path stringByStandardizingPath] fileSystemRepresentation]);
     217    // FIXME: Do we need both resolveSymlinksInPath() and -stringByStandardizingPath?
     218    CString standardizedPath = resolveSymlinksInPath(fileSystemRepresentation([(NSString *)path stringByStandardizingPath]));
    218219    handle.m_sandboxExtension = WKSandboxExtensionCreate(standardizedPath.data(), wkSandboxExtensionType(type));
    219220    if (!handle.m_sandboxExtension)
Note: See TracChangeset for help on using the changeset viewer.