Changeset 148263 in webkit


Ignore:
Timestamp:
Apr 11, 2013 11:11:46 PM (11 years ago)
Author:
ap@apple.com
Message:

Reduce includes of CachedSVGDocument.h
​https://bugs.webkit.org/show_bug.cgi?id=114489

Reviewed by Jon Honeycutt.

  • loader/cache/CachedSVGDocumentReference.cpp: Added.
  • loader/cache/CachedSVGDocumentReference.h: Moved function implementations to newly added .cpp file, and removed an include of CachedSVGDocument.h.
  • css/WebKitCSSSVGDocumentValue.h: Just removed an unnecessary include.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
Location:
trunk/Source/WebCore
Files:
1 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r148197 r148263  
    17391739    loader/cache/CachedShader.cpp
    17401740    loader/cache/CachedSVGDocument.cpp
     1741    loader/cache/CachedSVGDocumentReference.cpp
    17411742    loader/cache/CachedTextTrack.cpp
    17421743    loader/cache/CachedXSLStyleSheet.cpp

  • trunk/Source/WebCore/ChangeLog

    r148262 r148263  
     12013-04-11  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Reduce includes of CachedSVGDocument.h
     4        https://bugs.webkit.org/show_bug.cgi?id=114489
     5
     6        Reviewed by Jon Honeycutt.
     7
     8        * loader/cache/CachedSVGDocumentReference.cpp: Added.
     9        * loader/cache/CachedSVGDocumentReference.h:
     10        Moved function implementations to newly added .cpp file, and removed an include
     11        of CachedSVGDocument.h.
     12
     13        * css/WebKitCSSSVGDocumentValue.h: Just removed an unnecessary include.
     14
     15        * CMakeLists.txt:
     16        * GNUmakefile.list.am:
     17        * Target.pri:
     18        * WebCore.vcproj/WebCore.vcproj:
     19        * WebCore.vcxproj/WebCore.vcxproj:
     20        * WebCore.vcxproj/WebCore.vcxproj.filters:
     21        * WebCore.xcodeproj/project.pbxproj:
     22
    1232013-04-11  Commit Queue  <rniwa@webkit.org>
    224

  • trunk/Source/WebCore/GNUmakefile.list.am

    r148256 r148263  
    48574857        Source/WebCore/loader/cache/CachedSVGDocument.h \
    48584858        Source/WebCore/loader/cache/CachedSVGDocumentClient.h \
     4859        Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp \
    48594860        Source/WebCore/loader/cache/CachedSVGDocumentReference.h \
    48604861        Source/WebCore/platform/graphics/SVGGlyph.cpp \

  • trunk/Source/WebCore/Target.pri

    r148256 r148263  
    859859    loader/cache/CachedShader.cpp \
    860860    loader/cache/CachedSVGDocument.cpp \
    861     loader/cache/CachedSVGDocument.h \
     861    loader/cache/CachedSVGDocumentReference.cpp \
    862862    loader/cache/CachedXSLStyleSheet.cpp \
    863863    loader/CookieJar.cpp \

  • trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj

    r148256 r148263  
    2876328763                                </File>
    2876428764                                <File
     28765                                        RelativePath="..\loader\cache\CachedSVGDocumentReference.cpp"
     28766                                        >
     28767                                </File>
     28768                                <File
    2876528769                                        RelativePath="..\loader\cache\CachedSVGDocumentReference.h"
    2876628770                                        >

  • trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj

    r148256 r148263  
    40754075    <ClCompile Include="..\loader\cache\CachedShader.cpp" />
    40764076    <ClCompile Include="..\loader\cache\CachedSVGDocument.cpp" />
     4077    <ClCompile Include="..\loader\cache\CachedSVGDocumentReference.cpp" />
    40774078    <ClCompile Include="..\loader\cache\CachedTextTrack.cpp" />
    40784079    <ClCompile Include="..\loader\cache\CachedXSLStyleSheet.cpp" />

  • trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters

    r148256 r148263  
    24372437      <Filter>loader\cache</Filter>
    24382438    </ClCompile>
     2439    <ClCompile Include="..\loader\cache\CachedSVGDocumentReference.cpp">
     2440      <Filter>loader\cache</Filter>
     2441    </ClCompile>
    24392442    <ClCompile Include="..\loader\cache\CachedTextTrack.cpp">
    24402443      <Filter>loader\cache</Filter>

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r148257 r148263  
    54555455                E1B25107152A0BB00069B779 /* StylePropertyShorthand.h in Headers */ = {isa = PBXBuildFile; fileRef = E1B25105152A0BAF0069B779 /* StylePropertyShorthand.h */; };
    54565456                E1B4CD2510B322E200BFFD7E /* CredentialStorageMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = E1B4CD2410B322E200BFFD7E /* CredentialStorageMac.mm */; };
     5457                E1B533471717D0A100F205F9 /* CachedSVGDocumentReference.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1B533461717D0A000F205F9 /* CachedSVGDocumentReference.cpp */; };
    54575458                E1B7839C163740A70007B692 /* SharedWorkerStrategy.h in Headers */ = {isa = PBXBuildFile; fileRef = E1B7839B163740A70007B692 /* SharedWorkerStrategy.h */; settings = {ATTRIBUTES = (Private, ); }; };
    54585459                E1B784201639CBBE0007B692 /* SharedWorkerRepository.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1B7841F1639CBBE0007B692 /* SharedWorkerRepository.cpp */; };
    … …  
    1225912260                E1B25105152A0BAF0069B779 /* StylePropertyShorthand.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StylePropertyShorthand.h; sourceTree = "<group>"; };
    1226012261                E1B4CD2410B322E200BFFD7E /* CredentialStorageMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CredentialStorageMac.mm; sourceTree = "<group>"; };
     12262                E1B533461717D0A000F205F9 /* CachedSVGDocumentReference.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CachedSVGDocumentReference.cpp; sourceTree = "<group>"; };
    1226112263                E1B7839B163740A70007B692 /* SharedWorkerStrategy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = SharedWorkerStrategy.h; path = workers/SharedWorkerStrategy.h; sourceTree = "<group>"; };
    1226212264                E1B7841F1639CBBE0007B692 /* SharedWorkerRepository.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = SharedWorkerRepository.cpp; path = workers/SharedWorkerRepository.cpp; sourceTree = "<group>"; };
    … …  
    1757917581                                A104F24214C71F7A009E2C23 /* CachedSVGDocument.h */,
    1758017582                                1AEF4E68170E174800AB2799 /* CachedSVGDocumentClient.h */,
     17583                                E1B533461717D0A000F205F9 /* CachedSVGDocumentReference.cpp */,
    1758117584                                FB2C15C2165D64900039C9F8 /* CachedSVGDocumentReference.h */,
    1758217585                                0753860014489E9800B78452 /* CachedTextTrack.cpp */,
    … …  
    2699927002                                E180811616FCF9CB00B80D07 /* SynchronousLoaderClient.mm in Sources */,
    2700027003                                E152551616FD2350003D7ADB /* WebCoreResourceHandleAsOperationQueueDelegate.mm in Sources */,
     27004                                E1B533471717D0A100F205F9 /* CachedSVGDocumentReference.cpp in Sources */,
    2700127005                        );
    2700227006                        runOnlyForDeploymentPostprocessing = 0;

  • trunk/Source/WebCore/css/WebKitCSSSVGDocumentValue.h

    r144565 r148263  
    2828#include "CSSValue.h"
    2929#include "CachedResourceHandle.h"
    30 #include "CachedSVGDocument.h"
    3130
    3231namespace WebCore {
    3332
    3433class CachedResourceLoader;
     34class CachedSVGDocument;
    3535
    3636class WebKitCSSSVGDocumentValue : public CSSValue {

  • trunk/Source/WebCore/loader/cache/CachedSVGDocumentReference.h

    r147684 r148263  
    3030
    3131#include "CachedResourceHandle.h"
    32 #include "CachedSVGDocument.h"
    3332#include "CachedSVGDocumentClient.h"
    3433
    3534namespace WebCore {
    3635
     36class CachedSVGDocument;
     37
    3738class CachedSVGDocumentReference : public CachedSVGDocumentClient {
    3839public:
    39     CachedSVGDocumentReference(CachedSVGDocument* document) : m_document(document) { m_document->addClient(this); }
    40     virtual ~CachedSVGDocumentReference() { m_document->removeClient(this); }
     40    CachedSVGDocumentReference(CachedSVGDocument*);
     41    virtual ~CachedSVGDocumentReference();
    4142    CachedSVGDocument* document() { return m_document.get(); }
     43
    4244private:
    4345    CachedResourceHandle<CachedSVGDocument> m_document;
Note: See TracChangeset for help on using the changeset viewer.