Changeset 153725 in webkit

Timestamp:

Aug 5, 2013, 2:56:15 PM (12 years ago)

Author:

ap@apple.com

Message:

<rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way
of text when dictating an e-mail
​https://bugs.webkit.org/show_bug.cgi?id=119496

Reviewed by Ryosuke Niwa.

Test: platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRectForRange): FloatRect::unite() doesn't preserve empty rects, which we need here. We alrady handle the case of collapsed range in Editor::firstRectForRange(), and this is similar, but we can't currently cover both with one simple fix.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-caret-in-br-expected.txt (added)
• LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html (added)
• LayoutTests/platform/wk2/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-08-05  Alexey Proskuryakov  <ap@apple.com>
+
+        <rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way
+        of text when dictating an e-mail
+        https://bugs.webkit.org/show_bug.cgi?id=119496
+
+        Reviewed by Ryosuke Niwa.
+
+        * platform/mac/editing/input/firstrectforcharacterrange-caret-in-br-expected.txt: Added.
+        * platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html: Added.
+
+        * platform/wk2/TestExpectations: textInputController.firstRectForCharacterRange is
+        not available in WTR.
+
 2013-08-05  Morten Stenshorne  <mstensho@opera.com>
 

trunk/LayoutTests/platform/wk2/TestExpectations

@@ -126 +126 @@
 platform/mac/editing/input/bold-node.html
 platform/mac/editing/input/caret-primary-bidi.html
+platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html
 platform/mac/editing/input/firstrectforcharacterrange-plain.html
 platform/mac/editing/input/firstrectforcharacterrange-styled.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-05  Alexey Proskuryakov  <ap@apple.com>
+
+        <rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way
+        of text when dictating an e-mail
+        https://bugs.webkit.org/show_bug.cgi?id=119496
+
+        Reviewed by Ryosuke Niwa.
+
+        Test: platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html
+
+        * rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRectForRange):
+        FloatRect::unite() doesn't preserve empty rects, which we need here.
+        We alrady handle the case of collapsed range in Editor::firstRectForRange(), and
+        this is similar, but we can't currently cover both with one simple fix.
+
 2013-08-05  Morten Stenshorne  <mstensho@opera.com>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -1244 +1244 @@
     range->textQuads(quads);
 
-    FloatRect result;
-    for (size_t i = 0; i < quads.size(); ++i)
-        result.unite(quads[i].boundingBox());
+    if (quads.isEmpty())
+        return FloatRect();
+
+    FloatRect result = quads[0].boundingBox();
+    for (size_t i = 1; i < quads.size(); ++i)
+        result.uniteEvenIfEmpty(quads[i].boundingBox());
 
     return result;