Changeset 155561 in webkit

Timestamp:

Sep 11, 2013, 2:02:36 PM (11 years ago)

Author:

mitz@apple.com

Message:

update-webkit-localizable-strings is at least 5.8x slower than it should be
​https://bugs.webkit.org/show_bug.cgi?id=121178

Reviewed by Darin Adler.

• Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.

Note that this does not change functionality, because the script already does not understand
the line continuation sequence (backslash followed by a newline).

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/extract-localizable-strings (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-09-11  Dan Bernstein  <mitz@apple.com>
+
+        update-webkit-localizable-strings is at least 5.8x slower than it should be
+        https://bugs.webkit.org/show_bug.cgi?id=121178
+
+        Reviewed by Darin Adler.
+
+        * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
+        Note that this does not change functionality, because the script already does not understand
+        the line continuation sequence (backslash followed by a newline).
+
 2013-09-11  Anders Carlsson  <andersca@apple.com>
 

trunk/Tools/Scripts/extract-localizable-strings

@@ -145 +145 @@
             $inComment = 0;
         }
+
+        next unless /(\"|\/\*)/;
     
         # Handle all the tokens in the line.