Changeset 162006 in webkit

Timestamp:

Jan 14, 2014 2:11:43 PM (10 years ago)

Author:

mark.lam@apple.com

Message:

ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
​https://bugs.webkit.org/show_bug.cgi?id=126990.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseConstDeclarationList):

• We were missing an error check after attempting to parse an initializer expression. This is now fixed.

LayoutTests:

• js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
• js/dom/parse-syntax-error-in-initializer.html: Added.
• js/resources/parse-syntax-error-in-initializer.js: Added.
• Added bug test case as a regression test.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/dom/parse-syntax-error-in-initializer-expected.txt (added)
• LayoutTests/js/dom/parse-syntax-error-in-initializer.html (added)
• LayoutTests/js/resources/parse-syntax-error-in-initializer.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Parser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-01-14  Mark Lam  <mark.lam@apple.com>
+
+        ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
+        https://bugs.webkit.org/show_bug.cgi?id=126990.
+
+        Reviewed by Geoffrey Garen.
+
+        * js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
+        * js/dom/parse-syntax-error-in-initializer.html: Added.
+        * js/resources/parse-syntax-error-in-initializer.js: Added.
+        - Added bug test case as a regression test.
+
 2014-01-14  Roger Fong  <roger_fong@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-01-14  Mark Lam  <mark.lam@apple.com>
+
+        ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
+        https://bugs.webkit.org/show_bug.cgi?id=126990.
+
+        Reviewed by Geoffrey Garen.
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseConstDeclarationList):
+        - We were missing an error check after attempting to parse an initializer
+          expression. This is now fixed.
+
 2014-01-14  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -661 +661 @@
             next(TreeBuilder::DontBuildStrings); // consume '='
             initializer = parseAssignmentExpression(context);
+            failIfFalse(!!initializer, "Unable to parse initializer");
         }
         tail = context.appendConstDecl(location, tail, name, initializer);