Changeset 164300 in webkit


Ignore:
Timestamp:
Feb 18, 2014 11:36:41 AM (10 years ago)
Author:
mitz@apple.com
Message:

[Cocoa] Implement -description in some API objects
​https://bugs.webkit.org/show_bug.cgi?id=128956

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

Changed category name to have the framework’s prefix.
(-[WKRemoteObjectInterface description]): Added.

  • UIProcess/API/Cocoa/WKFrameInfo.mm:

(-[WKFrameInfo description]): Added.

  • UIProcess/API/Cocoa/WKNavigationAction.mm:

(-[WKNavigationAction description]): Added.

  • UIProcess/API/Cocoa/WKNavigationResponse.mm:

(-[WKNavigationResponse description]): Added.

  • UIProcess/API/Cocoa/WKProcessClass.mm:

(-[WKProcessClass description]): Added.

  • UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:

(-[WKProcessClassConfiguration description]): Added.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration description]): Added.

Location:
trunk/Source/WebKit2
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r164273 r164300  
     12014-02-18  Dan Bernstein  <mitz@apple.com>
     2
     3        [Cocoa] Implement -description in some API objects
     4        https://bugs.webkit.org/show_bug.cgi?id=128956
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * Shared/API/Cocoa/WKRemoteObjectInterface.mm:
     9        Changed category name to have the framework’s prefix.
     10        (-[WKRemoteObjectInterface description]): Added.
     11        * UIProcess/API/Cocoa/WKFrameInfo.mm:
     12        (-[WKFrameInfo description]): Added.
     13        * UIProcess/API/Cocoa/WKNavigationAction.mm:
     14        (-[WKNavigationAction description]): Added.
     15        * UIProcess/API/Cocoa/WKNavigationResponse.mm:
     16        (-[WKNavigationResponse description]): Added.
     17        * UIProcess/API/Cocoa/WKProcessClass.mm:
     18        (-[WKProcessClass description]): Added.
     19        * UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:
     20        (-[WKProcessClassConfiguration description]): Added.
     21        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
     22        (-[WKWebViewConfiguration description]): Added.
     23
    1242014-02-17  ChangSeok Oh  <changseok.oh@collabora.com>
    225

  • trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm

    r163630 r164300  
    3737const char *_protocol_getMethodTypeEncoding(Protocol *p, SEL sel, BOOL isRequiredMethod, BOOL isInstanceMethod);
    3838
    39 @interface NSMethodSignature (Details)
     39@interface NSMethodSignature (WKDetails)
    4040- (Class)_classForObjectAtArgumentIndex:(NSInteger)idx;
    4141@end
    … …  
    142142}
    143143
     144- (NSString *)description
     145{
     146    return [NSString stringWithFormat:@"<%@: %p; protocol = \"%@\"; identifier = \"%@\">", NSStringFromClass(self.class), self, _identifier, NSStringFromProtocol(_protocol)];
     147}
     148
    144149static RetainPtr<NSSet>& classesForSelectorArgument(WKRemoteObjectInterface *interface, SEL selector, NSUInteger argumentIndex)
    145150{

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm

    r163563 r164300  
    4949}
    5050
     51- (NSString *)description
     52{
     53    return [NSString stringWithFormat:@"<%@: %p; isMainFrame = %s; request = %@>", NSStringFromClass(self.class), self, _mainFrame ? "YES" : "NO", _request.get()];
     54}
     55
    5156- (NSURLRequest *)request
    5257{

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm

    r163997 r164300  
    3737}
    3838
     39- (NSString *)description
     40{
     41    return [NSString stringWithFormat:@"<%@: %p; navigationType = %ld; request = %@; sourceFrame = %@; destinationFrame = %@>", NSStringFromClass(self.class), self,
     42        (long)_navigationType, _request.get(), _sourceFrame.get(), _destinationFrame.get()];
     43}
     44
    3945- (WKFrameInfo *)sourceFrame
    4046{

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationResponse.mm

    r163563 r164300  
    3636}
    3737
     38- (NSString *)description
     39{
     40    return [NSString stringWithFormat:@"<%@: %p; frame = %@; response = %@>", NSStringFromClass(self.class), self, _frame.get(), _response.get()];
     41}
     42
    3843- (WKFrameInfo *)frame
    3944{

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm

    r164258 r164300  
    7979}
    8080
     81- (NSString *)description
     82{
     83    return [NSString stringWithFormat:@"<%@: %p; configuration = %@>", NSStringFromClass(self.class), self, _configuration.get()];
     84}
     85
    8186- (WKProcessClassConfiguration *)configuration
    8287{

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.mm

    r162873 r164300  
    4545}
    4646
     47- (NSString *)description
     48{
     49    NSString *description = [NSString stringWithFormat:@"<%@: %p; maximumProcessCount = %ld", NSStringFromClass(self.class), self, _maximumProcessCount];
     50    if (_injectedBundleURL)
     51        return [description stringByAppendingFormat:@"; injectedBundleURL: \"%@\">", _injectedBundleURL.get()];
     52
     53    return [description stringByAppendingString:@">"];
     54}
     55
    4756- (id)copyWithZone:(NSZone *)zone
    4857{

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

    r164004 r164300  
    3636    RetainPtr<WKPreferences> _preferences;
    3737    WebKit::WeakObjCPtr<WKWebView> _relatedWebView;
     38}
     39
     40- (NSString *)description
     41{
     42    return [NSString stringWithFormat:@"<%@: %p; processClass = %@; preferences = %@>", NSStringFromClass(self.class), self, _processClass.get(), _preferences.get()];
    3843}
    3944
Note: See TracChangeset for help on using the changeset viewer.