Changeset 171129 in webkit

Timestamp:

Jul 15, 2014 6:29:18 PM (10 years ago)

Author:

mitz@apple.com

Message:

WKWebView’s FormClient::willSubmitForm should use CompletionHandlerCallChecker
​https://bugs.webkit.org/show_bug.cgi?id=134951

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setFormDelegate:]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-07-15  Dan Bernstein  <mitz@apple.com>
+
+        WKWebView’s FormClient::willSubmitForm should use CompletionHandlerCallChecker
+        https://bugs.webkit.org/show_bug.cgi?id=134951
+
+        Reviewed by Tim Horton.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _setFormDelegate:]):
+
 2014-07-15  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

@@ -30 +30 @@
 
 #import "APIFormClient.h"
+#import "CompletionHandlerCallChecker.h"
 #import "FindClient.h"
 #import "LegacySessionStateCoding.h"
@@ -1977 +1978 @@
             }
 
-            [formDelegate _webView:m_webView willSubmitFormValues:valueMap.get() userObject:userObject submissionHandler:^{
+            RefPtr<WebKit::CompletionHandlerCallChecker> checker = WebKit::CompletionHandlerCallChecker::create(formDelegate.get(), @selector(_webView:willSubmitFormValues:userObject:submissionHandler:));
+            [formDelegate _webView:m_webView willSubmitFormValues:valueMap.get() userObject:userObject submissionHandler:[listener, checker] {
+                checker->didCallCompletionHandler();
                 listener->continueSubmission();
             }];