Changeset 171772 in webkit
- Timestamp:
- Jul 29, 2014 3:41:19 PM (10 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r171745 r171772 1 2014-07-29 Alexey Proskuryakov <ap@apple.com> 2 3 fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines 4 https://bugs.webkit.org/show_bug.cgi?id=135398 5 6 Reviewed by Zalan Bujtas. 7 8 * platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was 9 the actual reason for it to appear failing? 10 1 11 2014-07-29 Mihnea Ovidenie <mihnea@adobe.com> 2 12 -
trunk/LayoutTests/platform/mac-wk2/TestExpectations
r171302 r171772 298 298 webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-nested-compositing-layers-with-subpixel-accumulation.html [ ImageOnlyFailure ] 299 299 webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-box-positioned-off-by-one-when-non-compositing-transform-is-present.html [ ImageOnlyFailure ] 300 webkit.org/b/130175 [ MountainLion ] fast/borders/border-radius-on-subpixel-position-non-hidpi.html [ Pass ImageOnlyFailure ]301 300 302 301 # Only failing on WK1 -
trunk/Tools/ChangeLog
r171756 r171772 1 2014-07-29 Alexey Proskuryakov <ap@apple.com> 2 3 fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines 4 https://bugs.webkit.org/show_bug.cgi?id=135398 5 6 Reviewed by Zalan Bujtas. 7 8 * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest): 9 "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names. 10 11 * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix. 12 For some reason, I wasn't seeing this test fail on WK1 even without the fix, not 13 sure why. 14 1 15 2014-07-29 Alexey Proskuryakov <ap@apple.com> 2 16 -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r171687 r171772 1468 1468 bool hasHighDPIWindow = [[[mainFrame webView] window] backingScaleFactor] != 1; 1469 1469 WTF::String localPathOrUrl = String(testPathOrUR); 1470 bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase(" hidpi-") != notFound;1470 bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound; 1471 1471 if (hasHighDPIWindow == needsHighDPIWindow) 1472 1472 return; -
trunk/Tools/WebKitTestRunner/TestController.cpp
r171756 r171772 681 681 { 682 682 WTF::String localPathOrUrl = String(test.pathOrURL()); 683 bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase(" hidpi-") != notFound;683 bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound; 684 684 mainWebView()->changeWindowScaleIfNeeded(needsHighDPIWindow ? 2 : 1); 685 685 }
Note: See TracChangeset
for help on using the changeset viewer.