Changeset 171772 in webkit

Timestamp:

Jul 29, 2014 3:41:19 PM (10 years ago)

Author:

ap@apple.com

Message:

fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
​https://bugs.webkit.org/show_bug.cgi?id=135398

Reviewed by Zalan Bujtas.

Tools:

• WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):

"hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.

• DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.

For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
sure why.

LayoutTests:

• platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was

the actual reason for it to appear failing?

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/TestExpectations (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/mac/DumpRenderTree.mm (modified) (1 diff)
• Tools/WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-07-29  Alexey Proskuryakov  <ap@apple.com>
+
+        fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
+        https://bugs.webkit.org/show_bug.cgi?id=135398
+
+        Reviewed by Zalan Bujtas.
+
+        * platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was
+        the actual reason for it to appear failing?
+
 2014-07-29  Mihnea Ovidenie  <mihnea@adobe.com>
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -298 +298 @@
 webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-nested-compositing-layers-with-subpixel-accumulation.html [ ImageOnlyFailure ]
 webkit.org/b/130175 [ MountainLion Debug ] compositing/hidpi-box-positioned-off-by-one-when-non-compositing-transform-is-present.html [ ImageOnlyFailure ]
-webkit.org/b/130175 [ MountainLion ] fast/borders/border-radius-on-subpixel-position-non-hidpi.html [ Pass ImageOnlyFailure ]
 
 # Only failing on WK1

trunk/Tools/ChangeLog

@@ +1 @@
+2014-07-29  Alexey Proskuryakov  <ap@apple.com>
+
+        fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
+        https://bugs.webkit.org/show_bug.cgi?id=135398
+
+        Reviewed by Zalan Bujtas.
+
+        * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
+        "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
+        For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
+        sure why.
+
 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

@@ -1468 +1468 @@
     bool hasHighDPIWindow = [[[mainFrame webView] window] backingScaleFactor] != 1;
     WTF::String localPathOrUrl = String(testPathOrUR);
-    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("hidpi-") != notFound;
+    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound;
     if (hasHighDPIWindow == needsHighDPIWindow)
         return;

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -681 +681 @@
 {
     WTF::String localPathOrUrl = String(test.pathOrURL());
-    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("hidpi-") != notFound;
+    bool needsHighDPIWindow = localPathOrUrl.findIgnoringCase("/hidpi-") != notFound;
     mainWebView()->changeWindowScaleIfNeeded(needsHighDPIWindow ? 2 : 1);
 }