Changeset 173048 in webkit


Ignore:
Timestamp:
Aug 27, 2014 10:19:01 PM (10 years ago)
Author:
ap@apple.com
Message:

EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
​https://bugs.webkit.org/show_bug.cgi?id=131668

Reviewed by Daniel Bates.

We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
to not just hardcode.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:

(EWS.prototype.queueStatusURL): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:

(EWSQueue.prototype.get statusPageURL): Use the above function.
(EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:

(EWSQueueView.prototype.update): While at it, made a popover show up even if there
are no patches in the queue. The popover has other useful information, such as charts
link and bot status.

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js

    r170741 r173048  
    5858        return this.baseURL + "queue-status-json/" + encodeURIComponent(queueID) + "-ews";
    5959    },
     60
     61    queueStatusURL: function(queueID)
     62    {
     63        return this.baseURL + "queue-status/" + encodeURIComponent(queueID) + "-ews";
     64    },
    6065};

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js

    r172893 r173048  
    5050    get statusPageURL()
    5151    {
    52         return this._statusPageURL;
     52        return this.ews.queueStatusURL(this.id);
    5353    },
    5454
    … …  
    133133            }
    134134
    135             this._statusPageURL = data.status_page;
     135            console.assert(this._statusPageURL === data.status_page);
    136136            this._chartsPageURL = data.charts_page;
    137137

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js

    r162373 r173048  
    6868            this.element.appendChild(status.element);
    6969
    70             if (patchCount > 0)
    71                 new PopoverTracker(status.statusBubbleElement, this._presentPopoverForEWSQueue.bind(this), queue);
     70            new PopoverTracker(status.statusBubbleElement, this._presentPopoverForEWSQueue.bind(this), queue);
    7271        }
    7372

  • trunk/Tools/ChangeLog

    r173027 r173048  
     12014-08-27  Alexey Proskuryakov  <ap@apple.com>
     2
     3        EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
     4        https://bugs.webkit.org/show_bug.cgi?id=131668
     5
     6        Reviewed by Daniel Bates.
     7
     8        We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
     9        to not just hardcode.
     10
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
     12        (EWS.prototype.queueStatusURL): Added.
     13
     14        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
     15        (EWSQueue.prototype.get statusPageURL): Use the above function.
     16        (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
     17
     18        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
     19        (EWSQueueView.prototype.update): While at it, made a popover show up even if there
     20        are no patches in the queue. The popover has other useful information, such as charts
     21        link and bot status.
     22
    1232014-08-27  Alexey Proskuryakov  <ap@apple.com>
    224
Note: See TracChangeset for help on using the changeset viewer.