Changeset 174124 in webkit

Timestamp:

Sep 30, 2014 2:30:22 PM (10 years ago)

Author:

ap@apple.com

Message:

Windows EWS went purple when it failed to build
​https://bugs.webkit.org/show_bug.cgi?id=137267

Reviewed by Ryosuke Niwa.

• QueueStatusServer/app.yaml: Update the version.

• QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):

Make it work for style and win-ews queues.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/app.yaml (modified) (1 diff)
• QueueStatusServer/model/attachment.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-09-30  Alexey Proskuryakov  <ap@apple.com>
+
+        Windows EWS went purple when it failed to build
+        https://bugs.webkit.org/show_bug.cgi?id=137267
+
+        Reviewed by Ryosuke Niwa.
+
+        * QueueStatusServer/app.yaml: Update the version.
+
+        * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
+        Make it work for style and win-ews queues.
+
 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Tools/QueueStatusServer/app.yaml

@@ -1 +1 @@
 application: webkit-queues
-version: 174115 # Bugzilla bug ID of last major change
+version: 174124 # Bugzilla bug ID of last major change
 runtime: python
 api_version: 1

trunk/Tools/QueueStatusServer/model/attachment.py

@@ -67 +67 @@
 
     def _calculate_queue_positions(self):
-        all_work_items = WorkItems.all().fetch(limit=len(Queue.all()))
+        # We don't know how many rows there are in the table (as there can be stale rows
+        # from queues that we no longer have), but it's certainly fewer that 1000.
+        all_work_items = WorkItems.all().fetch(limit=1000)
         return dict([(items.queue.name(), items.display_position_for_attachment(self.id)) for items in all_work_items if items.queue])