Changeset 174252 in webkit

Timestamp:

Oct 2, 2014 5:37:47 PM (10 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/18531395> REGRESSION (r173272): Crash in ResourceResponse::platformSuggestedFilename() when called on the null response
​https://bugs.webkit.org/show_bug.cgi?id=137239

Reviewed by Pratik Solanki.

• platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformSuggestedFilename): Return the null String if
m_cfResponse is null.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cf/ResourceResponseCFNet.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-10-02  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/18531395> REGRESSION (r173272): Crash in ResourceResponse::platformSuggestedFilename() when called on the null response
+        https://bugs.webkit.org/show_bug.cgi?id=137239
+
+        Reviewed by Pratik Solanki.
+
+        * platform/network/cf/ResourceResponseCFNet.cpp:
+        (WebCore::ResourceResponse::platformSuggestedFilename): Return the null String if
+        m_cfResponse is null.
+
 2014-10-02  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp

@@ -128 +128 @@
 String ResourceResponse::platformSuggestedFilename() const
 {
+    if (!m_cfResponse)
+        return String();
+
     RetainPtr<CFStringRef> suggestedFilename = adoptCF(CFURLResponseCopySuggestedFilename(m_cfResponse.get()));
     return suggestedFilename.get();