Changeset 174622 in webkit

Timestamp:

Oct 10, 2014 4:29:52 PM (10 years ago)

Author:

ap@apple.com

Message:

Dashboard metrics page should have EWS statistics
​https://bugs.webkit.org/show_bug.cgi?id=137626

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:

(BubbleQueue): Put shortName in the object, so that it's actually useful.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer): Re-ordered queues to match bubble order.
(BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
(BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:

Added analysis for bubble queues.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:

(buildBubbleQueuesTable): Build the UI.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:

Added JS sources to load.

• QueueStatusServer/app.yaml: To update app version.

• QueueStatusServer/handlers/processingtimesjson.py: Added.

• QueueStatusServer/main.py: Added a handler for processing-times-json.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js (added)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js (modified) (3 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html (modified) (2 diffs)
• ChangeLog (modified) (1 diff)
• QueueStatusServer/app.yaml (modified) (1 diff)
• QueueStatusServer/handlers/processingtimesjson.py (added)
• QueueStatusServer/main.py (modified) (3 diffs)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js

@@ -33 +33 @@
     this.queueServer = queueServer;
     this.id = id;
+    this.shortName = info.shortName || id;
     this.title = info.title || "\xa0";
 

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js

@@ -29 +29 @@
         "commit-queue": {platform: Dashboard.Platform.MacOSXMountainLion, shortName: "commit", title: "Commit Queue"},
         "style-queue": {shortName: "style", title: "Style Checker Queue"},
+        "gtk-wk2-ews": {platform: Dashboard.Platform.LinuxGTK, shortName: "gtk-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"},
         "mac-ews": {platform: Dashboard.Platform.MacOSXMountainLion, shortName: "mac", title: "WebKit1\xa0Release\xa0Tests\xa0EWS"},
         "mac-wk2-ews": {platform: Dashboard.Platform.MacOSXMountainLion, shortName: "mac-wk2", title: "WebKit2\xa0Release\xa0Tests\xa0EWS"},
         "win-ews": {platform: Dashboard.Platform.Windows7, shortName: "win", title: "WebKit1\xa0Release\xa0Build\xa0EWS"},
-        "gtk-wk2-ews": {platform: Dashboard.Platform.LinuxGTK, shortName: "gtk-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"},
         "efl-wk2-ews": {platform: Dashboard.Platform.LinuxEFL, shortName: "efl-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"}
     };
@@ -61 +61 @@
     },
 
+    jsonProcessingTimesURL: function(fromTime, toTime)
+    {
+        return this.baseURL + "processing-times-json/" + [fromTime.getUTCFullYear(), fromTime.getUTCMonth() + 1, fromTime.getUTCDate(), fromTime.getUTCHours(), fromTime.getUTCMinutes(), fromTime.getUTCSeconds()].join("-")
+            + "-" + [toTime.getUTCFullYear(), toTime.getUTCMonth() + 1, toTime.getUTCDate(), toTime.getUTCHours(), toTime.getUTCMinutes(), toTime.getUTCSeconds()].join("-");
+    },
+
     queueStatusURL: function(queueID)
     {
         return this.baseURL + "queue-status/" + encodeURIComponent(queueID);
     },
+
+    // Retrieves information about all patches that were submitted in the time range:
+    // {
+    //     patch_id_1: {
+    //         queue_name_1: {
+    //             date: <date/time when the patch was submitted to the queue>,
+    //             retry_count: <number of times a bot had to bail out and drop the lock, for another bot to start from scratch>,
+    //             wait_duration: <how long it took before a bot first locked the patch for processing>,
+    //             process_duration: <how long it took from end of wait to finish, only valid for finished patches. Includes wait time between retries>
+    //             final_message: <(pass|fail|not processed|could not apply|internal error|in progress)>
+    //         },
+    //         ...
+    //     },
+    //     ...
+    // }
+    loadProcessingTimes: function(fromTime, toTime, callback)
+    {
+        JSON.load(this.jsonProcessingTimesURL(fromTime, toTime), function(data) {
+            for (patch in data) {
+                for (queue in patch)
+                    queue.date = new Date(queue.date);
+            }
+            callback(data, fromTime, toTime);
+        }.bind(this));
+    },
 };

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js

@@ -79 +79 @@
 
         webkitTrac.load(this._rangeStartTime, this._rangeEndTime);
+
+        bubbleQueueServer.loadProcessingTimes(this._rangeStartTime, this._rangeEndTime, this._loadedBubblesTiming.bind(this));
     },
 
@@ -381 +383 @@
         if (this._hasTracData)
             this._analyze();
-    }
+    },
+
+    _analyzeBubblePerformance: function(queueID, patches)
+    {
+        var patchesThatCausedInternalError = [];
+        for (patchID in patches) {
+            if (patches[patchID].resolution === "internal error")
+                patchesThatCausedInternalError.push(patchID);
+        }
+
+        var waitTimes = [];
+        var totalTimes = [];
+        var totalTimesForPatchesThatWereNotRetried = [];
+        var totalTimesForPatchesThatSpinnedAndPassedOrFailed = [];
+        var patchesThatDidNotComplete = [];
+        var retryCounts = [];
+        var patchesThatSpinnedAndDidNotComplete = [];
+        var patchesThatSpinnedAndCeasedToApply = [];
+        var patchesThatSpinnedAndPassedOrFailed = [];
+        var patchesDidNotApply = [];
+        for (patchID in patches) {
+            var patch = patches[patchID];
+
+            // Wait time is equally interesting for all patches.
+            waitTimes.push(patch.wait_duration);
+
+            if (patch.resolution === "not processed")
+                patchesThatDidNotComplete.push(patchID);
+
+            if (patch.retry_count === 0)
+                totalTimesForPatchesThatWereNotRetried.push(patch.wait_duration + patch.process_duration);
+            else {
+                retryCounts.push(patch.retry_count);
+                if (patch.resolution === "not processed")
+                    patchesThatSpinnedAndDidNotComplete.push(patchID);
+                else if (patch.resolution === "could not apply")
+                    patchesThatSpinnedAndCeasedToApply.push(patchID);
+                else if (patch.resolution === "pass" || patch.resolution === "fail") {
+                    patchesThatSpinnedAndPassedOrFailed.push(patchID);
+                    totalTimesForPatchesThatSpinnedAndPassedOrFailed.push(patch.wait_duration + patch.process_duration);
+                }
+            }
+
+            // Analyze processing performance for patches that were definitely processed.
+            // We can't target improving performance of others (such as patches that were obsoleted while in the queue).
+            // Patches that don't apply to trunk have to be excluded, because otherwise we
+            // get times for patches that spinned until they ceased to apply.
+            if (patch.resolution === "pass" || patch.resolution === "fail")
+                totalTimes.push(patch.wait_duration + patch.process_duration);
+
+            if (patch.resolution === "could not apply")
+                patchesDidNotApply.push(patchID);
+        }
+
+        var result = {
+            queueID: queueID,
+            totalPatches: Object.keys(patches).length,
+            patchesThatDidNotCompleteCount: patchesThatDidNotComplete.length,
+            patchesWithRetriesCount: retryCounts.length,
+            patchesThatDidNotApplyCount: patchesDidNotApply.length,
+            patchesThatSpinnedAndDidNotCompleteCount: patchesThatSpinnedAndDidNotComplete.length,
+            patchesThatSpinnedAndCeasedToApplyCount: patchesThatSpinnedAndCeasedToApply.length,
+            patchesThatSpinnedAndPassedOrFailedCount: patchesThatSpinnedAndPassedOrFailed.length,
+            medianTotalTimeForPatchesThatSpinnedAndPassedOrFailedInSeconds: totalTimesForPatchesThatSpinnedAndPassedOrFailed.median(),
+            averageTotalTimeForPatchesThatSpinnedAndPassedOrFailedInSeconds: totalTimesForPatchesThatSpinnedAndPassedOrFailed.average(),
+            medianWaitTimeInSeconds: waitTimes.median(),
+            averageWaitTimeInSeconds: waitTimes.average(),
+            patchesThatCausedInternalError: patchesThatCausedInternalError,
+        };
+
+        if (totalTimes.length) {
+            result.medianTotalTimeInSeconds = totalTimes.median();
+            result.averageTotalTimeInSeconds = totalTimes.average();
+        }
+
+        if (totalTimesForPatchesThatWereNotRetried.length) {
+            result.medianTotalTimeForPatchesThatWereNotRetriedInSeconds = totalTimesForPatchesThatWereNotRetried.median();
+            result.averageTotalTimeForPatchesThatWereNotRetriedInSeconds = totalTimesForPatchesThatWereNotRetried.average();
+        }
+
+        this.dispatchEventToListeners(Analyzer.Event.QueueResults, result);
+    },
+
+    _analyzeAllBubblesPerformance: function(dataByPatch)
+    {
+        var data = {};
+        for (queueID in bubbleQueueServer.queues)
+            data[queueID] = {};
+
+        for (patchID in dataByPatch) {
+            for (queueID in dataByPatch[patchID]) {
+                if (!queueID in data)
+                    continue;
+                var patchData = dataByPatch[patchID][queueID];
+                if (patchData.date < this.fromDate || patchData.date > this.toDate)
+                    continue;
+                if (patchData.resolution === "in progress")
+                    continue;
+                data[queueID][patchID] = patchData;
+            };
+        };
+        for (queueID in data)
+            this._analyzeBubblePerformance(queueID, data[queueID]);
+    },
+
+    _loadedBubblesTiming: function(data, fromTime, toTime)
+    {
+        // Only analyze if the data covers the latest range requested by the user.
+        // It may be different from the loaded one if the user quickly requested multiple ranges.
+        if (fromTime > this._rangeStartTime || toTime < this._rangeEndTime)
+            return;
+        this._analyzeAllBubblesPerformance(data);
+    },
 };

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js

@@ -24 +24 @@
  */
 
+var hasBubbles = typeof bubbleQueueServer != "undefined";
+
 var analyzer = new Analyzer;
 
@@ -255 +257 @@
         table.appendChild(row);
     }
+
+    document.body.appendChild(table);
+
+    return table;
+}
+
+function buildBubbleQueuesTable()
+{
+    var table = document.createElement("table");
+    table.classList.add("queue-grid");
+
+    var row = document.createElement("tr");
+    row.classList.add("headers");
+
+    for (id in bubbleQueueServer.queues) {
+        var header = document.createElement("th");
+        header.textContent = bubbleQueueServer.queues[id].shortName;
+        row.appendChild(header);
+    }
+
+    table.appendChild(row);
+
+    row = document.createElement("tr");
+    row.classList.add("platform");
+
+    for (id in bubbleQueueServer.queues) {
+        var cell = document.createElement("td");
+        var view = new MetricsBubbleView(analyzer, bubbleQueueServer.queues[id]);
+        cell.appendChild(view.element);
+        row.appendChild(cell);
+    }
+
+    table.appendChild(row);
 
     document.body.appendChild(table);
@@ -303 +338 @@
 
     buildAggregateTable();
+    if (hasBubbles) {
+        var tablesDivider = document.createElement("div");
+        tablesDivider.classList.add("tables-divider");
+        document.body.appendChild(tablesDivider);
+        buildBubbleQueuesTable();
+    }
 
     var tablesDivider = document.createElement("div");

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html

@@ -37 +37 @@
     <script src="Scripts/Dashboard.js"></script>
     <script src="Scripts/Buildbot.js"></script>
+    <script src="Scripts/BubbleQueueServer.js"></script>
     <script src="Scripts/WebKitBuildbot.js"></script>
     <script src="Scripts/BuildbotQueue.js"></script>
+    <script src="Scripts/BubbleQueue.js"></script>
     <script src="Scripts/BuildbotIteration.js"></script>
     <script src="Scripts/BuildbotTestResults.js"></script>
@@ -46 +48 @@
     <script src="Scripts/MetricsAnalyzer.js"></script>
     <script src="Scripts/MetricsView.js"></script>
+    <script src="Scripts/MetricsBubbleView.js"></script>
     <script src="External/jquery-1.11.1.min.js"></script>
     <script src="External/moment.min.js"></script>

trunk/Tools/ChangeLog

@@ +1 @@
+2014-10-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Dashboard metrics page should have EWS statistics
+        https://bugs.webkit.org/show_bug.cgi?id=137626
+
+        Reviewed by Ryosuke Niwa.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
+        (BubbleQueue): Put shortName in the object, so that it's actually useful.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
+        (BubbleQueueServer): Re-ordered queues to match bubble order.
+        (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
+        (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+        Added analysis for bubble queues.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
+        (buildBubbleQueuesTable): Build the UI.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
+        Added JS sources to load.
+
+        * QueueStatusServer/app.yaml: To update app version.
+
+        * QueueStatusServer/handlers/processingtimesjson.py: Added.
+
+        * QueueStatusServer/main.py: Added a handler for processing-times-json.
+
 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/QueueStatusServer/app.yaml

@@ -1 +1 @@
 application: webkit-queues
-version: 174611 # SVN revision of last major change
+version: 174622 # SVN revision of last major change
 runtime: python
 api_version: 1

trunk/Tools/QueueStatusServer/main.py

@@ -1 +1 @@
 # Copyright (C) 2009 Google Inc. All rights reserved.
+# Copyright (C) 2014 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -39 +40 @@
 from handlers.patch import Patch
 from handlers.patchstatus import PatchStatus
+from handlers.processingtimesjson import ProcessingTimesJSON
 from handlers.queuecharts import QueueCharts
 from handlers.queuelengthjson import QueueLengthJSON
@@ -80 +82 @@
     ('/update-svn-revision', UpdateSVNRevision),
     ('/active-bots', ActiveBots),
+    (r'/processing-times-json/(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)\-(\d+)', ProcessingTimesJSON),
 ]