Changeset 175166 in webkit


Ignore:
Timestamp:
Oct 24, 2014 10:03:53 AM (10 years ago)
Author:
mitz@apple.com
Message:

build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
​https://bugs.webkit.org/show_bug.cgi?id=138046

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was

  1. Otherwise, we’ll retry normally in 45 seconds.
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js

    r173322 r175166  
    137137            }.bind(this),
    138138            function(data) {
     139                if (data.errorType !== JSON.LoadError || data.errorHTTPCode !== 401)
     140                    return;
    139141                if (this.buildbot.isAuthenticated) {
    140142                    // FIXME (128006): Safari/WebKit should coalesce authentication requests with the same origin and authentication realm.
    … …  
    146148                    return;
    147149                }
    148                 if (data.errorType === JSON.LoadError && data.errorHTTPCode === 401) {
    149                     this.buildbot.isAuthenticated = false;
    150                     this.dispatchEventToListeners(BuildbotQueue.Event.UnauthorizedAccess, { });
    151                 }
     150
     151                this.buildbot.isAuthenticated = false;
     152                this.dispatchEventToListeners(BuildbotQueue.Event.UnauthorizedAccess, { });
    152153            }.bind(this),
    153154            {withCredentials: this.buildbot.needsAuthentication}

  • trunk/Tools/ChangeLog

    r175160 r175166  
     12014-10-24  Dan Bernstein  <mitz@apple.com>
     2
     3        build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
     4        https://bugs.webkit.org/show_bug.cgi?id=138046
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
     9        (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
     10        401. Otherwise, we’ll retry normally in 45 seconds.
     11
    1122014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
    213
Note: See TracChangeset for help on using the changeset viewer.