Changeset 177994 in webkit

Timestamp:

Jan 6, 2015 1:58:12 PM (9 years ago)

Author:

mark.lam@apple.com

Message:

Fix Use details for op_create_arguments.
<​https://webkit.org/b/140110>

Rubber stamped by Filip Pizlo.

The previous patch was wrong about op_create_arguments not using its 1st operand.
It does read from it (hence, used) to check if the Arguments object has already
been created or not. This patch reverts the change for op_create_arguments.

• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/BytecodeUseDef.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-01-06  Mark Lam  <mark.lam@apple.com>
+
+        Fix Use details for op_create_arguments.
+        <https://webkit.org/b/140110>
+
+        Rubber stamped by Filip Pizlo.
+
+        The previous patch was wrong about op_create_arguments not using its 1st operand.
+        It does read from it (hence, used) to check if the Arguments object has already
+        been created or not.  This patch reverts the change for op_create_arguments.
+
+        * bytecode/BytecodeUseDef.h:
+        (JSC::computeUsesForBytecodeOffset):
+
 2015-01-06  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/BytecodeUseDef.h

@@ -41 +41 @@
     switch (opcodeID) {
     // No uses.
-    case op_create_arguments:
     case op_new_regexp:
     case op_new_array_buffer:
@@ -58 +57 @@
         return;
     case op_get_scope:
+    case op_create_arguments:
     case op_to_this:
     case op_pop_scope: