Changeset 188627 in webkit

Timestamp:

Aug 18, 2015 9:50:15 PM (9 years ago)

Author:

mitz@apple.com

Message:

[iOS] Safari’s Web Content process crashes when decoding an NSError containing an identity
​https://bugs.webkit.org/show_bug.cgi?id=148135

Reviewed by Sam Weinig.

• Configurations/WebContent-iOS.entitlements: Added the com.apple.identities keychain access group. The Networking process already has it since r169655.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitialize): Always allow the UI process to decode keys.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Configurations/WebContent-iOS.entitlements (modified) (1 diff)
• UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-08-18  Dan Bernstein  <mitz@apple.com>
+
+        [iOS] Safari’s Web Content process crashes when decoding an NSError containing an identity
+        https://bugs.webkit.org/show_bug.cgi?id=148135
+
+        Reviewed by Sam Weinig.
+
+        * Configurations/WebContent-iOS.entitlements: Added the com.apple.identities keychain
+          access group. The Networking process already has it since r169655.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitialize): Always allow the UI process to decode keys.
+
 2015-08-18  Jincheol Jo  <jincheol.jo@navercorp.com>
 

trunk/Source/WebKit2/Configurations/WebContent-iOS.entitlements

@@ -3 +3 @@
 <plist version="1.0">
 <dict>
+        <key>keychain-access-groups</key>
+        <array>
+                <string>com.apple.identities</string>
+        </array>
         <key>com.apple.private.allow-explicit-graphics-priority</key>
         <true/>

trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -54 +54 @@
 
 #if PLATFORM(IOS)
+#import "ArgumentCodersCF.h"
 #import <WebCore/RuntimeApplicationChecksIOS.h>
 #else
@@ -144 +145 @@
 
 #if PLATFORM(IOS)
+    IPC::setAllowsDecodingSecKeyRef(true);
     WebKit::WebMemoryPressureHandler::singleton();
 #endif