Changeset 191140 in webkit


Ignore:
Timestamp:
Oct 15, 2015 2:59:24 PM (9 years ago)
Author:
mitz@apple.com
Message:

[Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
​https://bugs.webkit.org/show_bug.cgi?id=150189

Reviewed by Anders Carlsson.

Source/WebCore:

  • platform/ios/WebCoreSystemInterfaceIOS.mm: Removed definition.
  • platform/mac/WebCoreSystemInterface.h: Removed declaration.
  • platform/mac/WebCoreSystemInterface.mm: Removed definition.
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start): Changed to use -[NSURLConnection setDefersLoading:].
(WebCore::ResourceHandle::platformSetDefersLoading): Ditto.

  • platform/spi/cocoa/NSURLConnectionSPI.h: Added declaration of -[NSURLConnection setDefersLoading:].

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Removed initialization.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Removed initialization.

Location:
trunk/Source
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r191132 r191140  
     12015-10-15  Dan Bernstein  <mitz@apple.com>
     2
     3        [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
     4        https://bugs.webkit.org/show_bug.cgi?id=150189
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * platform/ios/WebCoreSystemInterfaceIOS.mm: Removed definition.
     9        * platform/mac/WebCoreSystemInterface.h: Removed declaration.
     10        * platform/mac/WebCoreSystemInterface.mm: Removed definition.
     11
     12        * platform/network/mac/ResourceHandleMac.mm:
     13        (WebCore::ResourceHandle::start): Changed to use -[NSURLConnection setDefersLoading:].
     14        (WebCore::ResourceHandle::platformSetDefersLoading): Ditto.
     15
     16        * platform/spi/cocoa/NSURLConnectionSPI.h: Added declaration of
     17          -[NSURLConnection setDefersLoading:].
     18
    1192015-10-15  Dean Jackson  <dino@apple.com>
    220

  • trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm

    r186118 r191140  
    3939WEBCORE_EXPORT bool (*wkCGContextIsPDFContext)(CGContextRef);
    4040WEBCORE_EXPORT NSString* (*wkCopyNSURLResponseStatusLine)(NSURLResponse*);
    41 WEBCORE_EXPORT void (*wkSetNSURLConnectionDefersCallbacks)(NSURLConnection *, BOOL);
    4241WEBCORE_EXPORT void (*wkSetNSURLRequestShouldContentSniff)(NSMutableURLRequest *, BOOL);
    4342WEBCORE_EXPORT id (*wkCreateNSURLConnectionDelegateProxy)(void);

  • trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h

    r186821 r191140  
    198198extern void (*wkSetDragImage)(NSImage*, NSPoint offset);
    199199#endif
    200 extern void (*wkSetNSURLConnectionDefersCallbacks)(NSURLConnection *, BOOL);
    201200extern void (*wkSetNSURLRequestShouldContentSniff)(NSMutableURLRequest *, BOOL);
    202201extern void (*wkSetBaseCTM)(CGContextRef, CGAffineTransform);

  • trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm

    r186118 r191140  
    8282CGAffineTransform (*wkGetUserToBaseCTM)(CGContextRef);
    8383bool (*wkCGContextIsPDFContext)(CGContextRef);
    84 void (*wkSetNSURLConnectionDefersCallbacks)(NSURLConnection *, BOOL);
    8584void (*wkSetNSURLRequestShouldContentSniff)(NSMutableURLRequest *, BOOL);
    8685unsigned (*wkInitializeMaximumHTTPConnectionCountPerHost)(unsigned preferredConnectionCount);

  • trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm

    r187609 r191140  
    298298    if (d->m_connection) {
    299299        if (d->m_defersLoading)
    300             wkSetNSURLConnectionDefersCallbacks(connection(), YES);
     300            connection().defersCallbacks = YES;
    301301
    302302        return true;
    … …  
    322322{
    323323    if (d->m_connection)
    324         wkSetNSURLConnectionDefersCallbacks(d->m_connection.get(), defers);
     324        [d->m_connection setDefersCallbacks:defers];
    325325}
    326326

  • trunk/Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h

    r187609 r191140  
    3232@interface NSURLConnection ()
    3333+ (CFRunLoopRef)resourceLoaderRunLoop;
     34- (void)setDefersCallbacks:(BOOL)defers;
    3435@end
    3536

  • trunk/Source/WebKit/mac/ChangeLog

    r191084 r191140  
     12015-10-15  Dan Bernstein  <mitz@apple.com>
     2
     3        [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
     4        https://bugs.webkit.org/show_bug.cgi?id=150189
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * WebCoreSupport/WebSystemInterface.mm:
     9        (InitWebCoreSystemInterface): Removed initialization.
     10
    1112015-10-14  Zhuo Li  <zachli@apple.com>
    212

  • trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm

    r186821 r191140  
    9595    INIT(SetHTTPRequestMinimumFastLanePriority);
    9696    INIT(HTTPRequestEnablePipelining);
    97     INIT(SetNSURLConnectionDefersCallbacks);
    9897    INIT(SetNSURLRequestShouldContentSniff);
    9998    INIT(SetPatternPhaseInUserSpace);

  • trunk/Source/WebKit2/ChangeLog

    r191138 r191140  
     12015-10-15  Dan Bernstein  <mitz@apple.com>
     2
     3        [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
     4        https://bugs.webkit.org/show_bug.cgi?id=150189
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
     9        (InitWebCoreSystemInterface): Removed initialization.
     10
    1112015-10-15  Anders Carlsson  <andersca@apple.com>
    212

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm

    r186821 r191140  
    101101        INIT(SetHTTPRequestPriority);
    102102        INIT(SetHTTPRequestMinimumFastLanePriority);
    103         INIT(SetNSURLConnectionDefersCallbacks);
    104103        INIT(SetNSURLRequestShouldContentSniff);
    105104        INIT(SetPatternPhaseInUserSpace);
Note: See TracChangeset for help on using the changeset viewer.