Changeset 221868 in webkit
- Timestamp:
- Sep 11, 2017 11:43:13 AM (7 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r221865 r221868 1 2017-09-11 Mark Lam <mark.lam@apple.com> 2 3 Turn on exception scope verification for JSC tests. 4 https://bugs.webkit.org/show_bug.cgi?id=162351 5 <rdar://problem/29563911> 6 7 Reviewed by Saam Barati. 8 9 Added the option to --validateExceptionChecks=true option to BASE_OPTIONS in 10 run-jsc-stress-tests. This turns on exception scope verification on JSC test 11 runs (which currently does not include testapi). 12 13 Some stats on time to run JSC stress and mozilla tests: 14 1. Release build w/o --validateExceptionChecks=true: real 16m22.544s, user 156m24.080s, sys 123m3.649s 15 2. Debug build w/o --validateExceptionChecks=true: real 78m34.206s, user 1661m57.008s, sys 73m21.177s 16 3. Debug build w/ --validateExceptionChecks=true: real 77m41.106s, user 1656m13.924s, sys 73m42.309s 17 4. Debug build w/ --validateExceptionChecks=true --dumpSimulatedThrows=true: real 92m56.918s, user 2012m56.441s, sys 75m14.174s 18 19 The stats shows that (2) and (3) has effectively no time difference. Hence, the 20 cost of enabling --validateExceptionChecks=true is not significant. 21 22 It would be nice to enable --dumpSimulatedThrows=true as well, but (4) is about 23 21% slower than (3). To avoid making debug test runs a lot slower, we'll leave 24 --dumpSimulatedThrows=true off. We can manually add that when we see a regression 25 and need to debug the issue. Otherwise, we wont pay the price for it. 26 27 * Scripts/run-jsc-stress-tests: 28 1 29 2017-09-11 Myles C. Maxfield <mmaxfield@apple.com> 2 30 -
trunk/Tools/Scripts/run-jsc-stress-tests
r221622 r221868 445 445 446 446 # We force all tests to use a smaller (1.5M) stack so that stack overflow tests can run faster. 447 BASE_OPTIONS = ["--useFTLJIT=false", "--useFunctionDotArguments=true", "-- maxPerThreadStackUsage=1572864"]447 BASE_OPTIONS = ["--useFTLJIT=false", "--useFunctionDotArguments=true", "--validateExceptionChecks=true", "--maxPerThreadStackUsage=1572864"] 448 448 EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20", "--maximumEvalCacheableSourceLength=150000", "--useEagerCodeBlockJettisonTiming=true"] 449 449 # NOTE: Tests rely on this using scribbleFreeCells.
Note: See TracChangeset
for help on using the changeset viewer.