Changeset 222672 in webkit

Timestamp:

Sep 29, 2017 5:29:19 PM (7 years ago)

Author:

achristensen@apple.com

Message:

Expose WebPreferences::webGLEnabled through WKPreferences
​https://bugs.webkit.org/show_bug.cgi?id=177692
<rdar://problem/24110556>

Reviewed by Andy Estes.

Source/WebKit:

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setWebGLEnabled:]):
(-[WKPreferences _webGLEnabled]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm:

(-[AlertSaver alert]):
(-[AlertSaver webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (modified) (2 diffs)
• Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-09-29  Alex Christensen  <achristensen@webkit.org>
+
+        Expose WebPreferences::webGLEnabled through WKPreferences
+        https://bugs.webkit.org/show_bug.cgi?id=177692
+        <rdar://problem/24110556>
+
+        Reviewed by Andy Estes.
+
+        * UIProcess/API/Cocoa/WKPreferences.mm:
+        (-[WKPreferences _setWebGLEnabled:]):
+        (-[WKPreferences _webGLEnabled]):
+        * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
 2017-09-29  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm

@@ -648 +648 @@
 }
 
+#if PLATFORM(MAC)
 - (void)_setPlugInsEnabled:(BOOL)enabled
 {
@@ -658 +659 @@
 }
 
+- (void)_setWebGLEnabled:(BOOL)enabled
+{
+    _preferences->setWebGLEnabled(enabled);
+}
+
+- (BOOL)_webGLEnabled
+{
+    return _preferences->webGLEnabled();
+}
+#endif // PLATFORM(MAC)
+
 - (BOOL)_javaScriptCanAccessClipboard
 {

trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h

@@ -121 +121 @@
 #if !TARGET_OS_IPHONE
 @property (nonatomic, setter=_setPlugInsEnabled:) BOOL _plugInsEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
+@property (nonatomic, setter=_setWebGLEnabled:) BOOL _webGLEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 #endif
 

trunk/Tools/ChangeLog

@@ +1 @@
+2017-09-29  Alex Christensen  <achristensen@webkit.org>
+
+        Expose WebPreferences::webGLEnabled through WKPreferences
+        https://bugs.webkit.org/show_bug.cgi?id=177692
+        <rdar://problem/24110556>
+
+        Reviewed by Andy Estes.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm:
+        (-[AlertSaver alert]):
+        (-[AlertSaver webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
+        (TEST):
+
 2017-09-29  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm

@@ -29 +29 @@
 
 #import "Test.h"
+#import "Utilities.h"
 #import <WebKit/WKFoundation.h>
 #import <WebKit/WKPreferencesPrivate.h>
+#import <WebKit/WKUIDelegate.h>
 #import <WebKit/_WKExperimentalFeature.h>
 #import <wtf/RetainPtr.h>
@@ -67 +69 @@
 }
 
-#endif
+#if PLATFORM(MAC)
+
+static bool receivedAlert;
+
+@interface AlertSaver : NSObject <WKUIDelegate>
+@end
+
+@implementation AlertSaver {
+    RetainPtr<NSString> alert;
+}
+
+- (NSString *)alert
+{
+    return alert.get();
+}
+
+- (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(void))completionHandler
+{
+    alert = message;
+    completionHandler();
+    receivedAlert = true;
+}
+
+@end
+
+TEST(WebKit, WebGLEnabled)
+{
+    NSString *html = @"<script>if(document.createElement('canvas').getContext('webgl')){alert('enabled')}else{alert('disabled')}</script>";
+    auto delegate = adoptNS([[AlertSaver alloc] init]);
+
+    auto webView = adoptNS([[WKWebView alloc] init]);
+    [webView setUIDelegate:delegate.get()];
+    [webView loadHTMLString:html baseURL:nil];
+    TestWebKitAPI::Util::run(&receivedAlert);
+    EXPECT_STREQ([delegate alert].UTF8String, "enabled");
+
+    receivedAlert = false;
+    auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
+    [[configuration preferences] _setWebGLEnabled:NO];
+    webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
+    [webView setUIDelegate:delegate.get()];
+    [webView loadHTMLString:html baseURL:nil];
+    TestWebKitAPI::Util::run(&receivedAlert);
+    EXPECT_STREQ([delegate alert].UTF8String, "disabled");
+}
+
+#endif // PLATFORM(MAC)
+
+#endif // WK_API_ENABLED