Changeset 223934 in webkit

Timestamp:

Oct 24, 2017 3:23:12 PM (7 years ago)

Author:

achristensen@apple.com

Message:

Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
​https://bugs.webkit.org/show_bug.cgi?id=174267

Reviewed by Tim Horton.

Source/WebKit:

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCanHandleRequest):

Tools:

• TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:

(TestWebKitAPI::runTest):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-10-24  Alex Christensen  <achristensen@webkit.org>
+
+        Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
+        https://bugs.webkit.org/show_bug.cgi?id=174267
+
+        Reviewed by Tim Horton.
+
+        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+        (WKBundlePageCanHandleRequest):
+
 2017-10-24  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp

@@ -423 +423 @@
 bool WKBundlePageCanHandleRequest(WKURLRequestRef requestRef)
 {
+    if (!requestRef)
+        return false;
     return WebPage::canHandleRequest(toImpl(requestRef)->resourceRequest());
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-24  Alex Christensen  <achristensen@webkit.org>
+
+        Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
+        https://bugs.webkit.org/show_bug.cgi?id=174267
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:
+        (TestWebKitAPI::runTest):
+
 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp

@@ -57 +57 @@
 static bool runTest()
 {
-    return canHandleURL("about:blank") && canHandleURL("emptyscheme://") && !canHandleURL("notascheme://");
+    return !WKBundlePageCanHandleRequest(nullptr) && canHandleURL("about:blank") && canHandleURL("emptyscheme://") && !canHandleURL("notascheme://");
 }