Changeset 224281 in webkit


Ignore:
Timestamp:
Nov 1, 2017 10:36:56 AM (6 years ago)
Author:
achristensen@apple.com
Message:

Add a test for _WKInputDelegate.willSubmitFormValues
https://bugs.webkit.org/show_bug.cgi?id=179086

Reviewed by Darin Adler.

Hidden input types are not included in this submission because FormSubmission::create ignores them
because input.isTextField() returns false. This is existing behavior that wasn't shown by a test.
HTTPBodies are also not sent to WKURLSchemeHandlers. This is existing behavior that wasn't shown by a test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm: Added.

(-[FormSubmissionDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
(TEST):

Location:
trunk/Tools
Files:
1 added
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r224268 r224281  
     12017-11-01  Alex Christensen  <achristensen@webkit.org>
     2
     3        Add a test for _WKInputDelegate.willSubmitFormValues
     4        https://bugs.webkit.org/show_bug.cgi?id=179086
     5
     6        Reviewed by Darin Adler.
     7
     8        Hidden input types are not included in this submission because FormSubmission::create ignores them
     9        because input.isTextField() returns false.  This is existing behavior that wasn't shown by a test.
     10        HTTPBodies are also not sent to WKURLSchemeHandlers.  This is existing behavior that wasn't shown by a test.
     11
     12        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
     13        * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm: Added.
     14        (-[FormSubmissionDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
     15        (TEST):
     16
    1172017-10-31  Ross Kirsling  <ross.kirsling@sony.com>
    218
  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r224238 r224281  
    249249                5CB40B4E1F4B98D3007DC7B9 /* UIDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CB40B4D1F4B98BE007DC7B9 /* UIDelegate.mm */; };
    250250                5CE354D91E70DA5C00BEFE3B /* WKContentExtensionStore.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CE354D81E70D9C300BEFE3B /* WKContentExtensionStore.mm */; };
     251                5CEAB5E11FA939F400A77FAA /* _WKInputDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CEAB5DF1FA937CB00A77FAA /* _WKInputDelegate.mm */; };
    251252                5E4B1D2E1D404C6100053621 /* WKScrollViewDelegateCrash.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5E4B1D2C1D404C6100053621 /* WKScrollViewDelegateCrash.mm */; };
    252253                631EFFF61E7B5E8D00D2EBB8 /* Geolocation.mm in Sources */ = {isa = PBXBuildFile; fileRef = 631EFFF51E7B5E8D00D2EBB8 /* Geolocation.mm */; };
     
    13811382                5CB40B4D1F4B98BE007DC7B9 /* UIDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = UIDelegate.mm; sourceTree = "<group>"; };
    13821383                5CE354D81E70D9C300BEFE3B /* WKContentExtensionStore.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKContentExtensionStore.mm; sourceTree = "<group>"; };
     1384                5CEAB5DF1FA937CB00A77FAA /* _WKInputDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = _WKInputDelegate.mm; sourceTree = "<group>"; };
    13831385                5E4B1D2C1D404C6100053621 /* WKScrollViewDelegateCrash.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = WKScrollViewDelegateCrash.mm; path = ../ios/WKScrollViewDelegateCrash.mm; sourceTree = "<group>"; };
    13841386                631EFFF51E7B5E8D00D2EBB8 /* Geolocation.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = Geolocation.mm; sourceTree = "<group>"; };
     
    19751977                        children = (
    19761978                                A16F66B81C40E9E100BD4D24 /* Resources */,
     1979                                5CEAB5DF1FA937CB00A77FAA /* _WKInputDelegate.mm */,
    19771980                                7CEFA9641AC0B9E200B910FD /* _WKUserContentExtensionStore.mm */,
    19781981                                37E7DD631EA06FF2009B396D /* AdditionalReadAccessAllowedURLs.mm */,
     
    32123215                        buildActionMask = 2147483647;
    32133216                        files = (
     3217                                5CEAB5E11FA939F400A77FAA /* _WKInputDelegate.mm in Sources */,
    32143218                                7CEFA9661AC0B9E200B910FD /* _WKUserContentExtensionStore.mm in Sources */,
    32153219                                7CCE7EE41A411AE600447C4C /* AboutBlankLoad.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.