Changeset 225700 in webkit

Timestamp:

Dec 8, 2017 2:23:22 PM (6 years ago)

Author:

achristensen@apple.com

Message:

Remove unused code in WebPageGroup
​https://bugs.webkit.org/show_bug.cgi?id=180604

Reviewed by Youenn Fablet.

• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::userContentController):
(WebKit::WebPageGroup::createNonNull): Deleted.
(WebKit::WebPageGroup::preferencesDidChange): Deleted.

• UIProcess/WebPageGroup.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageGroup.cpp (modified) (2 diffs)
• UIProcess/WebPageGroup.h (modified) (4 diffs)
• UIProcess/WebProcessPool.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-12-08  Alex Christensen  <achristensen@webkit.org>
+
+        Remove unused code in WebPageGroup
+        https://bugs.webkit.org/show_bug.cgi?id=180604
+
+        Reviewed by Youenn Fablet.
+
+        * UIProcess/WebPageGroup.cpp:
+        (WebKit::WebPageGroup::userContentController):
+        (WebKit::WebPageGroup::createNonNull): Deleted.
+        (WebKit::WebPageGroup::preferencesDidChange): Deleted.
+        * UIProcess/WebPageGroup.h:
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::WebProcessPool):
+
 2017-12-08  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/WebPageGroup.cpp

@@ -56 +56 @@
 
 Ref<WebPageGroup> WebPageGroup::create(const String& identifier, bool visibleToInjectedBundle, bool visibleToHistoryClient)
-{
-    return adoptRef(*new WebPageGroup(identifier, visibleToInjectedBundle, visibleToHistoryClient));
-}
-
-Ref<WebPageGroup> WebPageGroup::createNonNull(const String& identifier, bool visibleToInjectedBundle, bool visibleToHistoryClient)
 {
     return adoptRef(*new WebPageGroup(identifier, visibleToInjectedBundle, visibleToHistoryClient));
@@ -130 +125 @@
 }
 
-void WebPageGroup::preferencesDidChange()
-{
-    for (HashSet<WebPageProxy*>::iterator it = m_pages.begin(), end = m_pages.end(); it != end; ++it) {
-        WebPageProxy* page = *it;
-        page->preferencesDidChange();
-    }
-}
-
 WebUserContentControllerProxy& WebPageGroup::userContentController()
 {
-    return *m_userContentController;
+    return m_userContentController;
 }
 

trunk/Source/WebKit/UIProcess/WebPageGroup.h

@@ -24 +24 @@
  */
 
-#ifndef WebPageGroup_h
-#define WebPageGroup_h
+#pragma once
 
 #include "APIObject.h"
@@ -45 +44 @@
     WebPageGroup(const String& identifier = String(), bool visibleToInjectedBundle = true, bool visibleToHistoryClient = true);
     static Ref<WebPageGroup> create(const String& identifier = String(), bool visibleToInjectedBundle = true, bool visibleToHistoryClient = true);
-    static Ref<WebPageGroup> createNonNull(const String& identifier = String(), bool visibleToInjectedBundle = true, bool visibleToHistoryClient = true);
+
     static WebPageGroup* get(uint64_t pageGroupID);
 
@@ -59 +58 @@
     void setPreferences(WebPreferences*);
     WebPreferences& preferences() const;
-    void preferencesDidChange();
 
     WebUserContentControllerProxy& userContentController();
@@ -66 +64 @@
     WebPageGroupData m_data;
     RefPtr<WebPreferences> m_preferences;
-    RefPtr<WebUserContentControllerProxy> m_userContentController;
+    Ref<WebUserContentControllerProxy> m_userContentController;
     HashSet<WebPageProxy*> m_pages;
 };
 
 } // namespace WebKit
-
-#endif // WebPageGroup_h

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -217 +217 @@
 WebProcessPool::WebProcessPool(API::ProcessPoolConfiguration& configuration)
     : m_configuration(configuration.copy())
-    , m_defaultPageGroup(WebPageGroup::createNonNull())
+    , m_defaultPageGroup(WebPageGroup::create())
     , m_injectedBundleClient(std::make_unique<API::InjectedBundleClient>())
     , m_automationClient(std::make_unique<API::AutomationClient>())