Changeset 234960 in webkit

Timestamp:

Aug 16, 2018 3:10:20 PM (6 years ago)

Author:

achristensen@apple.com

Message:

Add temporary SPI WKContextHandlesSafeBrowsing
​https://bugs.webkit.org/show_bug.cgi?id=188676

Reviewed by Joseph Pecoraro.

WebKit showing the safe browsing warning doesn't play well with Safari showing the safe browsing warning.
I plan to adopt this SPI in Safari to disable Safari's safe browsing check if it's true.
Then when I implement safe browsing in WebKit, I can switch this value to true in the same change and
not have a broken Safari.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextHandlesSafeBrowsing):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/C/mac/WKContextPrivateMac.h (modified) (1 diff)
• UIProcess/API/C/mac/WKContextPrivateMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-08-16  Alex Christensen  <achristensen@webkit.org>
+
+        Add temporary SPI WKContextHandlesSafeBrowsing
+        https://bugs.webkit.org/show_bug.cgi?id=188676
+
+        Reviewed by Joseph Pecoraro.
+
+        WebKit showing the safe browsing warning doesn't play well with Safari showing the safe browsing warning.
+        I plan to adopt this SPI in Safari to disable Safari's safe browsing check if it's true.
+        Then when I implement safe browsing in WebKit, I can switch this value to true in the same change and
+        not have a broken Safari.
+
+        * UIProcess/API/C/mac/WKContextPrivateMac.h:
+        * UIProcess/API/C/mac/WKContextPrivateMac.mm:
+        (WKContextHandlesSafeBrowsing):
+
 2018-08-16  Ben Richards  <benton_richards@apple.com>
 

trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h

@@ -75 +75 @@
 WK_EXPORT bool WKContextShouldSuggestBlockWebGL();
 
+WK_EXPORT bool WKContextHandlesSafeBrowsing();
+
 #ifdef __cplusplus
 }

trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm

@@ -173 +173 @@
 #endif
 }
+
+bool WKContextHandlesSafeBrowsing()
+{
+    return false;
+}