Changeset 236524 in webkit


Ignore:
Timestamp:
Sep 26, 2018 2:52:21 PM (6 years ago)
Author:
achristensen@apple.com
Message:

URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
https://bugs.webkit.org/show_bug.cgi?id=189979
<rdar://problem/44119696>

Reviewed by Chris Dumez.

Source/WebCore:

Covered by an API test.

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::URLWithData):

Tools:

  • TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:

(TestWebKitAPI::TEST):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r236522 r236524  
     12018-09-26  Alex Christensen  <achristensen@webkit.org>
     2
     3        URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
     4        https://bugs.webkit.org/show_bug.cgi?id=189979
     5        <rdar://problem/44119696>
     6
     7        Reviewed by Chris Dumez.
     8
     9        Covered by an API test.
     10
     11        * platform/mac/WebCoreNSURLExtras.mm:
     12        (WebCore::URLWithData):
     13
    1142018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
    215
  • trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm

    r235585 r236524  
    854854        result = [NSURL URLWithString:@""];
    855855
     856    if (!WebCore::URL(result).isValid())
     857        return nil;
     858   
    856859    return result;
    857860}
  • trunk/Tools/ChangeLog

    r236519 r236524  
     12018-09-26  Alex Christensen  <achristensen@webkit.org>
     2
     3        URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
     4        https://bugs.webkit.org/show_bug.cgi?id=189979
     5        <rdar://problem/44119696>
     6
     7        Reviewed by Chris Dumez.
     8
     9        * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
     10        (TestWebKitAPI::TEST):
     11
    1122018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
    213
  • trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm

    r230533 r236524  
    193193    NSString *encodedHostName = WebCore::encodeHostName(@"http://.com");
    194194    EXPECT_TRUE(encodedHostName == nil);
     195   
     196    EXPECT_TRUE(WebCore::URLWithUserTypedString(@"https://a@/b", nil) == nil);
    195197}
    196198
Note: See TracChangeset for help on using the changeset viewer.