Changeset 239738 in webkit

Timestamp:

Jan 8, 2019, 1:05:24 PM (7 years ago)

Author:

achristensen@apple.com

Message:

Call CompletionHandler when destroying a NetworkCache::Storage::WriteOperation
​https://bugs.webkit.org/show_bug.cgi?id=193251

Reviewed by Chris Dumez.

This fixes another assertion introduced in r239710.

• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::WriteOperation::~WriteOperation):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/NetworkCacheStorage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-08  Alex Christensen  <achristensen@webkit.org>
+
+        Call CompletionHandler when destroying a NetworkCache::Storage::WriteOperation
+        https://bugs.webkit.org/show_bug.cgi?id=193251
+
+        Reviewed by Chris Dumez.
+
+        This fixes another assertion introduced in r239710.
+
+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
+        (WebKit::NetworkCache::Storage::WriteOperation::~WriteOperation):
+
 2019-01-08  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp

@@ -113 +113 @@
         , completionHandler(WTFMove(completionHandler))
     { }
+
+    ~WriteOperation()
+    {
+        if (completionHandler)
+            completionHandler(0);
+    }
+
     Ref<Storage> storage;