Changeset 241127 in webkit


Ignore:
Timestamp:
Feb 7, 2019 10:52:54 AM (5 years ago)
Author:
achristensen@apple.com
Message:

Deprecate WKBundlePageSetDefersLoading
​https://bugs.webkit.org/show_bug.cgi?id=191394

Reviewed by Dean Jackson.

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetDefersLoading):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _defersLoading]):
(-[WKWebProcessPlugInBrowserContextController _setDefersLoading:]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:

Tools:

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDefersLoading):

LayoutTests:

  • platform/wk2/TestExpectations:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r241123 r241127  
     12019-02-07  Alex Christensen  <achristensen@webkit.org>
     2
     3        Deprecate WKBundlePageSetDefersLoading
     4        https://bugs.webkit.org/show_bug.cgi?id=191394
     5
     6        Reviewed by Dean Jackson.
     7
     8        * platform/wk2/TestExpectations:
     9
    1102019-02-07  Zalan Bujtas  <zalan@apple.com>
    211

  • trunk/LayoutTests/platform/wk2/TestExpectations

    r240046 r241127  
    535535platform/mac/fast/AppleScript/array.html
    536536platform/mac/fast/AppleScript/date.html
     537
     538# setDefersLoading is not supported in WK2.
     539loader/load-defer.html [ WontFix ]
    537540
    538541# WebKitTestRunner doesn't have objCController

  • trunk/Source/WebKit/ChangeLog

    r241125 r241127  
     12019-02-07  Alex Christensen  <achristensen@webkit.org>
     2
     3        Deprecate WKBundlePageSetDefersLoading
     4        https://bugs.webkit.org/show_bug.cgi?id=191394
     5
     6        Reviewed by Dean Jackson.
     7
     8        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
     9        (WKBundlePageSetDefersLoading):
     10        * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
     11        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
     12        (-[WKWebProcessPlugInBrowserContextController _defersLoading]):
     13        (-[WKWebProcessPlugInBrowserContextController _setDefersLoading:]):
     14        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
     15
    1162019-02-07  Alex Christensen  <achristensen@webkit.org>
    217

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp

    r239851 r241127  
    304304}
    305305
    306 void WKBundlePageSetDefersLoading(WKBundlePageRef pageRef, bool defersLoading)
    307 {
    308     WebKit::toImpl(pageRef)->setDefersLoading(defersLoading);
     306void WKBundlePageSetDefersLoading(WKBundlePageRef, bool)
     307{
    309308}
    310309

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h

    r239851 r241127  
    2828
    2929#include <WebKit/WKBase.h>
     30#include <WebKit/WKDeprecated.h>
    3031#include <WebKit/WKEvent.h>
    3132#include <WebKit/WKGeometry.h>
    … …  
    3839
    3940WK_EXPORT void WKBundlePageStopLoading(WKBundlePageRef page);
    40 WK_EXPORT void WKBundlePageSetDefersLoading(WKBundlePageRef page, bool defersLoading);
     41WK_EXPORT void WKBundlePageSetDefersLoading(WKBundlePageRef page, bool defersLoading) WK_C_API_DEPRECATED;
    4142WK_EXPORT bool WKBundlePageIsEditingCommandEnabled(WKBundlePageRef page, WKStringRef commandName);
    4243WK_EXPORT void WKBundlePageClearMainFrameName(WKBundlePageRef page);

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm

    r241026 r241127  
    694694- (BOOL)_defersLoading
    695695{
    696     return _page->defersLoading();
     696    return NO;
    697697}
    698698
    699699- (void)_setDefersLoading:(BOOL)defersLoading
    700700{
    701     _page->setDefersLoading(defersLoading);
    702701}
    703702

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h

    r221930 r241127  
    4646@property (weak, setter=_setEditingDelegate:) id <WKWebProcessPlugInEditingDelegate> _editingDelegate WK_API_AVAILABLE(macosx(10.12.3), ios(10.3));
    4747
    48 @property (nonatomic, setter=_setDefersLoading:) BOOL _defersLoading;
     48@property (nonatomic, setter=_setDefersLoading:) BOOL _defersLoading WK_API_DEPRECATED("No longer supported");
    4949
    5050@property (nonatomic, readonly) BOOL _usesNonPersistentWebsiteDataStore;

  • trunk/Tools/ChangeLog

    r241123 r241127  
     12019-02-07  Alex Christensen  <achristensen@webkit.org>
     2
     3        Deprecate WKBundlePageSetDefersLoading
     4        https://bugs.webkit.org/show_bug.cgi?id=191394
     5
     6        Reviewed by Dean Jackson.
     7
     8        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
     9        (WTR::TestRunner::setDefersLoading):
     10
    1112019-02-07  Zalan Bujtas  <zalan@apple.com>
    212

  • trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp

    r240928 r241127  
    742742}
    743743
    744 void TestRunner::setDefersLoading(bool shouldDeferLoading)
    745 {
    746     WKBundlePageSetDefersLoading(InjectedBundle::singleton().page()->page(), shouldDeferLoading);
     744void TestRunner::setDefersLoading(bool)
     745{
    747746}
    748747
Note: See TracChangeset for help on using the changeset viewer.