Changeset 241235 in webkit

Timestamp:

Feb 8, 2019 11:04:47 PM (5 years ago)

Author:

achristensen@apple.com

Message:

Speculative fix for Mojave API test after r241223
​https://bugs.webkit.org/show_bug.cgi?id=194427

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCInitializationHandler):
(WebKit::XPCServiceMain):
Set the APPLEEVENTSSERVICENAME environment variable before handling any xpc messages like we used to.
I'll worry about making things right in the daemon later.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-02-08  Alex Christensen  <achristensen@webkit.org>
+
+        Speculative fix for Mojave API test after r241223
+        https://bugs.webkit.org/show_bug.cgi?id=194427
+
+        * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
+        (WebKit::XPCInitializationHandler):
+        (WebKit::XPCServiceMain):
+        Set the __APPLEEVENTSSERVICENAME environment variable before handling any xpc messages like we used to.
+        I'll worry about making things right in the daemon later.
+
 2019-02-08  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm

@@ -109 +109 @@
     static std::once_flag once;
     std::call_once(once, [event] {
-#if PLATFORM(MAC)
-        // Don't allow Apple Events in WebKit processes. This can be removed when <rdar://problem/14012823> is fixed.
-        setenv("__APPLEEVENTSSERVICENAME", "", 1);
-
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
-        // We don't need to talk to the dock.
-        if (Class nsApplicationClass = NSClassFromString(@"NSApplication")) {
-            if ([nsApplicationClass respondsToSelector:@selector(_preventDockConnections)])
-                [nsApplicationClass _preventDockConnections];
-        }
-#endif
-#endif
-
 #if defined(__i386__)
         // FIXME: This should only be done for the 32-bit plug-in XPC service so we rely on the fact that
@@ -170 +157 @@
 int XPCServiceMain(int, const char**)
 {
+#if PLATFORM(MAC)
+    // Don't allow Apple Events in WebKit processes. This can be removed when <rdar://problem/14012823> is fixed.
+    setenv("__APPLEEVENTSSERVICENAME", "", 1);
+    
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+    // We don't need to talk to the dock.
+    if (Class nsApplicationClass = NSClassFromString(@"NSApplication")) {
+        if ([nsApplicationClass respondsToSelector:@selector(_preventDockConnections)])
+            [nsApplicationClass _preventDockConnections];
+    }
+#endif
+#endif
+
     xpc_main([] (xpc_connection_t peer) {
         XPCEventHandler(peer, AuxiliaryProcessType::XPCService);