Changeset 241736 in webkit

Timestamp:

Feb 18, 2019 1:34:26 PM (5 years ago)

Author:

achristensen@apple.com

Message:

Fix API test after r241728

​​https://bugs.webkit.org/show_bug.cgi?id=194723

• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):
The test should check the default preference value, not make sure the preference is NO after setting it to YES :/

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Fix API test after r241728
+       ​https://bugs.webkit.org/show_bug.cgi?id=194723
+
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (TEST):
+        The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
+
 2019-02-18  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm

@@ -171 +171 @@
 
     auto webView = adoptNS([WKWebView new]);
+    EXPECT_FALSE([webView configuration].preferences._safeBrowsingEnabled);
     [webView configuration].preferences._safeBrowsingEnabled = YES;
     [webView setNavigationDelegate:delegate.get()];
-    EXPECT_FALSE([webView configuration].preferences._safeBrowsingEnabled);
     [webView configuration].preferences._safeBrowsingEnabled = YES;
     [webView loadRequest:[NSURLRequest requestWithURL:resourceURL(@"simple")]];