Changeset 241777 in webkit
- Timestamp:
- Feb 19, 2019 2:49:13 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r241760 r241777 1 2019-02-19 Alex Christensen <achristensen@webkit.org> 2 3 Remove assertion introduced in r229683 4 https://bugs.webkit.org/show_bug.cgi?id=194825 5 <rdar://problem/47628258> 6 7 Reviewed by Geoffrey Garen. 8 9 * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: 10 (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm): 11 If we reach this code and the form's original Document's Frame has been destroyed, 12 we have already been told to submit the form so do so, just like we do if the WebPage 13 has been destroyed. This is a rare edge case having to do with the timing of Frame 14 destruction and decidePolicyForNavigationAction response, which unfortunately does not 15 reproduce with a test case unless the timing of IPC is just right. 16 1 17 2019-02-19 Antoine Quint <graouts@apple.com> 2 18 -
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
r241451 r241777 974 974 975 975 auto* sourceCoreFrame = formState.sourceDocument().frame(); 976 RELEASE_ASSERT(sourceCoreFrame); 976 if (!sourceCoreFrame) 977 return completionHandler(); 977 978 auto* sourceFrame = WebFrame::fromCoreFrame(*sourceCoreFrame); 978 ASSERT(sourceFrame); 979 if (!sourceFrame) 980 return completionHandler(); 979 981 980 982 auto& values = formState.textFieldValues();
Note: See TracChangeset
for help on using the changeset viewer.