Changeset 258610 in webkit

Timestamp:

Mar 17, 2020 4:32:57 PM (4 years ago)

Author:

achristensen@apple.com

Message:

Fix API tests after r258574
​https://bugs.webkit.org/show_bug.cgi?id=209192

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::printFrame):
I forgot to call the CompletionHandler from the IPC call.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-03-17  Alex Christensen  <achristensen@webkit.org>
+
+        Fix API tests after r258574
+        https://bugs.webkit.org/show_bug.cgi?id=209192
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::printFrame):
+        I forgot to call the CompletionHandler from the IPC call.
+
 2020-03-17  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -5818 +5818 @@
     MESSAGE_CHECK(m_process, frame);
 
-    m_uiClient->printFrame(*this, *frame, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] {
+    m_uiClient->printFrame(*this, *frame, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] () mutable {
         endPrinting(); // Send a message synchronously while m_isPerformingDOMPrintOperation is still true.
         m_isPerformingDOMPrintOperation = false;
+        completionHandler();
     });
 }