Changeset 275003 in webkit

Timestamp:

Mar 24, 2021 7:53:03 PM (3 years ago)

Author:

mark.lam@apple.com

Message:

WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaround unconditionally.
​https://bugs.webkit.org/show_bug.cgi?id=223725
rdar://75813316

Reviewed by Saam Barati.

If the OS does not support the flag, then we should not require it.

• wtf/WTFConfig.cpp:

(WTF::setPermissionsOfConfigPage):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/WTFConfig.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-03-24  Mark Lam  <mark.lam@apple.com>
+
+        WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaround unconditionally.
+        https://bugs.webkit.org/show_bug.cgi?id=223725
+        rdar://75813316
+
+        Reviewed by Saam Barati.
+
+        If the OS does not support the flag, then we should not require it.
+
+        * wtf/WTFConfig.cpp:
+        (WTF::setPermissionsOfConfigPage):
+
 2021-03-24  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/WTF/wtf/WTFConfig.cpp

@@ -1 +1 @@
 /*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -78 +78 @@
         auto result = attemptVMMapping();
 
-#if HAVE(VM_FLAGS_PERMANENT) && PLATFORM(IOS_FAMILY_SIMULATOR)
-        // FIXME: Remove this when the oldest OS we support simulator on has VM_FLAGS_PERMANENT
+#if HAVE(VM_FLAGS_PERMANENT)
         if (result != KERN_SUCCESS) {
             flags &= ~VM_FLAGS_PERMANENT;