Changeset 276612 in webkit

Timestamp:

Apr 26, 2021 2:03:49 PM (3 years ago)

Author:

mark.lam@apple.com

Message:

%TypedArray%.prototype.sort() should not use a regular array as a temp buffer.
​https://bugs.webkit.org/show_bug.cgi?id=225062
rdar://77021547

Reviewed by Yusuke Suzuki.

JSTests:

• stress/typedarray-sort-should-not-use-a-regular-array-as-temp-buffer.js: Added.

Source/JavaScriptCore:

%TypedArray%.prototype.sort() should not be affected by property changes in
Array.prototype.

References:
[1] ​https://tc39.es/ecma262/#sec-%typedarray%.prototype.sort
[2] ​https://tc39.es/ecma262/#sec-array.prototype.sort
[3] ​https://tc39.es/ecma262/#sec-sortcompare

• builtins/TypedArrayPrototype.js:

(globalPrivate.typedArrayMergeSort):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/typedarray-sort-should-not-use-a-regular-array-as-temp-buffer.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/builtins/TypedArrayPrototype.js (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-04-26  Mark Lam  <mark.lam@apple.com>
+
+        %TypedArray%.prototype.sort() should not use a regular array as a temp buffer.
+        https://bugs.webkit.org/show_bug.cgi?id=225062
+        rdar://77021547
+
+        Reviewed by Yusuke Suzuki.
+
+        * stress/typedarray-sort-should-not-use-a-regular-array-as-temp-buffer.js: Added.
+
 2021-04-26  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-04-26  Mark Lam  <mark.lam@apple.com>
+
+        %TypedArray%.prototype.sort() should not use a regular array as a temp buffer.
+        https://bugs.webkit.org/show_bug.cgi?id=225062
+        rdar://77021547
+
+        Reviewed by Yusuke Suzuki.
+
+        %TypedArray%.prototype.sort() should not be affected by property changes in
+        Array.prototype.
+
+        References:
+        [1] https://tc39.es/ecma262/#sec-%typedarray%.prototype.sort
+        [2] https://tc39.es/ecma262/#sec-array.prototype.sort
+        [3] https://tc39.es/ecma262/#sec-sortcompare
+
+        * builtins/TypedArrayPrototype.js:
+        (globalPrivate.typedArrayMergeSort):
+
 2021-04-26  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/builtins/TypedArrayPrototype.js

@@ -174 +174 @@
     "use strict";
 
-    var buffer = @newArrayWithSize(valueCount);
+    var constructor = @typedArrayGetOriginalConstructor(array);
+    var buffer = new constructor(valueCount);
     var dst = buffer;
     var src = array;