Timeline


and

12/20/14: Yesterday

18:56 Changeset [177623] by cdumez@apple.com
  • 4 edits in trunk/Source/WebCore

Get rid of error-prone ReleaseParsedCalcValueCondition argument in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=139334

Reviewed by Darin Adler.

Get rid of error-prone ReleaseParsedCalcValueCondition argument in
CSSParser that determines the the m_parsedCalculation member should
be released.

Instead, introduce a new ValueWithCalculation type which wraps a
CSSParserValue and an optional parsed calculation value. This way,
the parsed calculation value is now associated with its CSSParserValue.
This makes it very difficult to use a parsed calculation value for the
wrong CSSParserValue. The API is also easier to use as developers no
longer need to explicitly indicate if the calculation value should be
released or not.

No new tests, no web-behavior change.

10:28 Changeset [177622] by eric.carlson@apple.com
  • 22 edits in trunk/Source

[iOS] add optimized fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=139833
<rdar://problem/18844486>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_VIDEO_PRESENTATION_MODE.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_VIDEO_PRESENTATION_MODE.
  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::optimizedFullscreenSupported): Deleted.
(WebCore::MediaControlsHost::fullscreenMode): Deleted.

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.idl:
  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.addVideoListeners): Listen for 'webkitpresentationmodechanged'.
(ControllerIOS.prototype.removeVideoListeners): Stop listening for 'webkitpresentationmodechanged'.
(ControllerIOS.prototype.configureInlineControls): Call video element instead of using the now

removed host property.

(ControllerIOS.prototype.updateControls): Ditto.
(ControllerIOS.prototype.presentationMode): New, return webkitPresentationMode when possible.
(ControllerIOS.prototype.handleFullscreenButtonClicked): Use webkitSetPresentationMode when possible.
(ControllerIOS.prototype.handleOptimizedFullscreenButtonClicked): Use video element instead of

using the now removed host method.

(ControllerIOS.prototype.handlePresentationModeChange): New, react to presentation mode changes.
(ControllerIOS.prototype.handleFullscreenChange): Call handlePresentationModeChange.

  • dom/EventNames.h: Add webkitpresentationmodechanged.
  • html/HTMLAttributeNames.in: Add onwebkitpresentationmodechanged.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::enterFullscreen): Early return when asked to change to the current

mode. Call fullscreenModeChanged() instead of whacking the instance variable directly.

(WebCore::HTMLMediaElement::exitFullscreen): Ditto.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::fullscreenModeChanged): Make virtual.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute): Deal with onwebkitpresentationmodechange.
(WebCore::presentationModeFullscreen): New.
(WebCore::presentationModeOptimized): Ditto.
(WebCore::presentationModeInline): Ditto.
(WebCore::HTMLVideoElement::webkitSupportsPresentationMode): Ditto.
(WebCore::HTMLVideoElement::webkitSetPresentationMode): Ditto.
(WebCore::HTMLVideoElement::webkitPresentationMode): Ditto.
(WebCore::HTMLVideoElement::fullscreenModeChanged): Ditto.

  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setIsOptimized): Simplify the logic a bit. Don't report

a mode change when

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_VIDEO_PRESENTATION_MODE.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_VIDEO_PRESENTATION_MODE.

Source/WTF:

  • wtf/Platform.h: Define ENABLE_VIDEO_PRESENTATION_MODE.
09:26 Changeset [177621] by ddkilzer@apple.com
  • 42 edits in trunk/Source

Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
<http://webkit.org/b/139463>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:
  • Simplify SECTORDER_FLAGS.

Source/WebCore:

Also remove all uses of SQLITE3_HEADER_SEARCH_PATHS and
WEBCORE_SQLITE3_HEADER_SEARCH_PATHS which were phased out in
r132859 and needed for Leopard.

  • Configurations/Base.xcconfig:
  • Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
  • Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
  • Simplify SQLITE3_HEADER_SEARCH_PATHS.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebCore.xcconfig:
  • Set EXPORTED_SYMBOLS_FILE_i386, EXPORTED_SYMBOLS_FILE_x86_64, FRAMEWORK_SEARCH_PATHS, INSTALL_PATH, DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS, NORMAL_WEBCORE_FRAMEWORKS_DIR, WEBCORE_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production and EXCLUDED_SOURCE_FILE_NAMES based on SDK.
  • Make sure DYLIB_INSTALL_NAME_BASE and OTHER_LDFLAGS are overrideable by WebCoreTestSupport.xcconfig.
  • Configurations/WebCoreTestSupport.xcconfig:
  • Set PRIVATE_HEADERS_FOLDER_PATH_Production and INSTALL_PATH_Production based on SDK.
  • Override SECT_ORDER_FLAGS from WebCore.xcconfig.

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:
  • Only set TOOLCHAINS on OS X.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebInspectorUIFramework.xcconfig:
  • Set NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR and JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
  • Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebKitLegacy.xcconfig:
  • Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64, FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH, DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS, NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR, WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT, WEBCORE_PRIVATE_HEADERS_DIR_Production and WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering based on SDK.
  • Fix PRODUCTION_ROOT to actually be set properly.
  • Simplify EXPORTED_SYMBOLS_FILE_i386.
  • migrate-headers.sh:
  • Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
  • Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to WebKitLegacy.xcconfig.

Source/WebKit2:

  • Configurations/All.xcconfig:
  • Only set EXCLUDED_SOURCE_FILE_NAMES on iOS.
  • Configurations/Base.xcconfig:
  • Only set FRAMEWORK_CONTENT_DIRECTORY, GCC_ENABLE_OBJC_GC and TOOLCHAINS on OS X.
  • Configurations/BaseLegacyProcess.xcconfig:
  • Only set SKIP_INSTALL on iOS.
  • Configurations/BaseTarget.xcconfig:
  • Set WEBKIT_FRAMEWORKS_DIR and UMBRELLA_FRAMEWORKS_DIR based on SDK, and simply them.
  • Configurations/BaseXPCService.xcconfig:
  • Set INSTALL_PATH_ACTUAL_Normal based on SDK.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
  • Configurations/NetworkProcess.xcconfig:
  • Only set EXCLUDED_SHIM_FILE_NAME and CODE_SIGN_ENTITLEMENTS on iOS.
  • Configurations/NetworkService.Development.xcconfig:
  • Set INFOPLIST_FILE based on SDK.
  • Simplify CODE_SIGN_ENTITLEMENTS for iOS.
  • Configurations/NetworkService.xcconfig:
  • Set INFOPLIST_FILE based on SDK.
  • Simplify CODE_SIGN_ENTITLEMENTS for iOS.
  • Configurations/PluginProcess.xcconfig:
  • Only set EXCLUDED_SHIM_FILE_NAME and SKIP_INSTALL on iOS.
  • Configurations/PluginProcessShim.xcconfig:
  • Set OTHER_LDFLAGS based on SDK.
  • Configurations/PluginService.32.xcconfig:
  • Only set VALID_ARCHS on OS X.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Only set SKIP_INSTALL on iOS.
  • Configurations/PluginService.64.xcconfig:
  • Set ARCHS based on SDK.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Only set SKIP_INSTALL on iOS.
  • Configurations/PluginService.Development.xcconfig:
  • Only set SKIP_INSTALL on iOS.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Configurations/SecItemShim.xcconfig:
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebContentProcess.xcconfig:
  • Only set EXCLUDED_SHIM_FILE_NAME on iOS.
  • Only set CODE_SIGN_ENTITLEMENTS on iOS Simulator.
  • Configurations/WebContentService.Development.xcconfig:
  • Set INFOPLIST_FILE and BUNDLE_LOCALIZATION_KEY based on SDK.
  • Only set CODE_SIGN_ENTITLEMENTS on iOS hardware.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Configurations/WebContentService.xcconfig: Ditto.
  • Configurations/WebKit.xcconfig:
  • Set FRAMEWORK_AND_LIBRARY_LDFLAGS, SECTORDER_FLAGS, and WK_API_AVAILABILITY_ENABLED based on SDK.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Only set EXCLUDED_SOURCE_FILE_NAMES on iOS.
  • Configurations/WebKit2.xcconfig:
  • Set INSTALL_PATH, INSTALL_PATH_ACTUAL, DYLIB_INSTALL_NAME_BASE, NORMAL_WEBKIT2_FRAMEWORKS_DIR, WEBKIT2_FRAMEWORKS_DIR and NORMAL_PRODUCTION_FRAMEWORKS_DIR based on SDK.
  • Set SKIP_INSTALL on iOS.
  • Configurations/WebProcessShim.xcconfig:
  • Set OTHER_LDFLAGS based on platform-specific values.

12/19/14:

20:41 Changeset [177620] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Make placeholders more robust
https://bugs.webkit.org/show_bug.cgi?id=139836

Reviewed by Dan Bernstein.

This patch creates a Placeholder object which hides the complexity of
populating offsets to subtables.

No new tests because there is no behavior change.

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::Placeholder::Placeholder):
(WebCore::SVGToOTFFontConverter::Placeholder::populate):
(WebCore::SVGToOTFFontConverter::Placeholder::~Placeholder):
(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable):
(WebCore::SVGToOTFFontConverter::appendGSUBTable):

20:39 Changeset [177619] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/mac/WebInspectorProxyMac.mm:
20:30 Changeset [177618] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Simplify the build fixes from r177615 and r177617.

Rubber-stamped by Dan Bernstein.

  • UIProcess/mac/WebInspectorProxyMac.mm:
19:55 Changeset [177617] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Another attempt at a speculative build fix.

  • UIProcess/mac/WebInspectorProxyMac.mm:
19:41 Changeset [177616] by cdumez@apple.com
  • 7 edits
    2 adds in trunk

Fix initial / inherit support for '-webkit-perspective-origin' CSS property
https://bugs.webkit.org/show_bug.cgi?id=139843

Reviewed by Simon Fraser.

Source/WebCore:

Fix initial / inherit support for '-webkit-perspective-origin' CSS
property. These previously had no effect.

This patch updates the code to be consistent with
'-webkit-transform-origin' and gets rid of the code in
DeprecatedStyleBuilder as it isn't used.

Test: fast/css/perspective-origin-initial-inherit.html

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyPerspectiveOrigin::applyInheritValue): Deleted.
(WebCore::ApplyPropertyPerspectiveOrigin::applyInitialValue): Deleted.
(WebCore::ApplyPropertyPerspectiveOrigin::applyValue): Deleted.
(WebCore::ApplyPropertyPerspectiveOrigin::createHandler): Deleted.

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::asText):

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitPerspectiveOriginShorthand):
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Add layout test to cover 'initial' / 'inherit' support for
'-webkit-perspective-origin' CSS property.

  • fast/css/perspective-origin-initial-inherit-expected.txt: Added.
  • fast/css/perspective-origin-initial-inherit.html: Added.
18:39 Changeset [177615] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Speculative build fix after r177610.

  • UIProcess/mac/WebInspectorProxyMac.mm:
18:38 Changeset [177614] by rniwa@webkit.org
  • 6 edits
    1 add in trunk/Websites/perf.webkit.org

Perf dashboard should support authentication via a slave password
https://bugs.webkit.org/show_bug.cgi?id=139837

Reviewed by Andreas Kling.

For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
having to add multiple builders with the same password when a single build slave is shared among them.

This patch introduces the concept of build_slave into the perf dashboard to end this madness.

  • init-database.sql: Added build_slave table as well as references to it in builds and reports.
  • public/admin/build-slaves.php: Added.
  • public/admin/builders.php: Added the support for updating passwords.
  • public/include/admin-header.php:

(update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
being retrieved from $_POST.
(AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
the raw may not exist (e.g. new_password).
(AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
control here when this flag evaluates to TRUE.

  • public/include/report-processor.php:

(ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
values are present in the report. In addition, try authenticating builderName with slavePassword if
builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
Also insert the slave or the builder whichever is missing after we've successfully authenticated.
(ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
a builder row.
(ReportProcessor::store_report): Store the slave ID with the report.
(ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
the matching build is different from what's being reported.

  • tests/api-report.js: Added a bunch of tests to test the new features of /api/report.

(.addSlave): Added.

17:21 Changeset [177613] by bfulgham@apple.com
  • 2 edits in trunk/Tools

[Win] Revise DRT logic to match Mac.

Rubberstamped by Anders Carlsson.

Update the Windows logic to perform initialization of preferences and WebKit
settings to match Mac. Also make sure that we only ever emit #EOF tokens under
the same circumstances as the Mac version.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump):
(resetWebPreferencesToConsistentValues):
(setDefaultsToConsistentValuesForTesting):
(resetWebViewToConsistentStateBeforeTesting):
(sizeWebViewForCurrentTest):
(runTest):
(createWebViewAndOffscreenWindow):
(allocateGlobalControllers):
(prepareConsistentTestingEnvironment):
(main):
(resetDefaultsToConsistentValues): Deleted.

17:11 Changeset [177612] by cdumez@apple.com
  • 8 edits in trunk/Source/WebKit2

[iOS] Add didEnterFullscreen / didExitFullscreen callbacks to WKUIDelegatePrivate
https://bugs.webkit.org/show_bug.cgi?id=139835
<rdar://problem/19312042>

Reviewed by Anders Carlsson.

Add didEnterFullscreen / didExitFullscreen callbacks to WKUIDelegatePrivate
so that they can be implemented in MobileSafari.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::didEnterFullscreen):
(API::UIClient::didExitFullscreen):

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didEnterFullscreen):
(WebKit::UIDelegate::UIClient::didExitFullscreen):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didEnterFullscreen):
(WebKit::WebPageProxy::didExitFullscreen):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen):
(WebKit::WebVideoFullscreenManagerProxy::didEnterFullscreen):

17:02 Changeset [177611] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix pink background on CoreAnimation plug-ins in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=139845
rdar://problem/19313075

Reviewed by Tim Horton.

r154078 left in some debugging code that set a pink background on plug-in hosting
layers. Remove it.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPluginLayer]):

16:57 Changeset [177610] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Web Inspector: Inspector does not reopen correctly after Inspector Process crashes
https://bugs.webkit.org/show_bug.cgi?id=139838

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-19
Reviewed by Timothy Hatcher.

When the WebContentProcess holding the Inspector Frontend crashes, we
would properly tear down the inspector objects. However, the next time
the inspector is opened, when creating the new page in the Inspector
Page Group, a WebPageProxy is created with a Terminated WebProcessProxy.

That Terminated WebProcessProxy is automatically replaced with the next
load request is given. The newly created process was missing the
message listeners and assumed URL access settings that the
WebInspectorProxy had set on the old process.

So, WebInspectorProxy now listens for and resets the process properties
when the inspector process is recreated.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::didRelaunchInspectorPageProcess):
Reset process properties when the process is relaunched.

(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didClose):
Save connection identifier if we need to establish connections later.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter didRelaunchProcess]):
(-[WKWebInspectorWKView _didRelaunchProcess]):
(WebKit::WebInspectorProxy::closeTimerFired):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Send WebInspectorProxy a message when the process underlying the
WKView is relaunched.

16:52 Changeset [177609] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r177599.
https://bugs.webkit.org/show_bug.cgi?id=139846

this breaks so many things (Requested by thorton_ on #webkit).

Reverted changeset:

"TextIndicator's window can be pushed down if it intersects
the menu bar"
https://bugs.webkit.org/show_bug.cgi?id=139841
http://trac.webkit.org/changeset/177599

16:46 Changeset [177608] by andersca@apple.com
  • 20 edits in trunk/Source/WebKit2

Get rid of the hardcoded set of structs in the message generation script
https://bugs.webkit.org/show_bug.cgi?id=139844

Reviewed by Tim Horton.

Instead, make it possible to use 'struct' in front of the type name to declare that the type is a struct.

  • DatabaseProcess/DatabaseProcess.messages.in:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
  • NetworkProcess/NetworkProcess.messages.in:
  • PluginProcess/PluginProcess.messages.in:
  • PluginProcess/WebProcessConnection.messages.in:
  • Scripts/webkit/messages.py:

(struct_or_class):
(forward_declarations_for_namespace):
(forward_declarations_and_headers):

  • Scripts/webkit/model.py:

(Parameter.init):

  • Scripts/webkit/parser.py:

(parse_parameters_string):

  • UIProcess/Storage/StorageManager.messages.in:
  • UIProcess/WebContext.messages.in:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
  • WebProcess/OriginData/WebOriginDataManager.messages.in:
  • WebProcess/ResourceCache/WebResourceCacheManager.messages.in:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebProcess.messages.in:
16:38 Changeset [177607] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Rollout r177605.

  • EWSTools/start-queue-win.sh:
16:26 Changeset [177606] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.3.15

New Tag.

16:26 Changeset [177605] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.

  • EWSTools/start-queue-win.sh:
16:22 Changeset [177604] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setIgnoresNonWheelEvents:]):

16:17 Changeset [177603] by dbates@webkit.org
  • 4 edits
    3 adds in trunk

[iOS] Add WebKitSystemInterface for iOS 8.1
https://bugs.webkit.org/show_bug.cgi?id=139831

Reviewed by Alexey Proskuryakov.

Tools:

Implement support in copy-webkitlibraries-to-product-directory to copy
WebKitSystemInterface for iOS to the product directory and have build-webkit
pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.

  • Scripts/build-webkit:
  • Scripts/copy-webkitlibraries-to-product-directory:

WebKitLibraries:

Towards building the iOS WebKit port using the public SDK, add the
WebKitSystemInterface for iOS version 8.1.

  • WebKitSystemInterfaceIOS.h: Added.
  • libWebKitSystemInterfaceIOSDevice8.1.a: Added.
  • libWebKitSystemInterfaceIOSSimulator8.1.a: Added.
16:15 Changeset [177602] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] Add WebKitSystemInterface for iOS 8.1
https://bugs.webkit.org/show_bug.cgi?id=139831

Reviewed by Alexey Proskuryakov.

Implement support in copy-webkitlibraries-to-product-directory to copy
WebKitSystemInterface for iOS to the product directory and have build-webkit
pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.

  • Scripts/build-webkit:
  • Scripts/copy-webkitlibraries-to-product-directory:
16:13 Changeset [177601] by bdakin@apple.com
  • 2 edits in trunk/Source/WebKit2

Preview popovers don't show an arrow for large links
https://bugs.webkit.org/show_bug.cgi?id=139842
-and corresponding-
<rdar://problem/19301470>

Reviewed by Tim Horton.

This patch addresses the case where the link is so large that there is no
available space on any side once you factor in screen padding. In that case, we
should give up early on not obscuring the link.

  • UIProcess/mac/WKPreviewPopoverAnimationController.mm:

(-[WKPreviewPopoverAnimationController _targetSizeForPagePreview]):
(-[WKPreviewPopoverAnimationController _effectivePaddingWithPreviewPadding:]):
(-[WKPreviewPopoverAnimationController _maxSpaceAvailableOnYEdgeForOriginRect:withScreenRect:previewPadding:]):
(-[WKPreviewPopoverAnimationController _maxSpaceAvailableOnXEdgeForOriginRect:withScreenRect:previewPadding:]):
(-[WKPreviewPopoverAnimationController _preferredPopoverSizeWithPreviewPadding:forTargetSize:]):

15:54 Changeset [177600] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WKView's ignoresNonWheelEvents should ignore immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139839
<rdar://problem/19312111>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:context:configuration:webView:]):
(-[WKView _setIgnoresNonWheelEvents:]):
Install/uninstall the immediate action gesture recognizer when
toggling ignoresNonWheelEvents.

15:53 Changeset [177599] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

TextIndicator's window can be pushed down if it intersects the menu bar
https://bugs.webkit.org/show_bug.cgi?id=139841
<rdar://problem/19311017>

Reviewed by Anders Carlsson.

  • page/mac/TextIndicatorWindow.mm:

(WebCore::TextIndicatorWindow::setTextIndicator):
Ensure that the textIndicatorWindow sits above the menubar, and re-set
its frame so that it moves under the menubar if required.

15:25 Changeset [177598] by ap@apple.com
  • 6 edits in trunk

REGRESSION (177368): Some tests started to immediately time out
https://bugs.webkit.org/show_bug.cgi?id=139826

Reviewed by Daniel Bates.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):

Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
ends in a load failure, we don't dump, so we used to leak the timer.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):

Added a comment.

LayoutTests:

  • platform/wk2/TestExpectations: The culprit was this test that I unskipped to see

whether it passes. It in fact does pass, so let's remove the expectation entirely.

14:14 Changeset [177597] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Plug leak below LLVMCopyStringRepOfTargetData().
<https://webkit.org/b/139832>

Reviewed by Michael Saboff.

LLVMCopyStringRepOfTargetData() returns a strdup()'ed string, so make sure
to free() it after we're done using it.

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

14:09 Changeset [177596] by ossy@webkit.org
  • 7 edits in trunk/Source/WebKit2

URTBF after r177593.

  • PluginProcess/PluginProcess.h:
  • PluginProcess/unix/PluginProcessUnix.cpp:

(WebKit::PluginProcess::platformInitializePluginProcess):

  • Shared/WebProcessCreationParameters.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

14:06 Changeset [177595] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[WinCairo] Crash after failing to create GL context in accelerated compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=139830

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-19
Reviewed by Alex Christensen.

There is missing a null pointer check.

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::initialize):

13:51 Changeset [177594] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebKit

[Win] Build fix after r177588.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Fix

symbol declaration.

13:48 Changeset [177593] by andersca@apple.com
  • 27 edits in trunk/Source

Use WebCore::MachSendRights for the compositing render server port
https://bugs.webkit.org/show_bug.cgi?id=139834

Reviewed by Tim Horton.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit2:

  • Platform/IPC/HandleMessage.h:

(IPC::callMemberFunctionImpl):

  • Platform/mac/LayerHostingContext.h:
  • Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForPort):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::initializePluginProcess):

  • PluginProcess/PluginProcess.h:

(WebKit::PluginProcess::compositingRenderServerPort):

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::compositingRenderServerPort):

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializePluginProcess):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:
  • Shared/Plugins/PluginProcessCreationParameters.h:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebProcessCreationParameters.h:
  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<MachSendRight>::encode):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::compositingRenderServerPort):
(WebKit::NetscapePlugin::setLayerHostingMode):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::compositingRenderServerPort):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::compositingRenderServerPort):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

13:26 Changeset [177592] by bfulgham@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Unskip a test that started working after r177542. Also clear up some
lint warnings about the TestExpectations file.

  • platform/win/TestExpectations:
13:07 Changeset [177591] by cdumez@apple.com
  • 4 edits in trunk/Source/WebCore

[iOS] Log how often media element playback happens using FeatureCounter
https://bugs.webkit.org/show_bug.cgi?id=139819
<rdar://problem/19309988>

Reviewed by Eric Carlson.

Log using FeatureCounter how often we start loading for audio / video
elements, and how often they end up being played.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
Add flag to identify when a media element starts playing for the first
time.

(WebCore::HTMLMediaElement::loadResource):
Log when a media element starts loading.

(WebCore::HTMLMediaElement::updatePlayState):
Log when a media element starts playing for the first time.

  • html/HTMLMediaElement.h:

Add flag to identify when a media element starts playing for the first
time.

  • platform/FeatureCounterKeys.h:

Add FeatureCounter keys for HTMLMediaElement loading / playback.

12:53 Changeset [177590] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Merged r176725. rdar://problems/19300244

11:50 Changeset [177589] by ap@apple.com
  • 2 edits in trunk/LayoutTests

media/video-seek-past-end-paused.html frequently times out on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=139825

  • platform/mac/TestExpectations: Added an expectation.
11:48 Changeset [177588] by akling@apple.com
  • 7 edits in trunk/Source

Ref-ify TextIterator API.
<https://webkit.org/b/139823>

Reviewed by Antti Koivisto.

Source/WebCore:

Change TextIterator functions that always return Range objects to return
Ref<Range> instead of PassRefPtr<Range>.

One API (rangeFromLocationAndLength) may return nullptr, so its return type
is now RefPtr<Range>.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::range):
(WebCore::TextIterator::node):
(WebCore::SimplifiedBackwardsTextIterator::range):
(WebCore::CharacterIterator::range):
(WebCore::characterSubrange):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::subrange):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::TextIterator::getLocationAndLengthFromRange):
(WebCore::collapsedToBoundary):
(WebCore::findPlainText):

  • editing/TextIterator.h:

Source/WebKit/mac:

  • WebView/WebTextIterator.mm:

(-[WebTextIterator currentRange]):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:

(-[WKDOMTextIterator currentRange]):

11:42 Changeset [177587] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CRASH in inspector-protocol/debugger/terminate-dedicated-worker-while-paused.html
https://bugs.webkit.org/show_bug.cgi?id=139792

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-19
Reviewed by Timothy Hatcher.

  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::removeListener):
When removing listeners, we could be during WorkerGlobalObject shutdown
and WorkerGlobalObject::script may be null.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
This postTask may happen after m_pageInspector has been cleared, so
only execute it if m_pageInspector is still valid.

11:37 Changeset [177586] by cdumez@apple.com
  • 2 edits in trunk/Source/WebCore

Drop useless HTMLMediaElement::m_previousProgress member
https://bugs.webkit.org/show_bug.cgi?id=139822

Reviewed by Eric Carlson.

Drop HTMLMediaElement::m_previousProgress member and it is not used or
even initialized.

  • html/HTMLMediaElement.h:
11:37 Changeset [177585] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
https://bugs.webkit.org/show_bug.cgi?id=139797

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-19
Reviewed by Mark Lam.

Source/JavaScriptCore:

  • debugger/Debugger.h:
  • debugger/Debugger.cpp:

(JSC::Debugger::isAttached):
Check if we are the debugger for a particular global object.
(JSC::Debugger::pauseIfNeeded):
Pass the global object on when hitting a brekapoint.

  • inspector/ScriptDebugServer.h:
  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::handleBreakpointHit):
Stop evaluting breakpoint actions if a previous action caused the
debugger to detach from this global object.
(Inspector::ScriptDebugServer::handlePause):
Standardize on passing JSGlobalObject parameter first.

Source/WebKit/mac:

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::handlePause):
Standardize on passing JSGlobalObject parameter first.

11:34 Changeset [177584] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/speechsynthesis/speech-synthesis-cancel.html times out very frequently
https://bugs.webkit.org/show_bug.cgi?id=139824

  • platform/mac-wk2/TestExpectations: Added an expectation.
11:26 Changeset [177583] by ap@apple.com
  • 6 edits in trunk/LayoutTests

Move some entries for tests that are slow in debug to root TestExpectations file.

  • TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
11:26 Changeset [177582] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Endless compiler warnings created by DFGEdge.h.
<https://webkit.org/b/139801>

Reviewed by Brent Fulgham.

Add a cast to fix the type just the way the 64-bit version does.

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::makeWord):

11:15 Changeset [177581] by cdumez@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Log how successful the memory cache is using FeatureCounter
https://bugs.webkit.org/show_bug.cgi?id=139802

Reviewed by Andreas Kling.

Log how successful the memory cache is using FeatureCounter and why we
choose not to use the resource in the memory cache when it is present.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

  • platform/FeatureCounterKeys.h:
11:07 Changeset [177580] by commit-queue@webkit.org
  • 42 edits in trunk/Source

Unreviewed, rolling out r177574.
https://bugs.webkit.org/show_bug.cgi?id=139821

"Broke Production builds by installing
libWebCoreTestSupport.dylib in the wrong directory" (Requested
by ddkilzer on #webkit).

Reverted changeset:

"Switch from using PLATFORM_NAME to SDK selectors in WebCore,
WebInspectorUI, WebKit, WebKit2"
https://bugs.webkit.org/show_bug.cgi?id=139463
http://trac.webkit.org/changeset/177574

10:58 Changeset [177579] by bfulgham@apple.com
  • 8 edits in trunk

Source/WebKit/win:
[Win] Add accessor for serializing HTTP loads.
https://bugs.webkit.org/show_bug.cgi?id=139817

Reviewed by Mark Lam.

  • Interfaces/IWebViewPrivate.idl: Add new method.
  • WebView.cpp:

(WebView::setLoadResourcesSerially): Provide implementation.

  • WebView.h:

Tools:
[Win] Add accessor for serializing HTTP loads
https://bugs.webkit.org/show_bug.cgi?id=139817

Reviewed by Mark Lam.

  • DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
  • DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also

remove some redundant code from the destructor.

10:48 Changeset [177578] by msaboff@apple.com
  • 5 edits
    3 adds in trunk

REGRESSION(174226): Captured arguments in a using function compiled by the DFG have the initial value when the closure was invoked
https://bugs.webkit.org/show_bug.cgi?id=139808

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

There are three changes here.
1) Create a VariableWatchpointSet for captured arguments variables.
2) Properly use the VariableWatchpointSet* found in op_put_to_scope in the 64 bit LLInt code.
3) Add the same putLocalClosureVar path to the 32 bit LLInt code that exists in the 64 bit version.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

LayoutTests:

New regression test.

  • js/regress-139808-expected.txt: Added.
  • js/regress-139808.html: Added.
  • js/script-tests/regress-139808.js: Added.

(theClosureFunction.rot13):
(theClosureFunction):

10:43 Changeset [177577] by ap@apple.com
  • 5 edits in trunk/LayoutTests

Updte WebKit2 test expectations based on what bots see now.

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
10:36 Changeset [177576] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Only when the SVG is inline and only when a shape is referenced before it is defined, this shape will not be drawn.
https://bugs.webkit.org/show_bug.cgi?id=139451.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-12-19
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: svg/in-html/defs-after-use.html.

When parsing the children of an SVG element is finished, we need to notify the
other SVG elements which have incomplete shadow trees because of early referencing
to this element. The referencing elements need to rebuild their shadow trees and
make new copies of the this element and its sub-tree.

This is the case where a <use> tag references target elements before these target
elements are defined. Updating the shadow DOM tree of a <use> element should update
the corresponding shadow render tree as well.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::finishParsingChildren):
Invalidate all the referencing elements of a target element whose sub-tree has
just finished parsing.

LayoutTests:

Ensure that when a <use> element inside an inline SVG references another
target SVG element, which has not been defined yet, gets its shadow DOM
tree updated once the target element is created. Updating the shadow DOM
tree of the <use> element should update the corresponding shadow render
tree as well.

  • svg/in-html/defs-after-use-expected.html: Added.
  • svg/in-html/defs-after-use.html: Added.
09:57 Changeset [177575] by ap@apple.com
  • 2 edits in trunk/Tools

Clean up a fix for performance test bot failing to build
https://bugs.webkit.org/show_bug.cgi?id=139818

Reviewed by Csaba Osztrogonác.

The "_1" in step name was annoying.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CleanBuildIfScheduled.start):
(RunAndUploadPerfTests):
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):
(CleanBuildUnconditionally): Deleted.
(CleanBuildUnconditionally.start): Deleted.

09:23 Changeset [177574] by ddkilzer@apple.com
  • 42 edits in trunk/Source

Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
<http://webkit.org/b/139463>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:
  • Simplify SECTORDER_FLAGS.

Source/WebCore:

Also remove all uses of SQLITE3_HEADER_SEARCH_PATHS and
WEBCORE_SQLITE3_HEADER_SEARCH_PATHS which were phased out in
r132859 and needed for Leopard.

  • Configurations/Base.xcconfig:
  • Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
  • Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
  • Simplify SQLITE3_HEADER_SEARCH_PATHS.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebCore.xcconfig:
  • Set EXPORTED_SYMBOLS_FILE_i386, EXPORTED_SYMBOLS_FILE_x86_64, FRAMEWORK_SEARCH_PATHS, INSTALL_PATH, DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS, NORMAL_WEBCORE_FRAMEWORKS_DIR, WEBCORE_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production and EXCLUDED_SOURCE_FILE_NAMES based on SDK.
  • Make sure DYLIB_INSTALL_NAME_BASE and OTHER_LDFLAGS are overrideable by WebCoreTestSupport.xcconfig.
  • Configurations/WebCoreTestSupport.xcconfig:
  • Set PRIVATE_HEADERS_FOLDER_PATH_Production and INSTALL_PATH_Production based on SDK.
  • Override SECT_ORDER_FLAGS from WebCore.xcconfig.

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:
  • Only set TOOLCHAINS on OS X.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebInspectorUIFramework.xcconfig:
  • Set NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR and JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
  • Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebKitLegacy.xcconfig:
  • Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64, FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH, DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS, NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR, WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT, WEBCORE_PRIVATE_HEADERS_DIR_Production and WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering based on SDK.
  • Fix PRODUCTION_ROOT to actually be set properly.
  • Simplify EXPORTED_SYMBOLS_FILE_i386.
  • migrate-headers.sh:
  • Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
  • Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to WebKitLegacy.xcconfig.

Source/WebKit2:

  • Configurations/All.xcconfig:
  • Only set EXCLUDED_SOURCE_FILE_NAMES on iOS.
  • Configurations/Base.xcconfig:
  • Only set FRAMEWORK_CONTENT_DIRECTORY, GCC_ENABLE_OBJC_GC and TOOLCHAINS on OS X.
  • Configurations/BaseLegacyProcess.xcconfig:
  • Only set SKIP_INSTALL on iOS.
  • Configurations/BaseTarget.xcconfig:
  • Set WEBKIT_FRAMEWORKS_DIR and UMBRELLA_FRAMEWORKS_DIR based on SDK, and simply them.
  • Configurations/BaseXPCService.xcconfig:
  • Set INSTALL_PATH_ACTUAL_Normal based on SDK.
  • Configurations/DebugRelease.xcconfig:
  • Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
  • Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
  • Configurations/NetworkProcess.xcconfig:
  • Only set EXCLUDED_SHIM_FILE_NAME and CODE_SIGN_ENTITLEMENTS on iOS.
  • Configurations/NetworkService.Development.xcconfig:
  • Set INFOPLIST_FILE based on SDK.
  • Simplify CODE_SIGN_ENTITLEMENTS for iOS.
  • Configurations/NetworkService.xcconfig:
  • Set INFOPLIST_FILE based on SDK.
  • Simplify CODE_SIGN_ENTITLEMENTS for iOS.
  • Configurations/PluginProcess.xcconfig:
  • Only set EXCLUDED_SHIM_FILE_NAME and SKIP_INSTALL on iOS.
  • Configurations/PluginProcessShim.xcconfig:
  • Set OTHER_LDFLAGS based on SDK.
  • Configurations/PluginService.32.xcconfig:
  • Only set VALID_ARCHS on OS X.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Only set SKIP_INSTALL on iOS.
  • Configurations/PluginService.64.xcconfig:
  • Set ARCHS based on SDK.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Only set SKIP_INSTALL on iOS.
  • Configurations/PluginService.Development.xcconfig:
  • Only set SKIP_INSTALL on iOS.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Configurations/SecItemShim.xcconfig:
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Configurations/Version.xcconfig:
  • Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
  • Configurations/WebContentProcess.xcconfig:
  • Only set EXCLUDED_SHIM_FILE_NAME on iOS.
  • Only set CODE_SIGN_ENTITLEMENTS on iOS Simulator.
  • Configurations/WebContentService.Development.xcconfig:
  • Set INFOPLIST_FILE and BUNDLE_LOCALIZATION_KEY based on SDK.
  • Only set CODE_SIGN_ENTITLEMENTS on iOS hardware.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Configurations/WebContentService.xcconfig: Ditto.
  • Configurations/WebKit.xcconfig:
  • Set FRAMEWORK_AND_LIBRARY_LDFLAGS, SECTORDER_FLAGS, and WK_API_AVAILABILITY_ENABLED based on SDK.
  • Set OTHER_LDFLAGS based on platform-specific values.
  • Only set EXCLUDED_SOURCE_FILE_NAMES on iOS.
  • Configurations/WebKit2.xcconfig:
  • Set INSTALL_PATH, INSTALL_PATH_ACTUAL, DYLIB_INSTALL_NAME_BASE, NORMAL_WEBKIT2_FRAMEWORKS_DIR, WEBKIT2_FRAMEWORKS_DIR and NORMAL_PRODUCTION_FRAMEWORKS_DIR based on SDK.
  • Set SKIP_INSTALL on iOS.
  • Configurations/WebProcessShim.xcconfig:
  • Set OTHER_LDFLAGS based on platform-specific values.
02:02 Changeset [177573] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Win64] Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Fixed some 64-bit linker symbols.

00:57 Changeset [177572] by cdumez@apple.com
  • 3 edits in trunk/Source/WebCore

Clean up StyleBuilderCustom and DeprecatedStyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139807

Reviewed by Antti Koivisto.

Clean up StyleBuilderCustom and DeprecatedStyleBuilder.

  • css/DeprecatedStyleBuilder.cpp:
  • Remove unnecessary header includes.

(WebCore::ApplyPropertyPerspectiveOrigin::applyInheritValue):
(WebCore::ApplyPropertyPerspectiveOrigin::applyInitialValue):
(WebCore::ApplyPropertyPerspectiveOrigin::applyValue):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyExpanding::applyInheritValue): Deleted.
(WebCore::ApplyPropertyExpanding::applyInitialValue): Deleted.
(WebCore::ApplyPropertyExpanding::applyValue): Deleted.
(WebCore::ApplyPropertyExpanding::createHandler): Deleted.

  • Rename ApplyPropertyExpanding to ApplyPropertyPerspectiveOrigin as PerspectiveOrigin is the only remaining user of this class. This also allows us to simplify the implementation a lot.

(WebCore::ApplyPropertyDefaultBase::setValue): Deleted.
(WebCore::ApplyPropertyDefaultBase::value): Deleted.
(WebCore::ApplyPropertyDefaultBase::initial): Deleted.
(WebCore::ApplyPropertyDefaultBase::applyInheritValue): Deleted.
(WebCore::ApplyPropertyDefaultBase::applyInitialValue): Deleted.
(WebCore::ApplyPropertyDefaultBase::applyValue): Deleted.

  • There is no longer any user of this templated class.
  • css/StyleBuilderCustom.h:
  • Introduce a macro that declares all 3 handlers (inherit, initial and value) in the StyleBuilderCustom class. This greatly reduces the number of lines in this class.
  • Also alphabetize the handlers.
00:37 Changeset [177571] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.13-branch/Source/WebCore

Merged r177566. rdar://problem/19299453

00:29 Changeset [177570] by bshafiei@apple.com
  • 2 edits in tags/Safari-600.1.4.13.2/Source/WebCore

Merged r177566. rdar://problem/19299453

00:24 Changeset [177569] by ossy@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r177535): It broke the GTK performance bot
https://bugs.webkit.org/show_bug.cgi?id=139811

Reviewed by Carlos Garcia Campos.

Trigger clean build only on mac platform.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

12/18/14:

23:45 Changeset [177568] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WTF

Fix build break on EFL and GTK since r177523
https://bugs.webkit.org/show_bug.cgi?id=139805

Reviewed by Csaba Osztrogonác.

  • wtf/Ref.h: Include <wtf/StdLibExtras.h> to use std::exchange().
23:44 Changeset [177567] by ap@apple.com
  • 2 edits in trunk/LayoutTests

More gardening for flaky tests that are now properly reported as timing oout.

  • platform/mac/TestExpectations:
23:08 Changeset [177566] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

dispatch to main thread before accessing playerController() in WebVideoFullscreenInterfaceAVKit::setCanPlayFastReverse
https://bugs.webkit.org/show_bug.cgi?id=139809

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-12-18
Reviewed by Dan Bernstein.

This prevents a race in playerController().

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setCanPlayFastReverse):

22:14 Changeset [177565] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix.

  • UIProcess/mac/WKPreviewPopoverAnimationController.mm:
21:51 Changeset [177564] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebCore

Build fix.

20:35 Changeset [177563] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

More speculative build fixing.

  • WebCore.exp.in:
20:16 Changeset [177562] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Build fix.

Unreviewed.

  • UIProcess/mac/WKPreviewPopoverAnimationController.mm:

(-[WKPreviewPopoverAnimationController setPreviewOverrideImage:]):
Explicitly pass float into the std::min template.

19:43 Changeset [177561] by hyuki.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, moved myself to the list of committers.

  • Scripts/webkitpy/common/config/contributors.json:
19:29 Changeset [177560] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Speculative build-fix after r177522.

  • UIProcess/mac/WKPreviewPopoverAnimationController.mm:

(-[WKPreviewPopoverAnimationController setPreviewOverrideImage:]):

19:11 Changeset [177559] by akling@apple.com
  • 41 edits in trunk/Source

Ref-ify various Document-related things.
<https://webkit.org/b/139796>

Reviewed by Anders Carlsson.

Source/WebCore:

  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLDocument createDocumentFragmentWithText:]):

  • dom/CDATASection.cpp:

(WebCore::CDATASection::create):
(WebCore::CDATASection::virtualCreate):

  • dom/CDATASection.h:
  • dom/Comment.cpp:

(WebCore::Comment::create):

  • dom/Comment.h:
  • dom/Document.cpp:

(WebCore::Document::create):
(WebCore::Document::createDocumentFragment):
(WebCore::Document::createTextNode):
(WebCore::Document::createComment):
(WebCore::Document::createEditingTextNode):
(WebCore::Document::createCSSStyleDeclaration):
(WebCore::Document::createElement):
(WebCore::Document::createRange):
(WebCore::Document::createParser):
(WebCore::Document::cloneNodeInternal):
(WebCore::Document::cloneDocumentWithoutChildren):

  • dom/Document.h:

(WebCore::Document::create):
(WebCore::Document::createXHTML):
(WebCore::Document::createNonRenderedPlaceholder):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::create):

  • dom/DocumentFragment.h:
  • dom/DocumentType.h:
  • dom/EntityReference.cpp:

(WebCore::EntityReference::create):

  • dom/EntityReference.h:
  • dom/Text.cpp:

(WebCore::Text::create):
(WebCore::Text::createEditingText):
(WebCore::Text::splitText):
(WebCore::Text::virtualCreate):
(WebCore::Text::createWithLengthLimit):

  • dom/Text.h:
  • editing/markup.cpp:

(WebCore::replaceChildrenWithText):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocument::createParser):

  • html/FTPDirectoryDocument.h:
  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::createParser):
(WebCore::HTMLDocument::cloneDocumentWithoutChildren):

  • html/HTMLDocument.h:

(WebCore::HTMLDocument::create):
(WebCore::HTMLDocument::createSynthesizedDocument):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createParser):

  • html/ImageDocument.h:
  • html/MediaDocument.cpp:

(WebCore::MediaDocument::createParser):

  • html/MediaDocument.h:
  • html/PluginDocument.cpp:

(WebCore::PluginDocument::createParser):

  • html/PluginDocument.h:
  • html/TextDocument.cpp:

(WebCore::TextDocument::createParser):

  • html/TextDocument.h:
  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

  • html/parser/HTMLDocumentParser.h:

(WebCore::HTMLDocumentParser::create):

  • loader/SinkDocument.cpp:

(WebCore::SinkDocument::createParser):

  • loader/SinkDocument.h:
  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::cloneDocumentWithoutChildren):

  • svg/SVGDocument.h:
  • xml/parser/XMLDocumentParser.h:

(WebCore::XMLDocumentParser::create):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLParserContext::createStringParser):
(WebCore::XMLParserContext::createMemoryParser):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:

(-[WKDOMDocument createTextNode:]):

19:04 Changeset [177558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[WinCairo] Compile error in code for creating GL context.
https://bugs.webkit.org/show_bug.cgi?id=139782

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-18
Reviewed by Alex Christensen.

The GLContext::createContextForWindow method has changed return type to std::unique_ptr.

  • WebCoreSupport/AcceleratedCompositingContext.h:
18:56 Changeset [177557] by matthew_hanson@apple.com
  • 12 edits in branches/safari-600.3-branch/Source

Merge r177528. rdar://problem/19299367

18:56 Changeset [177556] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r177525. rdar://problems/19288547

18:56 Changeset [177555] by matthew_hanson@apple.com
  • 14 edits
    1 copy
    1 add in branches/safari-600.3-branch/Source

Merge r177522. rdar://problem/19288547

18:56 Changeset [177554] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.3-branch/Source

Versioning.

18:11 Changeset [177553] by bdakin@apple.com
  • 2 edits in trunk/Source/WebKit2

Speculative build fix.

  • UIProcess/ProcessThrottler.h:
17:54 Changeset [177552] by bshafiei@apple.com
  • 6 edits in tags/Safari-601.1.12.1.40/Source

Merged r177483. rdar://problem/19282508

17:52 Changeset [177551] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.12.1.40/Source

Versioning.

17:50 Changeset [177550] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.12.1.40

New tag.

17:42 Changeset [177549] by barraclough@apple.com
  • 2 edits in trunk/Source/WTF

Add strong typing to RefCounter interface, return value as a bool.
https://bugs.webkit.org/show_bug.cgi?id=139776

Unreviewed style fixes.

  • wtf/RefCounter.h:

(WTF::=):

17:40 Changeset [177548] by barraclough@apple.com
  • 12 edits in trunk/Source/WebKit2

Use MachSendRight in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139800

Patch by Anders Carlsson <andersca@apple.com> on 2014-12-18
Reviewed by Tim Horton.

  • Platform/IPC/ArgumentEncoder.h:

(IPC::ArgumentEncoder::encode):
(IPC::ArgumentEncoder::operator<<):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::encode):
(WebKit::RemoteLayerBackingStore::decode):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<MachSendRight>::encode):
(IPC::ArgumentCoder<MachSendRight>::decode):

17:28 Changeset [177547] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.3.14

New Tag.

17:28 Changeset [177546] by bfulgham@apple.com
  • 2 edits in trunk/Source/WebKit

[Win] Unreviewed build correction after r177513.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Correct for new

method signature.

17:17 Changeset [177545] by bfulgham@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

  • jsc.cpp: Remove typo.
17:15 Changeset [177544] by bfulgham@apple.com
  • 2 edits in trunk/Source/WTF

[Win] Build correction after r177541.

  • wtf/RefCounter.h:

(WTF::RefCounter::Token<T>::Token): Revise constructor inlines to correct
syntax error.

17:02 Changeset [177543] by andersca@apple.com
  • 10 edits in trunk/Source

Use MachSendRight in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139800

Reviewed by Tim Horton.

Source/WebCore:

  • WebCore.exp.in:
  • platform/cocoa/MachSendRight.h:

(WebCore::MachSendRight::MachSendRight):
(WebCore::MachSendRight::sendRight):

  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::createFromSendRight):
(IOSurface::createFromMachPort): Deleted.

Source/WebKit2:

  • Platform/IPC/ArgumentEncoder.h:

(IPC::ArgumentEncoder::encode):
(IPC::ArgumentEncoder::operator<<):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::encode):
(WebKit::RemoteLayerBackingStore::decode):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<MachSendRight>::encode):
(IPC::ArgumentCoder<MachSendRight>::decode):

17:00 Changeset [177542] by bfulgham@apple.com
  • 11 edits in trunk

[Win] Update DumpRenderTree to more closely match Mac version
https://bugs.webkit.org/show_bug.cgi?id=139799

Reviewed by Tim Horton.

Source/WebKit/win:

  • Interfaces/IWebSecurityOrigin.idl: Add initializer from URL.
  • Interfaces/WebKit.idl: Add CLSID so we can instantiate a

WebSecurityOrigin from COM.

  • WebApplicationCache.h: Decorate class declaration with CLSID

to support COM introspection.

  • WebSecurityOrigin.cpp: Get rid of meaningless STDMETHODCALLTYPE

declarations inside implementation.
(WebSecurityOrigin::QueryInterface):
(WebSecurityOrigin::AddRef):
(WebSecurityOrigin::Release):
(WebSecurityOrigin::protocol):
(WebSecurityOrigin::host):
(WebSecurityOrigin::port):
(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):
(WebSecurityOrigin::initWithURL): Added.

  • WebSecurityOrigin.h:

Tools:

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::accessibleElementById): Correct
use of BSTR to avoid leak.

  • DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and

update to match Mac version more closely.
(dumpFramesAsText):
(dump):
(resetDefaultsToConsistentValues):
(resetWebViewToConsistentStateBeforeTesting):
(sizeWebViewForCurrentTest):
(runTest):
(openWindows):
(windowToWebViewMap):
(createWebViewAndOffscreenWindow):
(sharedCFURLCache):
(initializeGlobalsFromCommandLineOptions):
(main):

  • DumpRenderTree/win/TestRunnerWin.cpp: Ditto.

(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::syncLocalStorage):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::observeStorageTrackerNotifications):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::originsWithApplicationCache):
(TestRunner::deleteAllLocalStorage):
(TestRunner::setStorageDatabaseIdleInterval):
(TestRunner::closeIdleLocalStorageDatabases):
(TestRunner::originsWithLocalStorage):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::keepWebHistory):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::setAppCacheMaximumSize):
(TestRunner::setCustomPolicyDelegate):
(TestRunner::goBack):
(TestRunner::setDefersLoading):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setIconDatabaseEnabled):
(TestRunner::setMainFrameIsFirstResponder):
(TestRunner::setSpatialNavigationEnabled):
(TestRunner::setPluginsEnabled):
(TestRunner::setAutomaticLinkDetectionEnabled):
(TestRunner::setUseDashboardCompatibilityMode):
(TestRunner::dispatchPendingLoadRequests):
(TestRunner::findString):
(TestRunner::setCacheModel):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(TestRunner::setWebViewEditable):
(TestRunner::authenticateSession):
(TestRunner::abortModal):
(TestRunner::setSerializeHTTPLoads):
(TestRunner::addChromeInputField):
(TestRunner::removeChromeInputField):
(TestRunner::focusWebView):
(TestRunner::setBackingScaleFactor):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):

16:51 Changeset [177541] by barraclough@apple.com
  • 19 edits in trunk

Add strong typing to RefCounter interface, return value as a bool.
https://bugs.webkit.org/show_bug.cgi?id=139776

Reviewed by Geoff Garen.

Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
This means there is no compile time type checking to prevent mistakes. Update the count()
method to token<>(), templated on type used to identify the token being returned.
Calls to token<T>() will return a result of type RefCounter::Token<T>.

There are a few problems with the fact the counter will return you an exact count of the
number of outstanding tokens:

  • It is desirable to only fire the callback on zero-edge changes; it is more consistent to do so if the value is only readable as a boolean.
  • It is desirable to provide the value as an argument to the callback, however to make this useful for integer values it is also necessary to indicate the direction of change (0->1 is often interesting where 2->1 is not).
  • There is a mismatch between the precision of returning a count, and the inherent imprecision of a token based mechanism, where it may be difficult to guarantee absolutely no unnecessary refcount churn, and thus unintentional counter values.

Source/WebCore:

  • page/PageThrottler.cpp:

(WebCore::m_mediaActivityCounter):
(WebCore::m_pageLoadActivityCounter):

  • lambdas now passed the value.

(WebCore::PageThrottler::mediaActivityToken):
(WebCore::PageThrottler::pageLoadActivityToken):

  • count() -> token<>().
  • page/PageThrottler.h:
    • specify tpoken type for PageActivityAssertionToken.

Source/WebKit2:

Removed PluginProcessManager::m_processSuppressionEnabled. Now the callback only fires on
zero-edge transitions we no longer need this to filter changes.

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::PluginProcessManager):

  • updateProcessSuppressionState -> updateProcessSuppressionDisabled.
  • UIProcess/Plugins/PluginProcessManager.h:

(WebKit::PluginProcessManager::processSuppressionDisabledForPageCount): Deleted.
(WebKit::PluginProcessManager::processSuppressionDisabledToken):

  • processSuppressionDisabledForPageCount -> processSuppressionDisabledToken.

(WebKit::PluginProcessManager::processSuppressionEnabled): Deleted.
(WebKit::PluginProcessManager::processSuppressionDisabled):

  • processSuppressionEnabled -> processSuppressionDisabled.
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

  • processSuppressionEnabled -> processSuppressionDisabled.
  • UIProcess/Plugins/mac/PluginProcessManagerMac.mm:

(WebKit::PluginProcessManager::updateProcessSuppressionState): Deleted.
(WebKit::PluginProcessManager::updateProcessSuppressionDisabled):

  • updateProcessSuppressionState -> updateProcessSuppressionDisabled
  • UIProcess/ProcessThrottler.h:
    • added UserObservablePageToken, ProcessSuppressionDisabledToken types.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::m_processSuppressionDisabledForPageCounter):

  • lambda now has bool argument.
  • UIProcess/WebContext.h:

(WebKit::WebContext::userObservablePageCount):
(WebKit::WebContext::processSuppressionDisabledForPageCount):

  • count() -> token<>(), changed return type.
  • UIProcess/WebPageProxy.h:
    • changed types of token members.
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::updateProcessSuppressionState):

renamed m_pluginProcessManagerProcessSuppressionDisabledCount -> m_pluginProcessManagerProcessSuppressionDisabledToken.

Source/WTF:

  • wtf/RefCounter.cpp:

(WTF::RefCounter::Count::ref):
(WTF::RefCounter::Count::deref):

  • only call the callback on zero-edge changes; provide the value.

(WTF::RefCounter::RefCounter):

  • callback now takes a bool argument.
  • wtf/RefCounter.h:

(WTF::RefCounter::Token::Token):

  • New opaque type to reference the RefCounter::Count.

(WTF::RefCounter::Token::operator!):

  • ! operator checks for null / anasigned Tokens.

(WTF::RefCounter::RefCounter):

  • callback now takes a bool argument.

(WTF::RefCounter::token):

  • renamed from count(), templated on type of token returned.

(WTF::RefCounter::value):

  • now returns a bool.

(WTF::RefCounter::Token<T>::Token):
(WTF::=):

  • Tokens can be copied & assigned.

(WTF::RefCounter::count): Deleted.

  • renamed to token<>().

Tools:

  • TestWebKitAPI/Tests/WTF/RefCounter.cpp:

(TestWebKitAPI::TEST):

  • update API test.
16:27 Changeset [177540] by ap@apple.com
  • 2 edits in trunk/Tools

Disable retries on Mac Release WK2 testers
https://bugs.webkit.org/show_bug.cgi?id=139798

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
16:12 Changeset [177539] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix some builds.

  • UIProcess/mac/WKPreviewPopoverAnimationController.mm:
16:03 Changeset [177538] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLFormControlElement and HTMLObjectElement need not to look for an ancestor on construction
https://bugs.webkit.org/show_bug.cgi?id=139791

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-18
Reviewed by Alexey Proskuryakov.

The objects are being constructed, they have not been inserted into the tree yet.
There is not chance of finding the owner form at this point,
that is done when inserting the node into the tree.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::HTMLObjectElement):

15:51 Changeset [177537] by cfleizach@apple.com
  • 4 edits in trunk

AX: Recursive crash at WebCore::accessibleNameForNode
https://bugs.webkit.org/show_bug.cgi?id=139616

Reviewed by Mario Sanchez Prada.

Source/WebCore:

An image that uses aria-labelledby to reference its own parent can lead to a recursion crash.
There needs to be some information we can pass through these methods to ensure we don't hit this case.

Test: accessibility/accessibility-description-crash.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityTextUnderElementMode::AccessibilityTextUnderElementMode):

LayoutTests:

  • accessibility/accessibility-description-crash-expected.txt: Added.
  • accessibility/accessibility-description-crash.html: Added.
15:25 Changeset [177536] by cfleizach@apple.com
  • 5 edits
    2 adds in trunk

AX: Heuristic: Avoid exposing an element as clickable if mouse event delegation is handled on an element with any explicit ARIA role, including presentation.
https://bugs.webkit.org/show_bug.cgi?id=133613

Reviewed by Mario Sanchez Prada.

Source/WebCore:

This adds a heuristic to avoid a problem we have where too many objects that say they respond to press actions for accessibility.
It results from people installing click handlers on container nodes and then lots of static text objects are "clickable" in the eyes of VoiceOver.

What we can do is avoid this determination if the element is presentational.

Test: platform/mac/accessibility/press-action-for-presentational-descendants.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::nodeHasPresentationRole):
(WebCore::AccessibilityObject::supportsPressAction):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):

LayoutTests:

  • platform/mac/accessibility/press-action-for-presentational-descendants-expected.txt: Added.
  • platform/mac/accessibility/press-action-for-presentational-descendants.html: Added.
15:22 Changeset [177535] by ap@apple.com
  • 3 edits in trunk/Tools

Perf tests frequently fail saying "build not up to date"
https://bugs.webkit.org/show_bug.cgi?id=139786

Illegitimately yet authoritatively reviewed by Lucas Forschler.

Undo the rest of the first fix, and implement the behavior differently.

is_clean isn't automatically forwarded from config.json to properties.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CleanBuildUnconditionally):
(CleanBuildUnconditionally.start):
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

15:14 Changeset [177534] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/API/mac/WKViewInternal.h:
15:06 Changeset [177533] by ap@apple.com
  • 2 edits in trunk/Tools

Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
found nothing.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildAndPerfTestFactory):
(BuildAndPerfTestWebKit2Factory):

14:59 Changeset [177532] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: event.target should sometimes be a descendant element on AXPress-triggered mouse clicks
https://bugs.webkit.org/show_bug.cgi?id=135689

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When trying to find the right sub-node to target, we need to go back up the parent chain to find
an Element, in case we land on a Text node for example.

Test: accessibility/press-target-uses-text-descendant-node.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):

LayoutTests:

  • accessibility/press-target-uses-text-descendant-node-expected.txt: Added.
  • accessibility/press-target-uses-text-descendant-node.html: Added.
14:59 Changeset [177531] by cdumez@apple.com
  • 2 edits in trunk/Source/WebKit2

Add missing availability annotation on @property _featureCounterEnabled
https://bugs.webkit.org/show_bug.cgi?id=139794
<rdar://problem/19266254>

Rubber-stamped by Dan Bernstein.

Follow-up to r177526 adding availability annotation on @property
_featureCounterEnabled.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
14:53 Changeset [177530] by rniwa@webkit.org
  • 7 edits in trunk/Websites/perf.webkit.org

New perf dashboard should not duplicate author information in each commit
https://bugs.webkit.org/show_bug.cgi?id=139756

Reviewed by Darin Adler.

Instead of each commit having author name and email, make it reference a newly added committers table.
Also replace "email" by "account" since some repositories don't use emails as account names.

This improves the keyword search performance in commits.php since LIKE now runs on committers table,
which only contains as many rows as there are accounts in each repository, instead of commits table
which contains every commit ever happened in each repository.

To migrate an existing database into match the new schema, run:

BEGIN;

INSERT INTO committers (committer_repository, committer_name, committer_email)

(SELECT DISTINCT commit_repository, commit_author_name, commit_author_email

FROM commits WHERE commit_author_email IS NOT NULL);

ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;

UPDATE commits SET commit_committer = committer_id FROM committers

WHERE commit_repository = committer_repository AND commit_author_email = committer_email;

ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;

COMMIT;

  • init-database.sql: Added committers table, and replaced author columns in commits table by a foreign

reference to committers. Also added the missing drop table statements.

  • public/api/commits.php:

(main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
an array here instead of doing it in format_commit.
(fetch_commits_between): Updated queries to JOIN commits with committers.
(format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
is now done in main.

  • public/api/report-commits.php:

(main): Store the reported committer information or update the existing entry if there is one.

  • tests/admin-regenerate-manifest.js: Fixed tests.
  • tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
  • tools/pull-svn.py: Renamed email to account.

(main):
(fetch_commit_and_resolve_author):
(fetch_commit):
(resolve_author_name_from_account):
(resolve_author_name_from_email): Deleted.

14:51 Changeset [177529] by ap@apple.com
  • 3 edits in trunk/Tools

Perf tests frequently fail saying "build not up to date"
https://bugs.webkit.org/show_bug.cgi?id=139786

Reviewed by Ryosuke Niwa.

Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
directory to get rid of stale precompiled headers, and let it rebuild
DumpRenderTree each time, that's fast.

Also, removed unused "build and perf test" code.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:36 Changeset [177528] by bdakin@apple.com
  • 12 edits in trunk/Source

Need to re-enable action menus
https://bugs.webkit.org/show_bug.cgi?id=139795
-and corresponding-
rdar://problem/19299367

Reviewed by Tim Horton.

Re-enable the menus by un-commenting the code to create the menu and controller.
Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:context:configuration:webView:]):

performActionMenuHitTest already takes a parameter indicating whether the hit test
is for an immediate action or not. The callback didPerformActionMenuHitTest needs
that information too so that it knows whether to call into the
ActionMenuController or the ImmediateActionController.
(-[WKView _didPerformActionMenuHitTest:forImmediateAction:userData:]):
(-[WKView _didPerformActionMenuHitTest:userData:]): Deleted.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didPerformActionMenuHitTest):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformActionMenuHitTest):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):

14:32 Changeset [177527] by weinig@apple.com
  • 10 edits in trunk/Source

Unify the Mac and iOS implementations of FontPlatformData a bit
https://bugs.webkit.org/show_bug.cgi?id=139721

Reviewed by Anders Carlsson.

Source/WebCore:

This is a first pass of unifying the Mac and iOS implementations of FontPlatformData.
Notable changes:

  • Change the storage of the platform font to be CTFontRef across the board. Adds NSFont setter/getter/constructor as a temporary measures during the transition away from NSFont.
  • Removes duplicate code that only differed by whether the type was NSFont or CTFontRef.
  • Reduces the number of #ifdefs.
  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::openTypeTable): Deleted.

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::nsFont):
(WebCore::FontPlatformData::setNSFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::toCTFontRef): Deleted.
(WebCore::FontPlatformData::font): Deleted.
(WebCore::FontPlatformData::roundsGlyphAdvances): Deleted.
(WebCore::FontPlatformData::cgFont): Deleted.
(WebCore::FontPlatformData::hashTableDeletedFontValue): Deleted.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::roundsGlyphAdvances):
(WebCore::FontPlatformData::allowsLigatures):
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::openTypeTable):
(WebCore::FontPlatformData::loadFont): Deleted.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCreateScaledFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::renderingStyle):
(WebCore::SimpleFontData::advanceForColorBitmapFont):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(fontNameForDescription):
Update for new function name.

14:32 Changeset [177526] by cdumez@apple.com
  • 8 edits in trunk/Source/WebKit2

[WK2] Stop using WKPreferencesPrivate API to toggle FeatureCounter support
https://bugs.webkit.org/show_bug.cgi?id=139794
<rdar://problem/19266254>

Reviewed by Anders Carlsson.

Stop using WKPreferencesPrivate API to toggle FeatureCounter support
and use WKWebViewConfigurationPrivate API instead. FeatureCounter is
not meant to change state after the view has been created.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetFeatureCounterEnabled): Deleted.
(WKPreferencesGetFeatureCounterEnabled): Deleted.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _featureCounterEnabled]): Deleted.
(-[WKPreferences _setFeatureCounterEnabled:]): Deleted.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _featureCounterEnabled]):
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
14:29 Changeset [177525] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPreviewOverrideImage:]):

14:29 Changeset [177524] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/cocoa/MachSendRight.cpp:
14:27 Changeset [177523] by andersca@apple.com
  • 9 edits in trunk/Source/WTF

Simplify smart pointer classes by using std::exchange
https://bugs.webkit.org/show_bug.cgi?id=139790

Reviewed by Andreas Kling.

  • wtf/MallocPtr.h:
  • wtf/OSObjectPtr.h:
  • wtf/OwnPtr.h:

(WTF::OwnPtr<T>::clear):
(WTF::OwnPtr<T>::release):
(WTF::OwnPtr<T>::leakPtr):
(WTF::=):

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr<T>::leakPtr):

  • wtf/PassRefPtr.h:

(WTF::PassRefPtr<T>::leakRef):

  • wtf/Ref.h:
  • wtf/RefPtr.h:

(WTF::RefPtr<T>::clear):
(WTF::RefPtr<T>::leakRef):

  • wtf/RetainPtr.h:

(WTF::RetainPtr<T>::leakRef):

14:14 Changeset [177522] by timothy_horton@apple.com
  • 14 edits
    2 adds in trunk/Source

Change page preview loading order, and add a TextIndicator
https://bugs.webkit.org/show_bug.cgi?id=139793
<rdar://problem/19288547>

Reviewed by Beth Dakin.

  • Shared/mac/ActionMenuHitTestResult.h:
  • Shared/mac/ActionMenuHitTestResult.mm:

(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):
Build a TextIndicator for links.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]):
(-[WKView _setPreviewTitle:]):
(-[WKView _setPreviewLoading:]):
Remove unneeded WK_API_ENABLED #ifs.

(-[WKView _setPreviewOverrideImage:]):
Add; forward to WKImmediateActionController.

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController willDestroyView:]):
Shut down the WKPreviewPopoverAnimationController.

(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
Don't build an immediate action item here; we'll always build it in
willBeginAnimation, and the one we build here is likely to be wrong.

(-[WKImmediateActionController _defaultAnimationController]):
(-[WKImmediateActionController hidePreview]):
(-[WKImmediateActionController setPreviewTitle:]):
(-[WKImmediateActionController setPreviewLoading:]):
(-[WKImmediateActionController setPreviewOverrideImage:]):
(-[WKImmediateActionController _animationControllerForCustomPreview]):
(-[WKImmediateActionController _createPreviewPopoverIfNeededForURL:]): Deleted.
(-[WKImmediateActionController popoverWillClose:]): Deleted.
(targetSizeFitsInAvailableSpace): Deleted.
(-[WKImmediateActionController largestPopoverSize]): Deleted.
(-[WKImmediateActionController _preferredPopoverSizeWithPreviewPadding:]): Deleted.
(-[WKImmediateActionController pagePreviewViewController:viewForPreviewingURL:initialFrameSize:]): Deleted.
(-[WKImmediateActionController pagePreviewViewController:titleForPreviewOfURL:]): Deleted.
(-[WKImmediateActionController pagePreviewViewControllerWasClicked:]): Deleted.
Move preview popover code to WKPreviewPopoverAnimationController.
Install and uninstall the link text indicator when necessary.

  • UIProcess/mac/WKPagePreviewViewController.h:
  • UIProcess/mac/WKPagePreviewViewController.mm:

(-[WKPagePreviewViewController setLoading:]):
(-[WKPagePreviewViewController loadView]):
(-[WKPagePreviewViewController replacePreviewWithImage:atSize:]):
Allow overriding the preview with a full-view NSImage.
Hide the preview view until the loading spinner goes away.

  • UIProcess/mac/WKPreviewPopoverAnimationController.h: Copied from Source/WebKit2/UIProcess/mac/WKImmediateActionController.h.
  • UIProcess/mac/WKPreviewPopoverAnimationController.mm: Added.

(+[WKPreviewPopoverAnimationController _shouldImmediatelyShowPreview]):
(-[WKPreviewPopoverAnimationController initWithURL:view:page:originRect:eventLocationInView:]):
(-[WKPreviewPopoverAnimationController close]):
(-[WKPreviewPopoverAnimationController setPreviewLoading:]):
(-[WKPreviewPopoverAnimationController setPreviewOverrideImage:]):
If we have shown the popover, choose a size strictly smaller than
its current size.

(-[WKPreviewPopoverAnimationController _hidePreview]):
(-[WKPreviewPopoverAnimationController setPreviewTitle:]):
(-[WKPreviewPopoverAnimationController _createPreviewPopover]):
(-[WKPreviewPopoverAnimationController _showPreview]):
(targetSizeFitsInAvailableSpace):
(-[WKPreviewPopoverAnimationController largestPopoverSize]):
(-[WKPreviewPopoverAnimationController _targetSizeForPagePreview]):
(-[WKPreviewPopoverAnimationController _preferredPopoverSizeWithPreviewPadding:forTargetSize:]):
(-[WKPreviewPopoverAnimationController _previewWatchdogTimerFired:]):
(-[WKPreviewPopoverAnimationController recognizerWillBeginAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidUpdateAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidCancelAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidCompleteAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidDismissAnimation:]):
(-[WKPreviewPopoverAnimationController pagePreviewViewController:viewForPreviewingURL:initialFrameSize:]):
(-[WKPreviewPopoverAnimationController pagePreviewViewController:titleForPreviewOfURL:]):
(-[WKPreviewPopoverAnimationController pagePreviewViewControllerWasClicked:]):
(-[WKPreviewPopoverAnimationController popoverWillClose:]):
Move code in from WKImmediateActionController.
Forward NSImmediateActionAnimationControllerDelegate methods
to the popover's animation controller if we've popped it.
Pop the popover if we've loaded or 1 second has passed, whichever
comes first.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebCore.exp.in:
  • platform/spi/mac/NSPopoverSPI.h:

Add an export and some SPI.

13:31 Changeset [177521] by andersca@apple.com
  • 5 edits in trunk/Source

Clean up MachSendRight and add a copySendRight member function
https://bugs.webkit.org/show_bug.cgi?id=139788

Reviewed by Tim Horton.

Source/WebCore:

  • platform/cocoa/MachSendRight.cpp:

(WebCore::retainSendRight):
(WebCore::releaseSendRight):
Use mach_error_string.

(WebCore::MachSendRight::copySendRight):
Create a new send right with the given mach port.

(WebCore::MachSendRight::leakSendRight):
Use std::exchange.

  • platform/cocoa/MachSendRight.h:

Source/WTF:

  • wtf/StdLibExtras.h:

(std::exchange):
Add an implementation of std::exchange.

13:29 Changeset [177520] by ap@apple.com
  • 2 edits in trunk/LayoutTests

media/media-controls-timeline-updates.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139789

  • platform/mac/TestExpectations: Mark it as such.
13:18 Changeset [177519] by dbates@webkit.org
  • 3 edits
    48 moves
    634 adds
    1150 deletes in trunk/LayoutTests

[iOS] Updated expected results for LayoutTests/editing

  • platform/ios-simulator-wk2/TestExpectations:

[...]

12:45 Changeset [177518] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ASSERT seen closing/opening multiple inspectors
https://bugs.webkit.org/show_bug.cgi?id=139783

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-18
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForObjectId):

12:38 Changeset [177517] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update flaky media test expectations to what bots see now - mostly updating for
better detection of timeouts.

  • platform/mac/TestExpectations:
12:29 Changeset [177516] by andersca@apple.com
  • 7 edits
    2 adds in trunk/Source

Add a MachSendRight class to WebCore and use it in IOSurface
https://bugs.webkit.org/show_bug.cgi?id=139787

Reviewed by Tim Horton.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cocoa/MachSendRight.cpp: Added.

(WebCore::retainSendRight):
(WebCore::releaseSendRight):
(WebCore::MachSendRight::adopt):
(WebCore::MachSendRight::create):
(WebCore::MachSendRight::MachSendRight):
(WebCore::MachSendRight::~MachSendRight):
(WebCore::MachSendRight::operator=):
(WebCore::MachSendRight::leakSendRight):

  • platform/cocoa/MachSendRight.h: Added.
  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::createSendRight):
(IOSurface::createMachPort): Deleted.

Source/WebKit2:

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::encode):

12:25 Changeset [177515] by bfulgham@apple.com
  • 2 edits in trunk/Tools

[Win] Unreviewed gardening. Reorder file contents to match Mac version.

Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
it easier to see what steps are missing when running under Windows.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::callShouldCloseOnWebView):
(TestRunner::clearAllApplicationCaches):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::syncLocalStorage):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::observeStorageTrackerNotifications):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::originsWithApplicationCache):
(TestRunner::clearAllDatabases):
(TestRunner::deleteAllLocalStorage):
(TestRunner::setStorageDatabaseIdleInterval):
(TestRunner::closeIdleLocalStorageDatabases):
(TestRunner::originsWithLocalStorage):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(jsStringRefToWString):
(TestRunner::setAppCacheMaximumSize):
(TestRunner::setDatabaseQuota):
(TestRunner::goBack):
(TestRunner::setDefersLoading):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setAutomaticLinkDetectionEnabled):
(TestRunner::dispatchPendingLoadRequests):
(TestRunner::overridePreference):
(TestRunner::removeAllVisitedLinks):
(TestRunner::waitForPolicyDelegate):
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):
(TestRunner::simulateLegacyWebNotificationClick):

12:22 Changeset [177514] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Ref-ify DOMSettableTokenList.
<https://webkit.org/b/139785>

Reviewed by Chris Dumez.

Make DOMSettableTokenList::create() return a Ref, and have its two client
elements store it in a Ref instead of a RefPtr (and fix their getter API
to return references.)

  • html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::create): Deleted.

  • html/DOMSettableTokenList.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::sizes): Deleted.

  • html/HTMLLinkElement.h:
  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::htmlFor): Deleted.

  • html/HTMLOutputElement.h:
12:21 Changeset [177513] by akling@apple.com
  • 11 edits in trunk/Source/WebCore

Ref-ify ClientRectList.
<https://webkit.org/b/139780>

Reviewed by Anders Carlsson.

Make the ClientRectList::create() helpers return Ref, along with a bunch
of other functions that always return non-null ClientRectLists.

Also make ClientRectList store a Vector<Ref<ClientRect>> internally since
entries in the Vector are never null.

  • dom/ClientRectList.cpp:

(WebCore::ClientRectList::item):

  • dom/ClientRectList.h:

(WebCore::ClientRectList::create):

  • dom/Element.cpp:

(WebCore::Element::getClientRects):

  • dom/Element.h:
  • dom/Range.cpp:

(WebCore::Range::getClientRects):

  • dom/Range.h:
  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

  • page/Page.h:
  • testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::nonFastScrollableRects):

  • testing/Internals.h:
11:56 Changeset [177512] by bfulgham@apple.com
  • 11 edits
    3 adds in trunk

Source/WebKit:
[Win] Correct Windows tests after Bug 139149.
https://bugs.webkit.org/show_bug.cgi?id=139781

Reviewed by Anders Carlsson.

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new interface.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Add new application cache object.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.

Source/WebKit/win:
[Win] Correct Windows tests after Bug 139149.
https://bugs.webkit.org/show_bug.cgi?id=139781

Reviewed by Anders Carlsson.

  • Interfaces/IWebApplicationCache.idl: Added.
  • Interfaces/WebKit.idl: Add new IDL file.
  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read): Remove old debugging message.

  • WebApplicationCache.cpp: Added.

(WebApplicationCache::WebApplicationCache):
(WebApplicationCache::~WebApplicationCache):
(WebApplicationCache::createInstance):
(WebApplicationCache::QueryInterface):
(WebApplicationCache::AddRef):
(WebApplicationCache::Release):
(WebApplicationCache::maximumSize):
(WebApplicationCache::setMaximumSize):
(WebApplicationCache::defaultOriginQuota):
(WebApplicationCache::setDefaultOriginQuota):
(WebApplicationCache::diskUsageForOrigin):
(WebApplicationCache::deleteAllApplicationCaches):
(WebApplicationCache::deleteCacheForOrigin):
(WebApplicationCache::originsWithCache):

  • WebApplicationCache.h: Added.
  • WebKitClassFactory.cpp: Add new interface header.

Tools:
[Win] Correct Windows tests after Bug 139149 (edit)
https://bugs.webkit.org/show_bug.cgi?id=139781

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
interface.

11:52 Changeset [177511] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

Attempt to fix Windows build after Range::create() changes.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
11:50 Changeset [177510] by simon.fraser@apple.com
  • 2 edits in trunk/Tools

[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
https://bugs.webkit.org/show_bug.cgi?id=139748

Reviewed by Daniel Bates.

Staging change to support --ios-sim and --ios-simulator temporarily until the bots
have all been updated.

  • Scripts/webkitpy/port/factory.py:

(platform_options):

11:38 Changeset [177509] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.13-branch/Source

Versioning.

11:31 Changeset [177508] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Ref-ify ClientRect.
<https://webkit.org/b/139777>

Reviewed by Anders Carlsson.

Make the ClientRect::create() helpers return Ref, along with a bunch
of other functions that always return non-null ClientRects.

  • dom/ClientRect.h:

(WebCore::ClientRect::create):

  • dom/Element.cpp:

(WebCore::Element::getBoundingClientRect):

  • dom/Element.h:
  • dom/Range.cpp:

(WebCore::Range::getBoundingClientRect):

  • dom/Range.h:
  • html/track/VTTRegion.cpp:

(WebCore::VTTRegion::displayLastTextTrackCueBox):

  • testing/Internals.cpp:

(WebCore::Internals::absoluteCaretBounds):
(WebCore::Internals::boundingBox):
(WebCore::Internals::selectionBounds):

  • testing/Internals.h:
11:24 Changeset [177507] by ap@apple.com
  • 9 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=139779
Fullscreen tests use unreasonably short timeouts

Reviewed by Eric Carlson.

  • fullscreen/exit-full-screen-iframe.html:
  • fullscreen/full-screen-iframe-allowed-prefixed.html:
  • fullscreen/full-screen-iframe-allowed.html:
  • fullscreen/full-screen-iframe-legacy.html:
  • fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html:
  • fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html:

Removed the timeouts.

  • platform/mac-wk1/TestExpectations: fullscreen/exit-full-screen-iframe.html

legitimately fails in DumpRenderTree, which we didn't know about.

  • platform/mac/TestExpectations: Removed tests that should no longer be flaky now.
11:22 Changeset [177506] by simon.fraser@apple.com
  • 110 edits
    1 copy
    1 move
    2 adds in trunk/Tools

Build more of TestWebKitAPI for iOS
https://bugs.webkit.org/show_bug.cgi?id=139747

Reviewed by Daniel Bates.

Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
which excluded some tests that should be run for iOS.

Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
available (i.e. Mac OS X), and most files use that. Some files with Mac-only
functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).

Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
to share code between Mac and iOS.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
  • TestWebKitAPI/InjectedBundleController.cpp:
  • TestWebKitAPI/InjectedBundleMain.cpp:
  • TestWebKitAPI/JavaScriptTest.cpp:
  • TestWebKitAPI/PlatformUtilities.cpp:
  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
  • TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
  • TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/Find.cpp:
  • TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
  • TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  • TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
  • TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
  • TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
  • TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
  • TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
  • TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  • TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
  • TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  • TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  • TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
  • TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
  • TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  • TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
  • TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
  • TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
  • TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
  • TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.

(TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
  • TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
  • TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
  • TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.

(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::toSTD):

  • TestWebKitAPI/config.h:
  • TestWebKitAPI/mac/JavaScriptTestMac.mm:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::run): Deleted.
(TestWebKitAPI::Util::sleep): Deleted.
(TestWebKitAPI::Util::toSTD): Deleted.

10:43 Changeset [177505] by dbatyai.u-szeged@partner.samsung.com
  • 2 edits
    2 adds in trunk/Tools

[GTK] Add support for FTL JIT on ARM64
https://bugs.webkit.org/show_bug.cgi?id=139677

Reviewed by Csaba Osztrogonác.

  • gtk/jhbuild-optional.modules:
  • gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
  • gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
10:42 Changeset [177504] by cdumez@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Log navigation types using FeatureCounter API
https://bugs.webkit.org/show_bug.cgi?id=139753

Reviewed by Darin Adler.

Log navigation types using FeatureCounter API.

No new tests, no behavior change other than additional feature
counting.

  • loader/FrameLoader.cpp:

(WebCore::logNavigationWithFeatureCounter):
(WebCore::FrameLoader::loadWithDocumentLoader):

  • platform/FeatureCounterKeys.h:
10:36 Changeset [177503] by cdumez@apple.com
  • 4 edits in trunk/Source/WebCore

Move 'font-weight' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139765

Reviewed by Antti Koivisto.

Move 'font-weight' CSS property to the new StyleBuilder by using
custom code.

No new tests, no behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFontWeight::applyValue): Deleted.
(WebCore::ApplyPropertyFontWeight::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialFontWeight):
(WebCore::StyleBuilderCustom::applyInheritFontWeight):
(WebCore::StyleBuilderCustom::applyValueFontWeight):

10:23 Changeset [177502] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the iOS build after <http://trac.webkit.org/changeset/177486>
(https://bugs.webkit.org/show_bug.cgi?id=139755)

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture): Wrap return value of Range::create() in RefPtr<Range>()
to make the the compiler happy since it wants clauses of the ternary operator to have the same data type
and Ref<Range> object does not support nullptr.
(WebKit::WebPage::selectWordBackward): Substitute Ref::ptr() for PassRefPtr::get().
(WebKit::WebPage::moveSelectionByOffset): Ditto.
(WebKit::WebPage::selectPositionAtPoint): Ditto.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::requestDictationContext): Ditto.
(WebKit::computeAutocorrectionContext): Ditto.

09:44 Changeset [177501] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

Remove timeout from shouldBecome* functions in js-test.js
https://bugs.webkit.org/show_bug.cgi?id=139767

Reviewed by Darin Adler.

r156678 has removed this timeout from shouldBecome* in js-test-pre.js.
Get rid of it from js-test.js as well to make shouldBecome* functions sync
between js-test.js and js-test-pre.js

Additionally, sync minor coding style changes between them.

  • resources/js-test.js:

(_waitForCondition):
(.condition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):
(._condition): Deleted.
(._failureHandler): Deleted.

09:44 Changeset [177500] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

Internals methods return 0 instead of false when they fail
https://bugs.webkit.org/show_bug.cgi?id=139766

Reviewed by Darin Adler.

Some Internals method explicitly return 0 although
they expect boolean value.

No new tests, no behavior change.

  • testing/Internals.cpp:

(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::hasGrammarMarker):
Return false instead of 0.

09:21 Changeset [177499] by cdumez@apple.com
  • 8 edits in trunk/Source/WebCore

[iOS] Log why cached resources are being revalidated using FeatureCounter API
https://bugs.webkit.org/show_bug.cgi?id=139759
<rdar://problem/19288177>

Reviewed by Antti Koivisto.

Log why cached resources are being revalidated using FeatureCounter API.
Also log if revalidation is successful or not.

No new tests, no behavior change.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::mustRevalidateDueToCacheHeaders):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::failBeforeStarting):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::loader):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

  • platform/FeatureCounterKeys.h:
08:33 Changeset [177498] by antti@apple.com
  • 11 edits in trunk/Source

Remove alwaysUseBaselineOfPrimaryFont setting
https://bugs.webkit.org/show_bug.cgi?id=139770

Reviewed by Anders Carlsson.

Source/WebCore:

"FIXME: This is unneeded and should be removed."

This iOS-only setting has no clients anymore.

  • page/Settings.in:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
(-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

07:30 Changeset [177497] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix test expectations after r177363
https://bugs.webkit.org/show_bug.cgi?id=139772

Unreviewed gardening after r177363 - part II

  • platform/efl/TestExpectations:
06:57 Changeset [177496] by commit-queue@webkit.org
  • 9 edits in trunk

[GTK] Implement webkit_web_view_is_playing_audio()
https://bugs.webkit.org/show_bug.cgi?id=138918

Patch by Adrian Perez de Castro <aperez@igalia.com> on 2014-12-18
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Implements webkit_web_view_is_playing_audio(), and overrides
UIClient::isPlayingAudioDidChange() to be able to emit change
notification signals for the new WebKitWebView::is-playing-audio
property.

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(isPlayingAudioDidChange): Added.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewIsPlayingAudioChanged): Helper function to emit the
emit the notify::is-playing-audio signal when needed.
(webkitWebViewGetProperty): Handle the WebKitWebView::is-playing-audio
property.
(webkit_web_view_class_init): Install the
WebKitWebView::is-playing-audio property.
(webkit_web_view_is_playing_audio): Added.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add

webkit_web_view_is_playing_audio() to the list of public API
functions.

Tools:

Add test case case for webkit_web_view_is_playing_audio() and the
WebKitWebView::is-playing-audio property.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(urlForResource): Utility function to get URLs pointing to resources
under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
(testWebViewIsPlayingAudio): Added.
(beforeAll):

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
API tests resources directory, or the WebKit2 C API tests resources
directory. The default value of the flag is to use the WebKit2 GTK
one, to avoid having to change existing tests.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(isPlayingAudioChanged): Added.
(WebViewTest::waitUntilIsPlayingAudioChanged): Added.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
06:41 Changeset [177495] by carlosgc@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit2

[GTK] Allow to build with ENABLE_NETWORK_CACHE
https://bugs.webkit.org/show_bug.cgi?id=139728

Reviewed by Antti Koivisto.

Just make it build for now.

  • CMakeLists.txt: Add new files to compilation.
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry): Use
ENABLE(SHAREABLE_RESOURCE) when ShareableResource is used.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::decodeStorageEntry): Ditto.
(WebKit::makeCacheKey): Use ENABLE(CACHE_PARTITIONING) for ResourceRequest::cachePartition().

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCacheStorage::Data::isNull): Move implementation
to platform specific files.

  • NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::Data::isNull): Moved from the header.

  • NetworkProcess/cache/NetworkCacheStorageSoup.cpp: Added.

(WebKit::NetworkCacheStorage::Data::Data):
(WebKit::NetworkCacheStorage::Data::data):
(WebKit::NetworkCacheStorage::Data::isNull):
(WebKit::NetworkCacheStorage::open):
(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initializeKeyFilter):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::dispatchRetrieveOperation):
(WebKit::NetworkCacheStorage::dispatchPendingRetrieveOperations):
(WebKit::NetworkCacheStorage::retrieve):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::setMaximumSize):
(WebKit::NetworkCacheStorage::clear):

  • PlatformGTK.cmake: Add NetworkCacheStorageSoup.cpp.
  • config.h:
05:41 Changeset [177494] by stavila@adobe.com
  • 29 edits
    1 copy
    34 adds in trunk

[SVG Masking] Enable the use of <mask> elements for -webkit-mask-image
https://bugs.webkit.org/show_bug.cgi?id=139294

Reviewed by Simon Fraser.

Source/WebCore:

This patch links together all parts required for the functionality which improves
the -webkit-mask-image property by allowing it to reference a <mask> element defined
in an inline or external SVG document.
Support for this new functionality has been added in a previous patch, under issue
https://bugs.webkit.org/show_bug.cgi?id=139092. A more detailed description of how
the new functionality works can be found in the ChangeLog for that commit.
The containsSVGDocument in ScrollView has been removed because it was added in the
previous patch but is no longer required.

Tests: css3/masking/mask-base64.html

css3/masking/mask-multiple-values.html
css3/masking/mask-svg-clipped-fragmentId.html
css3/masking/mask-svg-fragmentId.html
css3/masking/mask-svg-inline-fragmentId.html
css3/masking/mask-svg-inline-invalid-fragmentId.html
css3/masking/mask-svg-invalid-fragmentId.html
css3/masking/mask-svg-no-fragmentId-tiled.html
css3/masking/mask-svg-no-fragmentId.html
css3/masking/mask-svg-script-entire-svg-to-mask.html
css3/masking/mask-svg-script-mask-to-entire-svg.html
css3/masking/mask-svg-script-mask-to-none.html
css3/masking/mask-svg-script-mask-to-png.html
css3/masking/mask-svg-script-none-to-mask.html
css3/masking/mask-svg-script-none-to-png.html
css3/masking/mask-svg-script-png-to-mask.html
css3/masking/mask-svg-script-png-to-none.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseMaskImage):

  • css/CSSParser.h:
  • css/CSSValue.h:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustStyleForMaskImages):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createMaskImageOperations):
(WebCore::StyleResolver::loadPendingImages):

  • css/StyleResolver.h:
  • page/FrameView.cpp:

(WebCore::FrameView::containsSVGDocument): Deleted.

  • page/FrameView.h:
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::MaskImagePropertyWrapper::MaskImagePropertyWrapper):
(WebCore::MaskImagePropertyWrapper::equals):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • platform/ScrollView.h:

(WebCore::ScrollView::containsSVGDocument): Deleted.

  • platform/graphics/MaskImageOperation.cpp:

(WebCore::MaskImageOperation::~MaskImageOperation):
(WebCore::MaskImageOperation::operator==):

  • platform/graphics/MaskImageOperation.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::maskClipRect):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::updateFillImages):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerMaskImageInfo.cpp:

(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients):
(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):

  • rendering/RenderLayerMaskImageInfo.h:
  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasImage):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::image):
(WebCore::FillLayer::imageOrMaskImage): Deleted.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setMaskImage):

  • rendering/style/RenderStyle.h:

LayoutTests:

Added tests for different situations using URLs with fragment id
for the -webkit-mask-image property.

  • css3/masking/mask-base64-expected.html: Copied from LayoutTests/css3/masking/mask-repeat-space-padding-expected.html.
  • css3/masking/mask-base64.html: Added.
  • css3/masking/mask-multiple-values-expected.html: Added.
  • css3/masking/mask-multiple-values.html: Added.
  • css3/masking/mask-repeat-space-padding-expected.html:
  • css3/masking/mask-repeat-space-padding.html:
  • css3/masking/mask-svg-clipped-fragmentId-expected.html: Added.
  • css3/masking/mask-svg-clipped-fragmentId.html: Added.
  • css3/masking/mask-svg-fragmentId-expected.html: Added.
  • css3/masking/mask-svg-fragmentId.html: Added.
  • css3/masking/mask-svg-inline-fragmentId-expected.html: Added.
  • css3/masking/mask-svg-inline-fragmentId.html: Added.
  • css3/masking/mask-svg-inline-invalid-fragmentId-expected.html: Added.
  • css3/masking/mask-svg-inline-invalid-fragmentId.html: Added.
  • css3/masking/mask-svg-invalid-fragmentId-expected.html: Added.
  • css3/masking/mask-svg-invalid-fragmentId.html: Added.
  • css3/masking/mask-svg-no-fragmentId-expected.html: Added.
  • css3/masking/mask-svg-no-fragmentId-tiled-expected.html: Added.
  • css3/masking/mask-svg-no-fragmentId-tiled.html: Added.
  • css3/masking/mask-svg-no-fragmentId.html: Added.
  • css3/masking/mask-svg-script-entire-svg-to-mask-expected.html: Added.
  • css3/masking/mask-svg-script-entire-svg-to-mask.html: Added.
  • css3/masking/mask-svg-script-mask-to-entire-svg-expected.html: Added.
  • css3/masking/mask-svg-script-mask-to-entire-svg.html: Added.
  • css3/masking/mask-svg-script-mask-to-none-expected.html: Added.
  • css3/masking/mask-svg-script-mask-to-none.html: Added.
  • css3/masking/mask-svg-script-mask-to-png-expected.html: Added.
  • css3/masking/mask-svg-script-mask-to-png.html: Added.
  • css3/masking/mask-svg-script-none-to-mask-expected.html: Added.
  • css3/masking/mask-svg-script-none-to-mask.html: Added.
  • css3/masking/mask-svg-script-none-to-png-expected.html: Added.
  • css3/masking/mask-svg-script-none-to-png.html: Added.
  • css3/masking/mask-svg-script-png-to-mask-expected.html: Added.
  • css3/masking/mask-svg-script-png-to-mask.html: Added.
  • css3/masking/mask-svg-script-png-to-none-expected.html: Added.
  • css3/masking/mask-svg-script-png-to-none.html: Added.
  • css3/masking/resources/masks.svg: Added.
05:32 Changeset [177493] by clopez@igalia.com
  • 3 edits in trunk/Tools

[GTK] [EFL] Enable per_test_timeout
https://bugs.webkit.org/show_bug.cgi?id=139771

Reviewed by Csaba Osztrogonác.

This is needed to make WKTR use either the default port timeout, or the
user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
Otherwise WTR will use the default (30 seconds after r177363 and r177471).

  • Scripts/webkitpy/port/efl.py:

(EflPort.supports_per_test_timeout): Enabled.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.supports_per_test_timeout): Enabled.

05:15 Changeset [177492] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix test expectations after r177363
https://bugs.webkit.org/show_bug.cgi?id=139772

Unreviewed gardening after r177363 - part I

  • platform/efl/TestExpectations:
04:54 Changeset [177491] by stavila@adobe.com
  • 2 edits in trunk/LayoutTests

animations/cross-fade-webkit-mask-image.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139590

Reviewed by Andrei Bucur.

animations/cross-fade-webkit-mask-image.html became flaky after the way
masks are handled was changed in https://bugs.webkit.org/show_bug.cgi?id=139294.
Marking it flaky for now, pending investigation.

04:16 Changeset [177490] by antti@apple.com
  • 10 edits in trunk

Stop returning GlyphPage from various Font functions
https://bugs.webkit.org/show_bug.cgi?id=139627

Reviewed by Darin Adler.

Source/WebCore:

Make all

std::pair<GlyphData, GlyphPage*> glyphDataAndPage*(...)

style functions to just return GlyphData only. The GlyphPage value was only used for an obscure SVG fallback case.

  • platform/graphics/Font.h:

(WebCore::Font::glyphDataForCharacter):
(WebCore::Font::glyphDataAndPageForCharacter): Deleted.

  • platform/graphics/FontGlyphs.cpp:

(WebCore::glyphDataForCJKCharacterWithoutSyntheticItalic):
(WebCore::glyphDataForNonCJKCharacterWithGlyphOrientation):
(WebCore::FontGlyphs::glyphDataForSystemFallback):
(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForCharacter):
(WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): Deleted.
(WebCore::glyphDataAndPageForNonCJKCharacterWithGlyphOrientation): Deleted.
(WebCore::FontGlyphs::glyphDataAndPageForSystemFallback): Deleted.
(WebCore::FontGlyphs::glyphDataAndPageForVariant): Deleted.
(WebCore::FontGlyphs::glyphDataAndPageForCharacter): Deleted.

  • platform/graphics/FontGlyphs.h:

(WebCore::FontGlyphs::GlyphPagesStateSaver::GlyphPagesStateSaver): Deleted.
(WebCore::FontGlyphs::GlyphPagesStateSaver::~GlyphPagesStateSaver): Deleted.

No longer needed.

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

Simplify by not trying to resolve fallbacks in case context sensitive (based on lang attribute etc)
glyph selection fails. Instead just fall back to a default font. This behavior is not specified
anywhere as far as I can see. (normal non-context sensitive fallbacks will still work fine).
This removes the need to hackishly mutate glyph pages.

Also fix a bug where we didn't use the specified missing glyph when context sensitive selection failed.

LayoutTests:

These are progressions. We now correctly draw the specified missing glyph.

  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • svg/custom/glyph-selection-lang-attribute-expected.txt:
01:55 Changeset [177489] by cdumez@apple.com
  • 4 edits in trunk/Source/WebCore

Move 'list-style-image' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139763

Reviewed by Antti Koivisto.

Move 'list-style-image' CSS property to the new StyleBuilder
by reusing an existing Converter helper and renaming it for
clarity.

No new tests, no behavior change.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyStyleImage::applyValue): Deleted.
(WebCore::ApplyPropertyStyleImage::createHandler): Deleted.

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertStyleImage):
(WebCore::StyleBuilderConverter::convertBorderImageSource): Deleted.

12/17/14:

23:14 Changeset [177488] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

URTBF after r177452.
https://bugs.webkit.org/show_bug.cgi?id=139752

  • CMakeLists.txt:
19:15 Changeset [177487] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Unreviewed build fix.

  • public/v2/index.html: Include js files we extracted in r177424.
19:06 Changeset [177486] by akling@apple.com
  • 13 edits in trunk/Source

Ref-ify Range::create().
<https://webkit.org/b/139755>

Reviewed by Anders Carlsson.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::acceptsEditingFocus):

  • dom/Element.cpp:

(WebCore::Element::innerText):

  • dom/Range.cpp:

(WebCore::Range::create):
(WebCore::Range::cloneRange):
(WebCore::rangeOfContents):

  • dom/Range.h:
  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::applyAlternativeTextToRange):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):

  • editing/VisibleUnits.cpp:

(WebCore::charactersAroundPosition):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::renderedText):

  • page/FocusController.cpp:

(WebCore::relinquishesEditingFocus):

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView attributedString]):

18:12 Changeset [177485] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Unify -[WebResource description]
https://bugs.webkit.org/show_bug.cgi?id=139762

Reviewed by Dan Bernstein.

  • WebView/WebResource.mm:

(-[WebResource description]):

18:09 Changeset [177484] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit/mac

Get rid of an ugly #define hack in WebFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=139761

Reviewed by Dan Bernstein.

Also replace @private with @package in all public headers, for consistency.

  • History/WebBackForwardList.h:
  • History/WebHistory.h:
  • Misc/WebDownload.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.h:
  • WebView/WebDataSource.h:
  • WebView/WebFrame.h:
  • WebView/WebFrameView.h:
  • WebView/WebPreferences.h:
  • WebView/WebResource.h:
18:02 Changeset [177483] by mitz@apple.com
  • 6 edits in trunk/Source

<rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
https://bugs.webkit.org/show_bug.cgi?id=139760

Reviewed by Anders Carlsson.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

  • Configurations/WebKit2.xcconfig:
17:56 Changeset [177482] by andersca@apple.com
  • 5 edits in trunk/Source

Get rid of FrameLoader::defaultObjectContentType
https://bugs.webkit.org/show_bug.cgi?id=139758

Reviewed by Geoffrey Garen.

Source/WebCore:

Move the FrameLoader::defaultObjectContentType implementation to its only caller in WebKit/win.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultObjectContentType): Deleted.

  • loader/FrameLoader.h:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::objectContentType):

17:29 Changeset [177481] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.13.2

New tag.

17:25 Changeset [177480] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.13-branch/Source/WebCore

Merged build fix for r177375. rdar://problem/19271256

17:05 Changeset [177479] by bshafiei@apple.com
  • 3 edits in branches/safari-600.1.4.13-branch/Source/WebCore

Merged patch for r177375. rdar://problem/19271256

16:33 Changeset [177478] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r177473. rdar://problems/19286550

16:25 Changeset [177477] by matthew_hanson@apple.com
  • 27 edits in branches/safari-600.3-branch/Source

Merge r177427. rdar://problem/19237945

16:25 Changeset [177476] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.3-branch/Source/WebKit2

Merged r177411. rdar://problems/19271854

16:25 Changeset [177475] by matthew_hanson@apple.com
  • 4 edits
    1 add in branches/safari-600.3-branch/Source

Merged r177409. rdar://problems/19271854

16:25 Changeset [177474] by matthew_hanson@apple.com
  • 7 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r177402. rdar://problem/19266297

16:15 Changeset [177473] by bdakin@apple.com
  • 2 edits in trunk/Source/WebKit2

Page previews are sometimes sized much smaller than it seems they should be
https://bugs.webkit.org/show_bug.cgi?id=139754
-and corresponding-
rdar://problem/19286550

Reviewed by Tim Horton.

Increase the minimum size and add in a missing else!!

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _preferredPopoverSizeWithPreviewPadding:]):

16:00 Changeset [177472] by lforschler@apple.com
  • 2 edits in trunk/Tools

Move Apple buildbot slaves to their new home.

Reviewed by Roger Fong.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
15:57 Changeset [177471] by ap@apple.com
  • 7 edits in trunk/Tools

REGRESSION (r177363): Gtk and Efl testing is broken
https://bugs.webkit.org/show_bug.cgi?id=139734

Reviewed by Simon Fraser.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init): Remove timeout adjustment from here, because it
affected both script and tool timeout. This is still the right place for this logic,
but it would be a larger refactoring than I can do right now.

  • Scripts/webkitpy/port/base.py:

(Port.supports_per_test_timeout): Added a FIXME.
(Port.default_timeout_ms): Now that the effective timeout is longer, change this
to avoid making tests take more time.

  • Scripts/webkitpy/port/driver.py:

(Driver.run_test): Adjust script timeout here.
(Driver._check_for_driver_timeout): Fix the timeout detection.
(Driver._read_block): Actually use the timeout detection code.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):

Use TestRunner default timeout when there isn't a timeout passed from command line for the test.

  • Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):

Update results for the new default.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_hung_thread): Restore a test that I previously deleted, it was
actually a good one.

15:45 Changeset [177470] by matthew_hanson@apple.com
  • 1 move in tags/Safari-600.1.17.5

Correct tag name.

15:23 Changeset [177469] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Ref-ify WebPageProxy and WebProcessProxy creation functions
https://bugs.webkit.org/show_bug.cgi?id=139751

Reviewed by Andreas Kling.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
15:16 Changeset [177468] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed iOS Build Fix after r177459.

  • UIProcess/ios/WebInspectorProxyIOS.mm:

(WebKit::WebInspectorProxy::platformInvalidate):
(WebKit::WebInspectorProxy::platformHide):
Add missing WebInspectorProxy platform methods.

15:05 Changeset [177467] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.17-branch/Source

Versioning.

14:30 Changeset [177466] by matthew_hanson@apple.com
  • 1 copy in tags/safari-600.1.17.5

New Tag.

14:25 Changeset [177465] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.1.17-branch/Source

Merged r177448. rdar://problems/19281928

14:24 Changeset [177464] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Unreviewed, rolling out r177456.
https://bugs.webkit.org/show_bug.cgi?id=139749

Broke webkitpy and Mac tests (Requested by ap on #webkit).

Reverted changeset:

"REGRESSION (r177363): Gtk and Efl testing is broken"
https://bugs.webkit.org/show_bug.cgi?id=139734
http://trac.webkit.org/changeset/177456

13:56 Changeset [177463] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Define button and action should respect profile settings.
https://bugs.webkit.org/show_bug.cgi?id=139739
rdar://problem/15461887

Reviewed by Joseph Pecoraro.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView _define:]):

13:49 Changeset [177462] by dbates@webkit.org
  • 3 edits
    304 adds in trunk/LayoutTests

[iOS] More test gardening

  • platform/ios-simulator-wk2/TestExpectations:

[...]

13:41 Changeset [177461] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-601.1.12.3/Source

Versioning.

13:38 Changeset [177460] by msaboff@apple.com
  • 4 edits
    3 adds in trunk

Tests with infinite recursion frequently crash
https://bugs.webkit.org/show_bug.cgi?id=139548

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

While unwinding, if the call frame doesn't have a codeblock, then we
are in native code, handle appropriately.

  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::UnwindFunctor::operator()):
Added checks for null CodeBlock.

(JSC::Interpreter::unwind): Removed wrong ASSERT.

LayoutTests:

New test that exercises the various places that we do stack overflow checks.

  • TestExpectations:
  • js/regress-139548-expected.txt: Added.
  • js/regress-139548.html: Added.
  • js/script-tests/regress-139548.js: Added.

(ToStringObj):
(ToStringObj.prototype.toString):
(makeArgsArray):
(recurseNoDFG):
(recurse):
(probeAndRecurse):

13:19 Changeset [177459] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

Web Inspector: [Mac] Occosional Crashes Closing Inspector
https://bugs.webkit.org/show_bug.cgi?id=139740

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-17
Reviewed by Timothy Hatcher.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent):
The WebPageProxy could have gotten destroyed in handling (e.g. keyboard shortcut
to close the Inspector Window), so protect the object to avoid destruction
during handling.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebPageProxy.cpp:

Add platformInvalidate opportunity for the platform to do invalidation work.

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformInvalidate):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformInvalidate):
Empty implementations, these ports do not need to do anything.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::closeTimerFired):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformInvalidate):
When closing / invalidating make sure we close the WKView to clear client
for any delayed callbacks.

13:15 Changeset [177458] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] Compile error, setWasCached method has been removed.
https://bugs.webkit.org/show_bug.cgi?id=139737

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-17
Reviewed by Alex Christensen.

The ResourceResponseBase::setWasCached() method has been replaced
with ResourceResponseBase::setSource().

  • platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):

13:08 Changeset [177457] by matthew_hanson@apple.com
  • 3 edits
    1 add in tags/Safari-601.1.12.3/Source/JavaScriptCore

Merged r177270. rdar://problems/19245579

13:03 Changeset [177456] by ap@apple.com
  • 5 edits in trunk/Tools

REGRESSION (r177363): Gtk and Efl testing is broken
https://bugs.webkit.org/show_bug.cgi?id=139734

Reviewed by Simon Fraser.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init): Remove timeout adjustment from here, because it
affected both script and tool timeout. This is still the right place for this logic,
but it would be a larger refactoring than I can do right now.

  • Scripts/webkitpy/port/base.py:

(Port.supports_per_test_timeout): Added a FIXME.
(Port.default_timeout_ms): Now that the effective timeout is longer, change this
to avoid making tests take more time.

  • Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):

Use TestRunner default timeout when there isn't a timeout passed from command line for the test.

13:03 Changeset [177455] by cdumez@apple.com
  • 22 edits
    3 moves in trunk/Source

[iOS] Make it possible to toggle FeatureCounter support at runtime
https://bugs.webkit.org/show_bug.cgi?id=139688
<rdar://problem/19266254>

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Stop linking against AppSupport framework as the functionality is no
longer in WTF (it was moved to WebCore).

  • Configurations/JavaScriptCore.xcconfig:

Source/WebCore:

Make it possible to toggle FeatureCounter support at runtime by adding
a setting (disabled by default) and moving the API to a new
FeatureCounter class under WebCore/plattorm which only logs if the
setting is enabled. For privacy reasons, FeatureCounter logging is also
disabled for private / ephemeral sessions.

No new tests, no behavior change.

  • CMakeLists.txt:
  • Configurations/WebCore.xcconfig:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):

  • page/Settings.in:
  • platform/FeatureCounter.cpp: Renamed from Source/WTF/wtf/FeatureCounter.cpp.

(WebCore::FeatureCounter::shouldUseForPage):
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

  • platform/FeatureCounter.h: Renamed from Source/WTF/wtf/FeatureCounter.h.
  • platform/FeatureCounterKeys.h:
  • platform/ios/FeatureCounter.mm: Renamed from Source/WTF/wtf/ios/FeatureCounter.mm.

(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

Source/WebKit2:

Add private settings API to toggle FeatureCounter support on Safari and
MobileSafari.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetFeatureCounterEnabled):
(WKPreferencesGetFeatureCounterEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _featureCounterEnabled]):
(-[WKPreferences _setFeatureCounterEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WTF:

Remove FeatureCounter API from WTF and move it to WebCore/platform
instead so that it can log conditionally based on a WebCore setting.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
12:57 Changeset [177454] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-601.1.12.3

New Tag.

12:32 Changeset [177453] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Clean up SQL statement building in SQLiteIDBCursor
https://bugs.webkit.org/show_bug.cgi?id=139741

Reviewed by Andreas Kling.

This vastly simplifies the code and gets rid of the last
uses of DEPRECATED_DEFINE_STATIC_LOCAL in WebKit2.

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::buildIndexStatement):
(WebKit::buildObjectStoreStatement):
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::getIndexStatement): Deleted.
(WebKit::getObjectStoreStatement): Deleted.

12:26 Ruby edited by mmaxfield@apple.com
(diff)
12:24 8.png attached to Ruby by mmaxfield@apple.com
12:13 7.png attached to Ruby by mmaxfield@apple.com
12:10 6.png attached to Ruby by mmaxfield@apple.com
12:10 Changeset [177452] by andersca@apple.com
  • 5 edits
    1 delete in trunk/Source/WebCore

Get rid of PluginPackageNone.cpp
https://bugs.webkit.org/show_bug.cgi?id=139735

Reviewed by Andreas Kling.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformWin.cmake:
  • plugins/PluginPackageNone.cpp: Removed.
12:09 Changeset [177451] by bfulgham@apple.com
  • 3 edits in trunk/WebKitLibraries

[Win] Unreviewed build fix (for full build)

  • win/tools/vsprops/FeatureDefines.props: Add missing export so the

derived sources are generated properly.

  • win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
12:07 Ruby edited by mmaxfield@apple.com
Pictures! (diff)
12:01 5.png attached to Ruby by mmaxfield@apple.com
11:55 4.png attached to Ruby by mmaxfield@apple.com
11:40 3.png attached to Ruby by mmaxfield@apple.com
11:39 Changeset [177450] by akling@apple.com
  • 12 edits in trunk/Source

Purge PassRefPtr from Frame.
<https://webkit.org/b/139731>

Reviewed by Anders Carlsson.

Source/WebCore:

Remove all use of PassRefPtr from the Frame class, instead using
Ref or RefPtr as appropriate.

  • WebCore.exp.in:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • page/Frame.cpp:

(WebCore::Frame::create):
(WebCore::Frame::setView):
(WebCore::Frame::setDocument):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::createView):

  • page/Frame.h:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebView/WebFrame.mm:

(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
(+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):

  • WebView/WebFrameInternal.h:

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSubframe):

11:37 2.png attached to Ruby by mmaxfield@apple.com
11:35 1.png attached to Ruby by mmaxfield@apple.com
11:28 Ruby edited by mmaxfield@apple.com
(diff)
11:23 Ruby edited by mmaxfield@apple.com
(diff)
11:22 Ruby created by mmaxfield@apple.com
11:20 WikiStart edited by mmaxfield@apple.com
(diff)
10:56 Changeset [177449] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Test fix after r177444.

Unreviewed.

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):

10:26 Changeset [177448] by bfulgham@apple.com
  • 6 edits in trunk/Source

[Win] Correct DebugSuffix builds under MSBuild
https://bugs.webkit.org/show_bug.cgi?id=139733
<rdar://problem/19276880>

Reviewed by Simon Fraser.

../JavaScriptCore:

'_debug' suffix when building the DebugSuffix target.

../WebKit:

  • WebKit.vcxproj/WebKit.proj: Make sure to use the '_debug' suffix

when building the DebugSuffix target.

../WTF:

  • WTF.vcxproj/WTF.proj: Make sure to use the '_debug' suffix

when building the DebugSuffix target.

10:12 Changeset [177447] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

iOS build fix

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClient::setTextIndicatorAnimationProgress):

09:46 Changeset [177446] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[Win] Link errors.
https://bugs.webkit.org/show_bug.cgi?id=139729

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-17
Reviewed by Anders Carlsson.

The list of exported symbols needs to be updated.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
09:02 Changeset [177445] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Make Ref::copyRef const and ref-qualified
https://bugs.webkit.org/show_bug.cgi?id=139730

Reviewed by Andreas Kling.

  • wtf/Ref.h:
08:33 Changeset [177444] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Addressing more post-review comments in r177035

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

04:03 Changeset [177443] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=139725

Reviewed by Martin Robinson.

The timeout is already in milliseconds, so we don't need to do any conversion.

  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

03:44 Changeset [177442] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[TexMap] Sprinkle range-based for-loops where still possible
https://bugs.webkit.org/show_bug.cgi?id=138752

Reviewed by Chris Dumez.

Apply range-based for-loops where possible in the TextureMapper,
TextureMapperGL and TextureMapperTiledBackingStore classes.

Also prettify the loop in SharedGLData destructor and return
nullptr instead of explicitly constructing the empty PassRefPtr
object in TextureMapperTiledBackingStore::texture().

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::BitmapTexturePool::acquireTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::~TextureMapperGLData):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):

02:14 Changeset [177441] by stavila@adobe.com
  • 2 edits in trunk/Source/WebCore

The SVGDocument of an SVGImage should not perform any additional actions when the SVGImage is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=139644

Reviewed by Antti Koivisto.

When an SVGImage is destroyed, having its SVGDocument perform style recalc and dispatching events is not only
useless but can also cause problems, such as re-entrancy in StyleResolver::loadPendingResources.

No new tests required, existing tests cover this change.

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::isBeingDestroyed):
(WebCore::Document::setIsBeingDestroyed):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeURL):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::~SVGImage):

01:51 Changeset [177440] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build after r177427.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setTextIndicatorAnimationProgress):

  • UIProcess/API/gtk/PageClientImpl.h:
00:45 Changeset [177439] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL]Fix build warning in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=139723

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-12-17
Reviewed by Darin Adler.

The warning is caused by the compiler wanting the first argument to be a
string literal, not a dynamically created string.

  • MiniBrowser/efl/main.c:

(quit):

00:28 Changeset [177438] by bshafiei@apple.com
  • 3 edits in branches/safari-600.1.4.13-branch/Source/WebKit2

Merged r176996. rdar://problem/19214044

00:27 Changeset [177437] by bshafiei@apple.com
  • 3 edits in branches/safari-600.1.4.13-branch/Source/WebKit2

Merged r176133. rdar://problem/19214044

00:03 Changeset [177436] by cdumez@apple.com
  • 4 edits in trunk/Source/WebCore

Drop useless 'clipToContents' argument for windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=139722

Reviewed by Darin Adler.

Drop useless 'clipToContents' argument for windowClipRect(). This
argument is never used.

No new tests, no behavior change.

  • page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):

  • page/FrameView.h:
  • platform/ScrollView.h:
Note: See TracTimeline for information about the timeline view.