Timeline
Dec 25, 2002:
- 7:42 PM Changeset in webkit [3187] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
- fixed 3133611 -- Java "ticker" applet renders badly when scrolling page
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewHasMoved:]): Call setWindow so we make a call to the plugin each time it moves, rather than just adjusting the data structure we had passed to it earlier.
- 12:09 PM Changeset in webkit [3186] by
-
- 3 edits in trunk/WebCore
Fix for 3134543 (and widely reported dupes). Don't use render_text
widths cache except for whitespace == PRE. The problem was that additional
spaces in the RenderText's string were being inappropiately measured.
An alternate, more complex and risky, fix would account for the whitespace
properties during scanning of the RenderText width buffer. Considering
the scenario for which this optimization was added (3133261), this
simpler fix is adequate.
Reviewed by Darin and Don.
- khtml/rendering/render_text.cpp: (RenderText::computeWidths):
Dec 24, 2002:
- 2:51 PM Changeset in webkit [3185] by
-
- 3 edits in trunk/WebCore
Reviewed by Don.
- fixed 3135010 -- nil-dereference in KHTMLPart::xmlDocImpl() at channels.netscape.com
- khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentDocument): Add missing nil check. Also added lots of FIXME comments about problems I observed here.
- 11:49 AM Changeset in webkit [3184] by
-
- 2 edits in trunk/WebKit
Reviewed by Richard and Don.
- fixed 3132192 -- HOMEPAGE: Quicktime plug in with AVI content brings Plug-ins not found panel
- Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Lower-case the key before searching for it. This is needed for both MIME types and extensions, since we want case insensitive comparison in both cases.
- 11:48 AM Changeset in webkit [3183] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard and Don.
- fixed 3133207 -- crash in HTMLFrameElementImpl updateForNewURL at home.real.com
My previous attempt to fix this dealt with the case where a RenderFrame object was
not yet created, but not with the case where a RenderFrame object was created without
a corresponding part. Somehow I overlooked this last time when I was doing testing.
Testing this time confirms this takes care of the remaining problem at movies.real.com.
- khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Use the same kind of requestFrame call here as in attach when there's a RenderFrame, but no corresponding part. Maybe we can fix this an even more elegant way later.
Dec 23, 2002:
- 3:55 PM Changeset in webkit [3182] by
-
- 3 edits in trunk
Alexander 46u commit
- 3:49 PM Changeset in webkit [3181]
-
- 3 copies in tags/Alexander-45
This commit was manufactured by cvs2svn to create tag 'Alexander-45'.
- 3:49 PM Changeset in webkit [3180] by
-
- 8 edits in trunk
Building Alex-45
- 3:23 PM Changeset in webkit [3179] by
-
- 1 edit in trunk/WebKit/ChangeLog
Reviewed by me
Fixed ChangeLog typos in previous commit.
- ChangeLog
- 3:20 PM Changeset in webkit [3178] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin and Gramps
Workaround for this bug:
Radar 3134219 (MPEG-4 files don't work with the QuickTime plugin in Safari,
work fine in Mozilla, IE)
For beta 1, we For beta 1, when getting the MIME information for the QuickTime
plugin, we directly insert the information to handle MP4.
In the future, we will use the additional plugin entry points to dynamically load
this information from the plugin itself.
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getMIMEInformation])
- 2:35 PM Changeset in webkit [3177] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Don and John.
- fixed 3134449 -- Date.UTC returns NaN (invalid date)
Did more testing of the date functions and made them behave like the other browsers.
There were three problems:
1) We did a validity check that other browsers don't do (hence the NaN).
2) We treated passed-in dates as local time even in Date.UTC (hence a wrong result
once I fixed the NaN).
3) The results of ToUTCString (and ToGMTString) weren't formatted quite the same
as other browsers.
Also found a couple of silly but unrelated coding mistakes.
- kjs/date_object.cpp: (timetUsingCF): Added. Has the guts of mktimeUsingCF, but without the CFGregorianDateIsValid check. Other browsers accept invalid dates. Also takes a time zone parameter. (mktimeUsingCF): Calls timetUsingCF with the current time zone. (timegmUsingCF): Calls timetUsingCF with the UTC time zone. (formatDate): Remove the includeComma flag. (formatDateUTCVariant): Added. For use instead of formatDate with the includeComma flag. Puts the day before the month name. (DateProtoFuncImp::call): Use the new formatDateUTCVariant for ToGMTString and ToUTCString. Without this change the date didn't match other browsers. (DateObjectImp::DateObjectImp): Use UTCPropertyName. Somehow I declared this and didn't use it before. (DateObjectImp::construct): Pass -1 for is_dst literally instead of using invalidDate. Changing this to invalidDate was just a mistake (although no real difference in compiled code since invalidDate is just -1). (DateObjectFuncImp::call): Call timegm for the UTC case instead of mktime.
- 2:34 PM Changeset in webkit [3176] by
-
- 3 edits in trunk/WebKit
Reviewed by John and Don.
- fixed 3134282 -- REGRESSION: text encoding setting reverts when you go to a new location
- WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): Propagate an override encoding if there was an existing data source and it had an override encoding.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadRequest:triggeringAction:loadType:]): Ditto.
- 11:57 AM Changeset in webkit [3175] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed 3134558 -- REGRESSION: Lord of the Rings site problems
This regression was caused when we fixed the abcnews.com problem (3124933).
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument): Despite its name, this function was never intended to overwrite an existing document with an empty document. When we changed it do do the creation in a better way, we lost the check that prevents it from doing anything at all if we already have a document.
- 11:57 AM Changeset in webkit [3174] by
-
- 3 edits in trunk/WebCore
Reviewed by NOBODY (OOPS!).
- fixed 3134558 -- REGRESSION: Lord of the Rings site problems
This regression was caused when we fixed the abcnews.com problem (3124933).
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument): Despite its name, this function was never intended to overwrite an existing document with an empty document. When we changed it do do the creation in a better way, we lost the check that prevents it from doing anything at all if we already have a document.
Dec 22, 2002:
- 10:35 PM Changeset in webkit [3173] by
-
- 2 edits in trunk/WebCore
Reviewed by Don.
- fixed 3134383 -- crash in KWQKHTMLPart::canCachePage at www.apple.com
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Check for nil in the result of Window::retrieveWindow.
- 10:34 PM Changeset in webkit [3172] by
-
- 3 edits in trunk/WebCore
Reviewed by NOBODY (OOPS!).
- fixed 3134383 -- crash in KWQKHTMLPart::canCachePage at www.apple.com
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Check for nil in the result of Window::retrieveWindow.
