Timeline


and

01/13/03:

19:33 Changeset [3317] by mjs
  • 3 edits in branches/Alexander-48-branch/JavaScriptCore

Reviewed by Darin.

  • made minor tweaks to work better with Mozilla's JavaScript tests.
  • kjs/testkjs.cpp: (VersionFunctionImp::call): Implemented (main): Ignore files named -f (hack to match -f <filename syntax that moz JavaScript tests expect). Also use return code 3 instead of 1 for uncaught exception.
18:02 Changeset [3316] by cblu
  • 7 edits
    4 adds in trunk/WebKit

WebFoundation:

Fix for checking and creating proper download filenames.

Reviewed by mjs, kocienda, trey.

  • CacheLoader.subproj/WebResourceResponse.h:
  • CacheLoader.subproj/WebResourceResponse.m: removed the filename method. That is now a category in WebKit
  • CacheLoader.subproj/WebResourceResponsePrivate.h:
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_filenameByFixingIllegalCharacters]): new, turns "/" into "-", strips leading dots
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]): don't parse out the content disposition. This is done in WebKit.

WebKit:

Fix for checking and creating proper download filenames.

Reviewed by mjs, kocienda, trey.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPolicyDelegate.h: changes for renamed savePathForResponse:andRequest: method
  • WebView.subproj/WebDefaultPolicyDelegate.m: changes for renamed savePathForResponse:andRequest: method (-[WebDefaultPolicyDelegate savePathForResponse:andRequest:]): renamed
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): changes for renamed savePathForResponse:andRequest: method

WebBrowser:

Fix for checking and creating proper download filenames.

Reviewed by mjs, kocienda, trey.

  • BrowserDocument.m: (-[BrowserDocument pageName]): call _web_filenameByFixingIllegalCharacters on the web page title when saving the document
  • BrowserWebController.m: (-[BrowserWebController savePathForResponse:andRequest:]): renamed, removed temporary that checks for invalid filename. That work is done in WebKit.
  • HTMLSourceDocument.m: (-[HTMLSourceDocument displayName]): call suggestedFilenameForSaving
10:27 Changeset [3315] by darin
  • 3 edits in trunk/JavaScriptCore
  • kjs/ustring.h: Fix spelling of occurrence.
09:38 Changeset [3314] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3143781 -- submitting the same form twice doesn't work properly (example at directory.apple.com)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Only run the "don't submit the same form twice" logic when the form is one that affects the frame that the form is in.
07:49 Changeset [3313] by darin
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • turned more recursion into iteration, and fixed some backwards stuff
  • kjs/grammar.y: Use the normal idiom for CaseClauses and FormalParameterList rather than using append().
  • kjs/grammar.cpp: Regenerated.
  • kjs/nodes.h: Change ClauseListNode and ParameterNode to use the normal idiom, and got rid of append methods. Also added friend declarations and calls to reverseList().
  • kjs/nodes.cpp: (StatListNode::ref): Iteration, not recursion. (StatListNode::deref): Iteration, not recursion. (StatListNode::execute): Iteration, not recursion. (StatListNode::processVarDecls): Iteration, not recursion. (CaseClauseNode::reverseList): Added. (ClauseListNode::ref): Iteration, not recursion. (ClauseListNode::deref): Iteration, not recursion. (ClauseListNode::processVarDecls): Iteration, not recursion. (CaseBlockNode::reverseLists): Added. (ParameterNode::ref): Iteration, not recursion. (ParameterNode::deref): Iteration, not recursion. (FuncDeclNode::reverseParameterList): Added. (FuncExprNode::reverseParameterList): Added. (SourceElementsNode::ref): Iteration, not recursion. (SourceElementsNode::deref): Iteration, not recursion. (SourceElementsNode::execute): Use variable name of n to match other functions. (SourceElementsNode::processFuncDecl): Ditto. (SourceElementsNode::processVarDecls): Ditto.
  • kjs/nodes2string.cpp: (SourceStream::operator<<): Used a switch statement for a bit of added clarity. (ElementNode::streamTo): Iteration, not recursion. (PropertyValueNode::streamTo): Iteration, not recursion. (ArgumentListNode::streamTo): Iteration, not recursion. (StatListNode::streamTo): Iteration, not recursion, and fixed order. (VarDeclListNode::streamTo): Iteration, not recursion. (ClauseListNode::streamTo): Used for statement to match other functions. (CaseBlockNode::streamTo): Used for statement to match other functions. (ParameterNode::streamTo): Iteration, not recursion. (SourceElementsNode::streamTo): Iteration, not recursion, and fixed order that has been backwards since I changed how this works in nodes.cpp.

01/12/03:

21:53 Changeset [3312] by darin
  • 4 edits in trunk/WebCore
  • WebCorePrefix.h: Needed to touch this file since we now have plain C source (expat).
  • kwq/KWQKHTMLPart.cpp: Reformatted a bit.
21:30 Changeset [3311]
  • 4 copies
    24 deletes in tags/EXPAT_1_95_5

This commit was manufactured by cvs2svn to create tag 'EXPAT_1_95_5'.

21:30 Changeset [3310] by darin
  • 3 edits in branches/expat/WebCore/expat/lib

Check in files that I had modified from expat 1.95.5.

21:28 Changeset [3309]
  • 1 copy
    24 deletes in branches/expat

This commit was manufactured by cvs2svn to create branch 'expat'.

21:28 Changeset [3308] by darin
  • 4 edits
    23 adds in trunk/WebCore

Reviewed by Maciej.

  • first step towards integrating expat for XML support: make it compile and link
  • kwq/KWQXml.mm: (QXmlSimpleReader::parse): Put in a placeholder that calls expat. Mainly just used to make sure we link.
  • WebCore.pbproj/project.pbxproj: Added expat files.
  • expat/COPYING: Added.
  • expat/Changes: Added.
  • expat/MANIFEST: Added.
  • expat/README: Added.
  • expat/expat_config.h: Added.
  • expat/lib/ascii.h: Added.
  • expat/lib/asciitab.h: Added.
  • expat/lib/expat.h: Added.
  • expat/lib/iasciitab.h: Added.
  • expat/lib/internal.h: Added.
  • expat/lib/latin1tab.h: Added.
  • expat/lib/nametab.h: Added.
  • expat/lib/utf8tab.h: Added.
  • expat/lib/xmlparse.c: Added.
  • expat/lib/xmlrole.c: Added.
  • expat/lib/xmlrole.h: Added.
  • expat/lib/xmltok.c: Added.
  • expat/lib/xmltok.h: Added.
  • expat/lib/xmltok_impl.c: Added.
  • expat/lib/xmltok_impl.h: Added.
  • expat/lib/xmltok_ns.c: Added.
19:49 Changeset [3307] by darin
  • 12 edits in trunk/WebKit

Reviewed by John.

  • fixed 3144882 -- pretend to be WinIE for abcnews.com
  • WebView.subproj/WebControllerPrivate.h: Add an enum, UserAgentStringType, with values Safari, MacIE, and WinIE. Also add NumUserAgentStringTypes and turn the userAgent and userAgentWhenPretendingToBeMacIE strings into an array indexed by type.
  • WebView.subproj/WebController.m: (-[WebController setApplicationNameForUserAgent:]): Use a loop to discard the user agent strings, since we have an array now. (-[WebController userAgentForURL:]): Change user agent algorithm to check two strings rather than once against the spoof table, allowing two dots in the "domain name", which is needed for "abcnews.go.com". Get a user agent string type from the table rather than just a boolean "pretend to be MacIE". Store a string per type rather than one for normalcy and one for MacIE. Add a case for WinIE to the user agent computations.
  • English.lproj/StringsNotToBeLocalized.txt: Update for change above.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Use a loop to discard the user agent strings, since we have an array now. (-[WebController _defaultsDidChange]): Ditto.
  • WebView.subproj/WebUserAgentSpoofTable.gperf: Add a UserAgentStringType field to the struct. Add MacIE to each existing table entry, and add a new one that says WinIE for abcnews.go.com.
  • Makefile.am: Pass "-F ,0" to gperf so that we don't get warnings compiling empty entries in the hash table.
  • WebView.subproj/WebUserAgentSpoofTable.c: Re-generated.
  • other changes
  • WebView.subproj/WebHTMLView.m: Removed some old, dead, #if 0'd code.
10:43 Changeset [3306] by darin
  • 9 edits in trunk/JavaScriptCore

Reviewed by John.

  • changes inspired by things I noticed reviewing diffs vs. KDE when preparing the tarball
  • kjs/function.cpp: (GlobalFuncImp::call): Use strtol when strtoll is not available. Do #ifndef NDEBUG, not #if !NDEBUG.
  • kjs/function.h: Do #ifndef NDEBUG, not #if !NDEBUG.
  • kjs/internal.cpp: (InterpreterImp::initGlobalObject): Do #ifndef NDEBUG, not #if !NDEBUG. (KJS::printInfo): Remove case for ListType and remove default case that just ends up suppressing the "missing case" warning and does no good.
  • kjs/interpreter.cpp: (Interpreter::evaluate): Do #ifndef NDEBUG, not #if !NDEBUG.
  • kjs/nodes.cpp: (Node::finalCheck): Fix accidentally-deleted code in an ifdef we never compile. (FunctionCallNode::evaluate): Remove bogus XXX comment. Maciej put this comment in, and together we determined it's not needed. (TypeOfNode::evaluate): Ditto.
  • kjs/object.cpp: Remove assert that refers to ListType.
  • kjs/value.h: Remove ListType.
10:41 Changeset [3305] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • minor cleanup of plug-in-related classes in ECMA directory
  • khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions ref() and deref(). Instead just make Plugin and MimeType both derive from PluginBase and remove APPLE_CHANGES. (Navigator::getValueProperty): Don't use "Konqueror" for the fallback. Just return Undefined() for that case since we will never reach it anyway.
  • simplify the logic in khtmlMoveMouseEvent so it's easier to decipher
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two identical if statements, the logic of this function becomes much clearer.
09:05 Changeset [3304] by darin
  • 6 edits in trunk/WebCore

Reviewed by Dave.

  • fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
  • khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
  • khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): Changed !x == y to x != y. In each case, there's a reason that this does not create any problem in practice, which is why we didn't rush to get this in for beta 1.
09:01 Changeset [3303] by darin
  • 7 edits in trunk/WebCore

Reviewed by John.

  • fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
  • khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than waiting until the parser is destroyed. This fixes the bug because when the parser is destroyed, the document is already destroyed, so we have a dangling current pointer to an already-destroyed node.
  • fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer

The bug was caused by an erroneous clicked signal that was being emitted by
QListBox at just the wrong time.

  • kwq/KWQListBox.h: Added _changingSelection boolean.
  • kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false. (QListBox::setSelected): Set _changingSelection to true. (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked" signal if _changingSelection is false.
  • khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false. (HTMLTokenizer::write): Set inWrite to true. (HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.

01/11/03:

21:13 Changeset [3302] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • fixed 3144479 -- put TITLE from links in status bar
  • WebKit.exp: Add _WebElementLinkTitleKey and also sort this file.
  • WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above to have any effect, so update the copyright date here.
17:17 Changeset [3301] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3136944 -- mouseover feedback over non-mapped part of image map claims link to current page
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct from an empty ATTR_HREF). Did a similar cleanup on the image code.

01/10/03:

00:20 Changeset [3300] by darin
  • 11 edits in trunk

JavaScriptCore:

  • JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass.
  • English.lproj/InfoPlist.strings: Updated to match above changes.

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass.
  • English.lproj/InfoPlist.strings: Update to match above.

WebCore:

  • WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL that was in the Info plist instead of project settings.
  • English.lproj/InfoPlist.strings: Update to match above.

WebKit:

  • WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass.
  • English.lproj/InfoPlist.strings: Updated to match above changes.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions to 0.8.1 and 52u to keep up with the branch.
  • English.lproj/InfoPlist.strings: Update to match above.

01/09/03:

23:08 Changeset [3299]
  • 16 copies in tags/Alexander-51

This commit was manufactured by cvs2svn to create tag 'Alexander-51'.

23:08 Changeset [3298] by kocienda
  • 5 edits in branches/Alexander-48-branch

Setting version to Alexander-51

22:44 Changeset [3297] by darin
  • 3 edits in branches/Alexander-48-branch

Version fixes for 51.

20:01 Changeset [3296]
  • 16 copies in tags/Alexander-50

This commit was manufactured by cvs2svn to create tag 'Alexander-50'.

20:01 Changeset [3295] by sheridan
  • 8 edits in branches/Alexander-48-branch

Alexander-48-branch, aka Safari-50 versions

19:57 Changeset [3294] by darin
  • 3 edits in trunk

Lets call this 51u, not 50u.

19:56 Changeset [3293] by darin
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Maciej.

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

Reviewed by Maciej.

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
  • English.lproj/Localizable.strings: Regenerate.
19:47 Changeset [3292] by kocienda
  • 1 edit in branches/Alexander-48-branch/WebKit/ChangeLog

2003-01-09 Ken Kocienda <kocienda@apple.com>

Reviewed by me

Added missing ChangeLog comment for a file I merged

  • ChangeLog
19:21 Changeset [3291] by kocienda
  • 6 edits in branches/Alexander-48-branch/WebKit

2003-01-09 Ken Kocienda <kocienda@apple.com>

Changes merged from trunk onto the branch to patch critical data loss problems.

WebKit:

Reviewed by Everybody

Changes merged from trunk onto the branch to patch critical data loss problems.

2003-01-09 Trey Matteson <trey@apple.com>

Reviewed by Richard.

3142201 - home directory nuked during power download session

We add checks for various error cases that could combine to cause this problem. While we
never got a reproducible case, we are confident that this is the only file removal done
in the download code, and its ability to wreak havoc has been clipped.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): Only nuke the partial download if in fact we created a new download file. Never nuke a directory. (-[WebDownloadHandler createFileIfNecessary]): Don't add "." to the foo-1 filenames we generate if the original filename doesn't have any extension.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to overwrite the user's home directory.

2003-01-09 Darin Adler <darin@apple.com>

Reviewed by Chris.

  • second pass on 3143332 - we still need a test case to be sure this is right
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for "/". Also report the failure instead of just hanging on forever.

2003-01-09 Trey Matteson <trey@apple.com>

Reviewed by Darin

WebKit:

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against a download location that is not an absolute path.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Bail on download if we don't have a abs path to write to.

WebBrowser:

Reviewed by Everybody

Changes merged from trunk onto the branch to patch critical data loss problems.

2003-01-09 Trey Matteson <trey@apple.com>

Reviewed by Darin

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against slashes and leading periods, as well as handling empty filenames.

  • BrowserWebController.m: (-[BrowserWebController saveFilenameForResponse:andRequest:]): Check results of [response filename] carefully

2003-01-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

  • fixed 3143311 - Create /tmp link on startup if it's missing
  • main.m: (main): Make the /tmp symlink if it's missing.

2003-01-09 Darin Adler <darin@apple.com>

Reviewed by Maciej.

  • fixed 3143417 - store last version run in the preferences
  • added a new user default that stores the version (source version).
  • PreferenceKeys.h: Put in a new preference key for the "last version run".
  • main.m: (main): Call storeVersionInPreferences. (storeVersionInPreferences): Store the source version in "last version run".
18:06 Changeset [3290] by rjw
  • 2 edits in trunk/WebKit

Fixed 3143361. This was a regression introduced with some image
rendering optimizations. Don't bypass the tiling code path if
the image needs to be rendered out-of-phase.

Reviewed by hyatt.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:]):
17:33 Changeset [3289] by darin
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • second pass on 3143332 - we still need a test case to be sure this is right
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for "/". Also report the failure instead of just hanging on forever.
17:12 Changeset [3288] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3143332 -- if path returned is empty string (or "." or "..") it will trash the /tmp symlink
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for empty string, ".", and "..", and don't create files by those names.
17:04 Changeset [3287] by trey
  • 3 edits in trunk/WebKit

WebKit:

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against a download location that is not an absolute path.

Reviewed by Darin

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Bail on download if we don't have a abs path to write to.

WebBrowser:

3143294 - need short-term bulletproofing of download code against bad filenames

We protect against slashes and leading periods, as well as handling empty filenames.

Reviewed by Darin

  • BrowserWebController.m: (-[BrowserWebController saveFilenameForResponse:andRequest:]): Check results of [response filename] carefully
16:14 Changeset [3286] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed Radar 3143013 - hang trying to load spiny.com/software
  • khtml/rendering/render_table.cpp: (RenderTable::layoutRows): Check for the render root as a loop termination condition, to avoid an infinite loop for an absolute but non-fixed table cell.
16:06 Changeset [3285] by hyatt
  • 3 edits in trunk/WebCore

The "flow-mode" quirk for lists is just that - a quirk, and should
not be applied when in strict mode.

Fixes diveintomark.org's navigation bar on the front page (issue #2
on his list).

Reviewed by darin and maciej

  • khtml/css/html4.css:
15:25 Changeset [3284]
  • 5 copies
    2 deletes in tags/JavaScriptCore-49~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-49~1'.

15:25 Changeset [3283] by mjs
  • 4 edits in branches/su-jag-pink-branch/JavaScriptCore

Updated versions for 49.1.

  • English.lproj/InfoPlist.strings: Updated to 49.1 and 0.8.
  • JavaScriptCore.pbproj/project.pbxproj: Likewise.
10:52 Changeset [3282] by hyatt
  • 4 edits in trunk/WebCore

Finish the KONQBLOCK removal and make sure that table rows and
cells encountered inside stray content cause the stray content to
close so that the rows and cells can be part of the table.

This fixes the versiontracker bug. #3142319.

Reviewed by darin.

  • khtml/html/htmlparser.cpp: (KHTMLParser::reset): (isTableRelatedTag): (KHTMLParser::insertNode): (KHTMLParser::popOneBlock):
  • khtml/html/htmlparser.h:
Note: See TracTimeline for information about the timeline view.