Timeline


and

09/13/04:

23:03 Changeset [7546] by darin

Reviewed by Maciej.

  • fixed <rdar://problem/3710123> Loading iframe that replaces content in the parent document crashes Safari (Oracle Portal)

This is a more complete fix, but it requires the previous attempt at a fix for this same
bug below, because this is only the "don't destroy the KHTMLPart" portion; other fixes are
still needed to survive shutdown of the part.

  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::interpreter): Call the new keepAlive method. This is called whenever we're about to use an interpreter to run some JavaScript, and it's JavaScript that might destroy the part, hence the interpreter.
  • khtml/khtml_part.h: Added keepAlive() and slotEndLifeSupport() member functions.
  • khtml/khtmlpart_p.h: Added m_lifeSupportTimer.
  • khtml/khtml_part.cpp: (KHTMLPart::init): Connects m_lifeSupportTimer to slotEndLifeSupport. (KHTMLPart::write): Removed old attempt to work around this issue. (KHTMLPart::end): Ditto. (KHTMLPart::keepAlive): Added. References the part, then sets up a one-shot timer. (KHTMLPart::slotEndLifeSupport): Added. Stops the timer and then removes the reference from the part, possibly destroying it.
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Added the new slot to the list of slots. (KWQSlot::call): Ditto.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendResizeEvent): Removed an old attempt to work around this same issue. (KWQKHTMLPart::mouseDown): Ditto. (KWQKHTMLPart::mouseDragged): Ditto. (KWQKHTMLPart::mouseUp): Ditto. (KWQKHTMLPart::mouseMoved): Ditto. (KWQKHTMLPart::sendContextMenuEvent): Ditto.
21:48 Changeset [7545] by darin

Reviewed by Maciej.

  • fixed regression caused by change earlier today
  • khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Use CaretPosition for CHARACTER, not WORD.
18:02 Changeset [7544]

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~6'.

18:02 Changeset [7543] by vicki
  • fix a typo in my last change, whoops!
  • kjs/property_map.cpp: (KJS::PropertyMap::put):
17:56 Changeset [7542] by vicki
  • initialize deletedElementIndex to 0 to make the compiler happy
  • kjs/property_map.cpp: (KJS::PropertyMap::put):
17:37 Changeset [7541]

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~1'.

17:37 Changeset [7540] by vicki

versioning for SUPanNavy, WebKit-125.5.1

17:32 Changeset [7539]

This commit was manufactured by cvs2svn to create tag
'WebCore-125~8~8'.

17:32 Changeset [7538] by vicki
  • versioning for SUPanNavy, WebCore-125.8.8
17:27 Changeset [7537] by vicki

versioning for SUPanNavy, JavaScriptCore-125.6

17:03 Changeset [7536] by vicki
  • roll the fix for <rdar://problem/3791496> off the branch, since we won't be including this in SUPanNavy

2004-08-10 Darin Adler <darin@apple.com>

Reviewed by Trey.

  • fixed <rdar://problem/3710123> Loading iframe that replaces content in the parent document crashes Safari

I fixed three problems:

1) script interpreter destroyed while it was interpreting scripts, caused random havoc
2) code trying to get to view after view was detached from part, caused nil-deref
3) signals sent to parent after child was no longer in the parent's frames list, caused nil-deref

Now the test page works fine. Hope the real sites do too.

  • khtml/khtml_part.h: Add connectChild and disconnectChild helper functions (private).
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Call disconnectChild on each frame as we detach it (see below). (KHTMLPart::end): Ref the part at the start, and deref the part at the end, of this function. Otherwise, we can end up destroying the part, and hence the interpreter, inside a script that the interpreter itself is running. (KHTMLPart::slotFinishedParsing): Add another check for a nil m_view, after the call to checkCompleted. (KHTMLPart::checkCompleted): Remove bogus if statement with empty body. (KHTMLPart::processObjectRequest): Call disconnectChild to disconnect the child <-> parent signals of the old child that the new one is replacing, and connectChild to connect the signals (nicer factoring). (KHTMLPart::slotChildCompleted): Fixed up a confusing boolean if/expression to be simpler. Not related to the bug fix, but an earlier version of the fix had changes in this function. (KHTMLPart::connectChild): Added. Connects the appropriate signals for a child frame. (KHTMLPart::disconnectChild): Added. Disconnects the same signals that connectChild connects.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached): Added a call to disconnectChild before removing the child from the frames list.
15:45 Changeset [7535] by darin

Reviewed by Kevin.

  • fixed <rdar://problem/3798453> DIG failure: getting variable with same name as DOM element attribute gets attribute value instead
  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): When adding current target and other event handler scope, put it below the existing scope chain. This ensures that things found in the function's scope will come before the event handler, as in other browsers.
15:44 Changeset [7534] by darin

Reviewed by Kevin and Maciej.

  • new function to support fix for DIG bug in WebCore
  • kjs/scope_chain.h: Added new push function that pushes another entire scope chain.
  • kjs/scope_chain.cpp: (KJS::ScopeChain::push): Ditto.
14:36 Changeset [7533] by kocienda

Reviewed by Darin

Fix for this bug:

<rdar://problem/3798346> REGRESSION (125-162): crash pushing down arrow key on KLM.com site

  • khtml/xml/dom_position.cpp: (DOM::Position::nextLinePosition): This function was being called in a case where it was not expected until we traced the code. It has to do with some deeper issues associated with handling arrow keys, resulting in the editing arrow-down code running in a case where we are not editing. I discussed this with Darin, and we decided to handle the broader issues at a later date. The fix I am checking in here to fix the bug is merely avoiding a null-deref.
13:38 Changeset [7532] by rjw

D'oh. How many times can I screw up a simple fix!

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
13:17 Changeset [7531] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/3784840> REGRESSION (Mail): Text is inserted in the wrong place after changing typing style

  • khtml/editing/htmlediting_impl.cpp: (khtml::InputTextCommandImpl::prepareForTextInsertion): Code to handle typing style did not check to see if the reference node used for the DOM node insertion operation was a block. If it is, then the new node containing the new editing style now is inserted at the start of the block, instead of after it.
12:32 Changeset [7530] by rjw

Fixed snafu from 3782533 checkin.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
11:39 Changeset [7529] by kocienda

Reviewed by me

Added a couple new layout tests to cover recent changes.

  • layout-tests/editing/editing.js: Added some new functions to do by-word selection movement.
  • layout-tests/editing/selection/move-backwords-by-word-001-expected.txt: Added.
  • layout-tests/editing/selection/move-backwords-by-word-001.html: Added.
  • layout-tests/editing/selection/selection-3748164-fix-expected.txt: Added.
  • layout-tests/editing/selection/selection-3748164-fix.html: Added.
11:25 Changeset [7528] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/3765519> REGRESSION (Mail): word movement goes too far upstream at start of line

  • khtml/xml/dom_position.cpp: (DOM::Position::previousWordPosition): Use downstream position here when making final placement of caret.
11:09 Changeset [7527] by vicki
  • fix merge errors from <rdar://problem/3773150>
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write):
  • khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending):
11:06 Changeset [7526] by kocienda

Reviewed by Darin

Various editing improvements, many focused on the improvements made possible by the
new CaretPosition class.

Includes fixes for these bugs:

<rdar://problem/3748164> REGRESSION (Mail): Arrow navigation in typical mail message can result in stuck caret
<rdar://problem/3782062> REGRESSION (Mail): option-delete can delete almost all of a message when it has trouble finding a word
<rdar://problem/3790456> triple click does not select entire paragraph (folklore.org)

  • WebCore.pbproj/project.pbxproj: Added CaretPosition class files.
  • khtml/dom/dom2_range.h: (DOM::offsetInCharacters): Moved this helper here from khtml_text_operations.cpp. This function helps to determine how to interpret the offsets used in DOM Ranges.
  • khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Use CaretPosition class to make "end-of-block" determination. Also, fix a caret placement glitch in "case 1" in the code: Place the caret in the node after the inserted BR. This makes it show up in the right place.
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): Don't limit double-click and triple-click handling only to text nodes. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::selectAll): Use CaretPosition class to implement improved selectAll.
  • khtml/misc/khtml_text_operations.cpp: (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Make a fix to the initial state setting of m_handledChildren. This is true if the offset into the end node is 0, meaning that we do not want to descend into its children at all.
  • khtml/xml/dom_caretposition.cpp: Added.
  • khtml/xml/dom_caretposition.h: Added.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::traverseNextNode): Fix bugs with the stayWithin implementation. We could miss nodes we want to test due to an erroneous check of stayWithin when no such check is needed. (NodeImpl::traverseNextSibling): Ditto. (NodeImpl::traversePreviousNodePostOrder): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::Position): Remove spurious semi-colon. (DOM::Position::upstream): Move incoming Position to its equivalentDeepPosition. This is part of the transition that will make this code work better with increased use of CaretPosition. (DOM::Position::downstream): Ditto. (DOM::Position::atStartOfContainingEditableBlock): Removed. Dead code; was not being called. (DOM::Position::atStartOfRootEditableElement): Removed. Dead code; was not being called. (DOM::Position::isLastRenderedPositionInEditableBlock): Removed. Replaced with calls to CaretPosition class. (DOM::Position::inLastEditableInRootEditableElement): Removed. Dead code; was not being called. (DOM::Position::inFirstEditableInRootEditableElement): Removed. Was only being called by other code that has been removed.
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_selection.cpp: (DOM::Selection::modifyExtendingRightForward): Moved implementation of CHARACTER case to use CaretPosition class instead of Position class helpers. (DOM::Selection::modifyMovingRightForward): Ditto. (DOM::Selection::modifyExtendingLeftBackward): Ditto. (DOM::Selection::modifyMovingLeftBackward): Ditto. (DOM::Selection::validate): Made simplifications in code that used to call a concoction of Position class helpers to do the right thing. Now calls CaretPosition equivalents.
10:56 Changeset [7525] by cblu

Support for: <rdar://problem/3794790> drop rate or time remaining from download status when window is too small to fit it

Reviewed by john.

  • Misc.subproj/WebStringTruncator.h:
  • Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator widthOfString:font:]): new
10:19 Changeset [7524] by kocienda

Reviewed by me

This test was broken. The result is that it was not testing what it was supposed to
be testing. I fixed the test and updated the expected results.

  • layout-tests/editing/selection/move-between-blocks-no-001-expected.txt
  • layout-tests/editing/selection/move-between-blocks-no-001.html
09:43 Changeset [7523] by kocienda

Reviewed by John

Fix for these bugs:

<rdar://problem/3784835> REGRESSION (Mail): crash in DOM::ElementImpl::tagName inside delete text command code while editing a Mail message
<rdar://problem/3788015> REGRESSION (Mail): Crash deleting before a blockquote
<rdar://problem/3796366> REGRESSION (Mail): Crash Mail by deleting the right line from pasted HTML

  • khtml/editing/htmlediting_impl.cpp: (khtml::DeleteSelectionCommandImpl::doApply): All of these bugs are due to the same problem. When I made the delete command run even when the text is a caret (to make block merges work right when the caret is at the start of a block), I failed to handle one case when there might be no text to delete. This resulted in a call to the DeleteTextCommand with a zero-length deletion request. This is not supported. Now, I have added an additional test in this one place in the code that was causing all these failures.

09/12/04:

23:23 Changeset [7522] by darin
  • tests/mozilla/expected.html: Updated test results for 3 more tests that pass with the new version of escape and unescape.
23:22 Changeset [7521] by darin

Reviewed by Maciej.

  • fixed <rdar://problem/3798209> any non-ASCII characters are garbled in the result of toLocaleString
  • kjs/date_object.cpp: (formatLocaleDate): Replaced two old functions that used LongDateTime with this one new function that uses CFDateFormatter. (DateProtoFuncImp::call): Call the new formatLocaleDate instead of both formatLocaleDate and formatLocaleTime.
23:05 Changeset [7520] by darin

Reviewed by Maciej.

  • fixed <rdar://problem/3797758> REGRESSION (155-156): Cannot tab between input fields at switchboard.com
  • kwq/KWQLineEdit.mm: (QLineEdit::selectAll): Use setFocus() instead of calling makeFirstResponder directly since it handles the case where the field editor has focus.
23:05 Changeset [7519] by darin

Reviewed by Maciej.

  • fixed <rdar://problem/3792082> zero character codes in UTF-16 input cause crash
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUTF16): Fixed code that was using the wrong variable to decrement the input length, causing buffer overrun.
23:04 Changeset [7518] by darin

Reviewed by Maciej.

  • fixed <rdar://problem/3798240> computed style error log messages seen with numbers in the range 74-77
  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added implementations for CSS_PROPKHTML_MARQUEE_INCREMENT, CSS_PROP_MAX_HEIGHT, CSS_PROP_MAX_WIDTH, CSS_PROP_MIN_HEIGHT, CSS_PROP_MIN_WIDTH, and CSS_PROP_VISIBILITY.
23:03 Changeset [7517] by darin
  • layout-tests/css1/text_properties/text-transform-expected.txt: Removed unused test result.

09/11/04:

01:22 Changeset [7516] by mjs

Reviewed by Darin.

<rdar://problem/3787208> can't log in to SAP SDN site (JS parse error)

  • kwq/KWQKURL.mm: (KURL::decode_string): Check for find result >= 0 instead of >0, to handle case of first character in a string being encoded.

09/10/04:

16:26 Changeset [7515] by rjw

Fixed <rdar://problem/3782533> CrashTracer: .1459 crashes at com.apple.WebKit: -[WebTextRenderer initWithFont:usingPrinterFont:] + 0x138

We were explicitly failing when we encountered deprecated fonts.
(Those with unsupported glyph packings).
Deprecated fonts should only appear on a system that have
stuff migrated from OS 9. Ugh, thats probably why we've never seen
the problem here.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
16:15 Changeset [7514] by vicki
  • merge these changes for SUPanNavy, <rdar://problem/3773150>

2004-08-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

  • fixed <rdar://problem/3752509> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)

(actually the previous fix for this bug was mostly correct, but
this additional change is needed to avoid the regression in
<rdar://problem/3751025> REGRESSION: website rejects Safari 125.9
as "need to upgrade to IE 6", but didn't reject 125.8

So if merging for a software update, make sure to include both
this and the previous fix.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): When there is an immediate reidrect pending, make sure to stop tokenizing, because we need to make sure no further script tags are processed beyond the one that triggered the redirect.
  • khtml/khtml_part.cpp: (KHTMLPart::isImmediateRedirectPending): New method to allow checking if a redirect is pending.
  • khtml/khtml_part.h:

2004-06-18 John Sullivan <sullivan@apple.com>

Reviewed by Darin

  • fixed <rdar://problem/3534851> Pop up windows not showing up within SAP's BW Module (changing location.href on new window created by window.open)
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleRedirection): allow new redirect to win if delay <= current delay, not just <
16:12 Changeset [7513] by vicki

WebKit:

  • merge this change for <rdar://problem/3791183> Need to choose "best" frame instead of printing all frames clipped to window size (clone for SUPanNavy). The original fix would not compile on 10.3.5.

2004-09-10 John Sullivan <sullivan@apple.com>

Reviewed by Chris.

  • added _isFrameSet as a private method, so it can be used in WebBrowser. This is needed to merge the fix for 3123987 to SUPanNavy.
  • WebView.subproj/WebFrame.m: (-[WebFrame _isFrameSet]): new method
  • WebView.subproj/WebFramePrivate.h: declare new method

WebBrowser:

  • merge this change for <rdar://problem/3791183> Need to choose "best" frame instead of printing all frames clipped to window size (clone for SUPanNavy). The original fix would not compile on 10.3.5.

2004-09-10 John Sullivan <sullivan@apple.com>

Reviewed by Chris.

  • changed implementation of -[WebFrameView isFrameset] so that it's more easily mergeable back to 10.3.5. This is needed to merge 3123987 to SUPanNavy.
  • BrowserWebViewExtras.m: (-[WebFrameView isFrameset]): Call private WebFrame method instead of using DOM.
15:21 Changeset [7512] by sullivan

WebKit:

Reviewed by Chris.

  • added _isFrameSet as a private method, so it can be used in WebBrowser. This is needed to merge the fix for 3123987 to SUPanNavy.
  • WebView.subproj/WebFrame.m: (-[WebFrame _isFrameSet]): new method
  • WebView.subproj/WebFramePrivate.h: declare new method

WebBrowser:

Reviewed by Chris.

  • changed implementation of -[WebFrameView isFrameset] so that it's more easily mergeable back to 10.3.5. This is needed to merge 3123987 to SUPanNavy.
  • BrowserWebViewExtras.m: (-[WebFrameView isFrameset]): Call private WebFrame method instead of using DOM.
13:53 Changeset [7511] by vicki
  • code changes by Darin, reviewed by Vicki

Fix build breakage on the branch caused by bad merging for <rdar://problem/3772916> controls
on page at http://help.sap.com don't work properly (clone for SUPanNavy)

  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/ecma/kjs_window.cpp: (Window::Window): (BarInfo::BarInfo):
09:18 Changeset [7510] by cblu

Fixed previous "Reviewed by" line.

  • ChangeLog:
08:58 Changeset [7509] by cblu

WebCore:

Support for: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by rjw.

  • khtml/khtml_part.h: (KHTMLPart::didFirstLayout): new
  • khtml/khtmlview.cpp: (KHTMLView::layout): call didFirstLayout
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::didFirstLayout): new
  • kwq/WebCoreBridge.h:

WebKit:

Support for: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by NOBODY (OOPS!).

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didFirstLayout]): new
  • WebView.subproj/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFirstLayoutInFrame:]): new
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Fixed: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout

Reviewed by rjw.

  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController startRSSAnimationForFrame:error:]): new (-[BrowserWindowController webFrameLoadDidFirstLayout:]): new (-[BrowserWindowController webFrameLoadFinished:withError:]): call startRSSAnimationForFrame:error:
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): added toggle for RSS animation (-[BrowserDocument toggleRSSAnimateAfterFirstLayout:]): new (-[BrowserDocument validate_toggleRSSAnimateAfterFirstLayout:]): new
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:didFirstLayoutInFrame:]): new
  • PreferenceKeys.h:

09/09/04:

19:31 Changeset [7508] by rjw

Alternate implementation of image rendering. Use CGImageRefs instead
of NSImages.

Mostly works, but currently disabled because of issues w/ CG.

Reviewed by Chris.

  • ChangeLog:
  • WebCoreSupport.subproj/WebImageData.h: Added.
  • WebCoreSupport.subproj/WebImageData.m: Added. (-[WebImageData _commonTermination]): (-[WebImageData dealloc]): (-[WebImageData finalize]): (-[WebImageData copyWithZone:]): (-[WebImageData numberOfImages]): (-[WebImageData currentFrame]): (-[WebImageData _invalidateImages]): (-[WebImageData imageAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:]): (drawPattern): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData isNull]): (-[WebImageData size]): (-[WebImageData _frameDuration]): (-[WebImageData _repetitionCount]): (-[WebImageData isAnimationFinished]): (+[WebImageData stopAnimationsInView:]): (-[WebImageData addAnimatingRenderer:inView:]): (-[WebImageData removeAnimatingRenderer:]): (-[WebImageData _stopAnimation]): (-[WebImageData _nextFrame:]): (-[WebImageData animate]):
  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer dealloc]): (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer retainOrCopyIfNeeded]): (-[WebImageRenderer resize:]): (-[WebImageRenderer size]): (-[WebImageRenderer MIMEType]): (-[WebImageRenderer frameCount]): (-[WebImageRenderer isNull]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): (-[WebImageRenderer tileInRect:fromPoint:context:]): (-[WebImageRenderer _startOrContinueAnimationIfNecessary]): (+[WebImageRenderer stopAnimationsInView:]): (-[WebImageRenderer stopAnimation]): (-[WebImageRenderer targetAnimationRect]): (-[WebImageRenderer increaseUseCount]): (-[WebImageRenderer decreaseUseCount]): (-[WebImageRenderer flushRasterCache]): (-[WebImageRenderer imageRef]): (-[WebImageRenderer TIFFRepresentation]): (-[WebImageRenderer image]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]): (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): (-[WebImageRendererFactory imageRendererWithSize:]): (-[WebImageRendererFactory imageRendererWithName:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebImageView.m: (-[WebImageView image]):
18:52 Changeset [7507] by mjs

Reviewed by Richard.

<rdar://problem/3493140> REGRESSION (85-100): cedille displays %-escaped in JavaScript message at hotmail.com

  • kjs/function.cpp: (KJS::GlobalFuncImp::call): Replace our escape() and unescape() implementations with ones from KDE KJS, which have the proper latin-1 behavior to match Win IE.
  • kjs/lexer.cpp: (Lexer::isHexDigit): Made static and non-const.
  • kjs/lexer.h:
18:41 Changeset [7506] by vicki

change version number to 2.0, 164u for TOT

18:29 Changeset [7505]

This commit was manufactured by cvs2svn to create tag 'Safari-163'.

18:29 Changeset [7504] by vicki

Safari-163 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (163 in both cases).

18:02 Changeset [7503] by mjs
  • roll out the last change, it appears to cause a performance regression
  • khtml/rendering/render_box.cpp: (RenderBox::caretRect):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::caretRect):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.cpp: (RenderObject::caretRect):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (RenderText::caretRect):
  • khtml/rendering/render_text.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm:
18:01 Changeset [7502] by mjs
  • rolled out last two changes, they seem to cause a performance regression
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]):
15:25 Changeset [7501] by mjs
  • fixed build
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]):
14:02 Changeset [7500] by mjs

WebCore:

Reviewed by Dave.

WebCore part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge firstRectForDOMRange:]): New method to compute the rect for a DOMRange, or if the range is split into multiple lines, the rect for the part on the first line only.
  • khtml/rendering/render_object.cpp: (RenderObject::caretRect): Added extraWidthToEndOfLine parameter and ditto for the overrides below.
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_box.cpp: (RenderBox::caretRect):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::caretRect):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_text.cpp: (RenderText::caretRect):

WebKit:

Reviewed by Dave.

WebKit part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Call the appropriate new bridge method, and translate to screen coordinates.
10:56 Changeset [7499]

This commit was manufactured by cvs2svn to create tag 'WebKit-125~5'.

10:56 Changeset [7498] by vicki

add release marker and comment for WebKit-125.5

10:49 Changeset [7497] by vicki

change the WebKit version number from 125.4.2 to 125.5, for Security Update

08:00 Changeset [7496] by darin

WebCore:

Reviewed by Ken.

  • fixed <rdar://problem/3790526> mark-related methods not implemented (needed for people with them in their key bindings files)
  • khtml/khtml_part.h: Added mark and setMark.
  • khtml/khtmlpart_p.h: Added m_mark.
  • khtml/khtml_part.cpp: (KHTMLPart::mark): Added. (KHTMLPart::setMark): Added.
  • kwq/KWQKHTMLPart.h: Change name of markedRange to markedTextRange to decrease the change it will be confused with the mark.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clear): Update for name change. (KWQKHTMLPart::markedTextRange): Ditto. (KWQKHTMLPart::setMarkedTextRange): Ditto.
  • khtml/rendering/render_text.cpp: (RenderText::paint): Update for name change.
  • kwq/WebCoreBridge.h: Remove setSelectionFrom, selectionStart, selectionStartOffset, selectionEnd, selectionEndOffset, and clearMarkedDOMRange. Renamed setMarkedDOMRange to setMarkedTextDOMRange and markedDOMRange to markedTextDOMRange. Added setMarkDOMRange and markDOMRange for the Emacs "mark".
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setMarkDOMRange:]): Added. (-[WebCoreBridge markDOMRange]): Added. (-[WebCoreBridge setMarkedTextDOMRange:]): Renamed. (-[WebCoreBridge markedTextDOMRange]): Renamed.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::validate): Make paragraph positions canonical by using deep rendered positions. Maybe someday this won't be an ad hoc decision any more.
  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::removeChildren): Use ref and deref rather than the unconventional check for 0 refCount. This makes us a bit more robust against a node going away partway through the removal process.
  • WebCore.pbproj/project.pbxproj: Update MACOSX_DEPLOYMENT_TARGET to 10.3.

WebKit:

Reviewed by Ken.

  • fixed <rdar://problem/3790526> mark-related methods not implemented (needed for people with them in their key bindings files)
  • WebKit.pbproj/project.pbxproj: Update MACOSX_DEPLOYMENT_TARGET to 10.3 and add -fobjc-exceptions so we can use new exceptions.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView setMark:]): Added. (unionDOMRanges): Added. (-[WebHTMLView deleteToMark:]): Added. (-[WebHTMLView selectToMark:]): Added. (-[WebHTMLView swapWithMark:]): Added. (-[WebHTMLView markedRange]): Updated for change to bridge method names. (-[WebHTMLView hasMarkedText]): Ditto. (-[WebHTMLView unmarkText]): Ditto. (-[WebHTMLView _selectMarkedText]): Ditto. (-[WebHTMLView _selectRangeInMarkedText:]): Ditto. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView _insertText:selectInsertedText:]): Removed check for empty string. An empty string should not be filtered out here. We need to allow inserting an empty string. (-[WebHTMLView _selectionIsInsideMarkedText]): Updated for change to bridge method names. (-[WebHTMLView _updateSelectionForInputManager]): Ditto.
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Changed to use selectionDOMRange instead of selectionStart.
  • WebView.subproj/WebHTMLRepresentation.h: Removed unused setSelectionFrom method.
  • WebView.subproj/WebHTMLRepresentation.m: Ditto.
Note: See TracTimeline for information about the timeline view.