Timeline


and

02/06/05:

22:44 Changeset [8534] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3993722> need oncut and onpaste handlers implemented for <textarea> (needed for widgets)
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView dispatchHTMLEvent:]): Added. (-[KWQTextAreaTextView cut:]): Dispatch "before cut" and "cut" events. (-[KWQTextAreaTextView copy:]): Dispatch "before copy" and "copy" events. (-[KWQTextAreaTextView paste:]): Dispatch "before paste" and "paste" events. (-[KWQTextAreaTextView pasteAsPlainText:]): Ditto. (-[KWQTextAreaTextView pasteAsRichText:]): Ditto.
22:37 Changeset [8533] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3943038> <input type=search> that is focused in onload handler doesn't have a visible editor
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Always update layout before giving focus to a widget. This prevents the bad case where we give a widget focus before it has been positioned or sized, causing us to exercise edge cases AppKit doesn't handle well.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Remove workaround code I added to fix bug 3943049. Updating the layout fixes the same problem in a cleaner, safer way, and solves another problem, with the way the clip view is set up.
22:31 Changeset [8532] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3425232> textarea won't trigger onchange action when clicking to new field
  • khtml/rendering/render_form.h: Added new m_dirty data member.
  • khtml/rendering/render_form.cpp: (RenderTextArea::RenderTextArea): Initialize m_dirty to false. (RenderTextArea::detach): Call value() on the DOM element to cause it to fetch the value from this object. (RenderTextArea::handleFocusOut): Ditto. Also send the onchange event based only on the m_dirty flag. (RenderTextArea::updateFromElement): Clear the m_dirty flag if the edited value is blown away by a value that comes from the DOM element. Remove code to clear the element's m_dirtyvalue flag; that's an unnecessary optimization, and ideally we'll stop having code in the render object that knows about that flag later. (RenderTextArea::slotTextChanged): Set the m_dirty flag.
22:26 Changeset [8531] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • re-fixed <rdar://problem/3760910> please add support for custom tag names in HTML
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::tagId): Use ID_LAST_TAG + 1 for the ID of the first assigned tag ID. Before we'd use ID_LAST_TAG, which resulted in the same number being used for ID_COMMENT and the first custom tag. (DocumentImpl::tagName): Use ID_LAST_TAG + 1, as above. (DocumentImpl::namespaceURI): Change a < ID_LAST_TAG to <= ID_LAST_TAG in the same spirit as above.
22:18 Changeset [8530] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3986639> Crash occurs after choosing Undo Typing from the Edit menu
  • kwq/KWQTextArea.mm: (-[KWQTextArea viewWillMoveToWindow:]): Remove actions from undo manager when the view is removed from the window. Unfortunately, to do this the code has to know that the target of NSTextView actions will be the text storage object, but given the NSText architecture, that's pretty clear.
22:13 Changeset [8529] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed <rdar://problem/3963166> PDFView SPI print method is being deprecated, moving to PDFDocument; please update WebKit
  • WebView.subproj/WebPDFView.m: (-[WebPDFView printOperationWithPrintInfo:]): Target the document instead of the view.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes and also moved one translation to be a file-specific item rather than a file-independent one.
12:19 Changeset [8528] by cblu
  • 6 edits in trunk

WebCore:

Fixed: <rdar://problem/3991974> REGRESSION: www.jabra.com world location screen does not work

Reviewed by hyatt.

  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): fallback to the document's base URL if there is no baseURL attribute
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge baseURL]): new

WebKit:

Fixed: <rdar://problem/3991974> REGRESSION: www.jabra.com world location screen does not work

Reviewed by hyatt.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): use the baseURL from the bridge rather than from the response

02/04/05:

17:49 Changeset [8527] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Rolled out Ken's accidental checkin when committing <rdar://problem/3986155> fix yesterday.

  • khtml/editing/selection.cpp: (khtml::Selection::validate):
17:45 Changeset [8526] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3758785> Safari no longer works at BankOfAmerica online banking for military users

When closing the document, if a body doesn't exist we now create one. This bug was preventing the onload handler from
firing in cases where there wasn't a body. In the BankOfAmerica case, the page was just a bit of script where the onload
handler redirected to the correct page.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):
14:41 Changeset [8525] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3802781> rtf->html pasteboard conversion using xhtml

Reviewed by kocienda.

  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _excludedElementsForAttributedStringConversion]): new (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call _excludedElementsForAttributedStringConversion
14:18 Changeset [8524] by kocienda
  • 6 edits
    12 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3986155> Insertion point goes to beginning of doc after deleting

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::setStartNode): New convenience to handle reference counting when setting. (khtml::DeleteSelectionCommand::handleGeneralDelete): This contains the crux of the bug fix. Improve tests that detect when a selected node needs to be retained, rather than deleted, to preserve the intent of the user. This has the side effect of causing the insertion point placement code to succeed rather than fail. Before this fix, the failure of the insertion point placement code caused the insertion point to jump to the start of the document, which is the symptom that can be perceived by users when editing.
  • khtml/editing/htmlediting.h: Add setStartNode declaration.
  • khtml/editing/visible_units.cpp: (khtml::startOfBlock): This function had a stubbed-in non-tested implementation. Implement and
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-001.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-002.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-005.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-006.html: Added.
10:45 Changeset [8523]
  • 3 copies in tags/Safari-183

This commit was manufactured by cvs2svn to create tag 'Safari-183'.

10:45 Changeset [8522] by vicki
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Move the Safari-183 marker in the ChangeLog, since we're going to include <rdar://problem/3972905> in today's Safari-183 submission

10:25 Changeset [8521] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3832973> copy text from PowerPoint, paste into Blot (or presumably Mail) and get a single missing image icon

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): prefer RTF and RTFD over images just as NSTextView does

02/03/05:

17:44 Changeset [8520] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3555137> REGRESSION (125-173): Flash animation can erase parts of chrome (bookmarks bar & tab bar)

convertRect:toView: returns incorrect results inside of viewWillMoveToWindow: with a nil window. Workaround this by catching this case.

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): new (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): clip out the plug-in view when superviewsHaveSuperviews returns NO
17:41 Changeset [8519] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3972905> CrashTracer: ...36 crashes at com.apple.WebCore: khtml::CSSStyleSelector::applyDeclarations + 120

Revert to old (and correct) behavior of returning runtime object
when passed as a parameter, rather than it's corresponding DOM
object.

Reviewed by Chris.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
16:02 Changeset [8518] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3893513> Sun iPlanet app: when saving to a file it brings up a window with the thing to be saved instead

Reviewed by adele.

  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/ldif" to the list of MIME types that our text view doesn't handle
15:57 Changeset [8517] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (183+)
The tree is open!

15:46 Changeset [8516] by vicki
  • 6 edits in trunk

Safari-183 stamp

14:22 Changeset [8515] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3987419> Stocks and Weather leak what appears to XMLHTTPRequest results

XMLHTTPRequests were causing massive leaks. _webcore_initWithHeaderString: did funky things with
self replacement. Re-wrote to use more traditional factory constructor avoiding self replacement.

Reviewed by David Harrison.

  • kwq/KWQLoader.mm: (+[NSDictionary _webcore_dictionaryWithHeaderString:]): (KWQServeRequest): (KWQServeSynchronousRequest):
14:09 Changeset [8514] by cblu
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: updated
13:59 Changeset [8513] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3989611> Evite style "add vCalendar to calendar" do not work

Reviewed by adele.

  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/x-vcalendar" to the list of MIME types our text view doesn't handle
11:56 Changeset [8512] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/3938763> Cannot view Windows Media Player videos (soundtrack is played twice with delay)

Reviewed by hyatt.

  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): set needWidgetUpdate to false right after calling updateWidget because dispatchHTMLEvent can end up calling this method again (HTMLObjectElementImpl::recalcStyle): ditto
10:17 Changeset [8511] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix deployment build breakage on Panther
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView toggleBaseWritingDirection:]):

02/02/05:

17:44 Changeset [8510] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • WebKit part of fix for <rdar://problem/3980651> REGRESSION (125-180): Huge number of pages printed from certain page, iFrame involved

This also fixes the problems with printing from GMail, yay!

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): Don't adjust margins for header/footer here, because this is called for each subframe. (-[WebHTMLView knowsPageRange:]): Do adjust margins for header/footer here (analogous to WebTextView and WebImageView). Also, round the page height to an integer here (noticed in passing).
17:44 Changeset [8509] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Chris.

  • WebCore part of fix for <rdar://problem/3980651> REGRESSION (125-180): Huge number of pages printed from certain page, iFrame involved

This also fixes the problems with printing from GMail, yay!

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): If the current line is taller than the entire page height (e.g. tall iFrame), don't try to avoid splitting it across pages.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): Handle error cases in a more obvious manner; this will cause future problems like this to print a blank page and complain to the console on debug builds, rather than print a zillionty mostly-blank pages.
16:47 Changeset [8508] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/3960304> can't load a particular applet (at www.escape.de) unless it's the first applet to be loaded

Reviewed by hyatt.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): when getting the MIME type from the PARAM tag, make sure the MIME type is the text from the left of the semi-colon if there is one. We do this elsewhere as well.
16:14 Changeset [8507] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3986546> Cut, delete, and paste menu items are active when a image is opened in window

Reviewed by john.

  • WebView.subproj/WebView.m: (-[WebView _responderValidateUserInterfaceItem:]): new, has the responder validate the item (-[WebView validateUserInterfaceItem:]): call VALIDATE for each repsonder selector using FOR_EACH_RESPONDER_SELECTOR macro (-[WebView _performResponderOperation:with:]): call factored out method _responderForResponderOperations (-[WebView _responderForResponderOperations]): new, code from _performResponderOperation:with:
14:01 Changeset [8506] by cblu
  • 8 edits in trunk

WebCore:

Fixed: <rdar://problem/3983628> control-click on WebView is not selecting the word under the cursor (Mail, non-editable WebView)

Reviewed by rjw.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendContextMenuEvent): check if SPI to always enable selecting closest word is enabled
  • kwq/WebCoreBridge.h:

WebKit:

Fixed: <rdar://problem/3983628> control-click on WebView is not selecting the word under the cursor (Mail, non-editable WebView)

Reviewed by rjw.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge selectWordBeforeMenuEvent]): new
  • WebView.subproj/WebView.m: (-[WebView _selectWordBeforeMenuEvent]): new SPI (-[WebView _setSelectWordBeforeMenuEvent:]): new SPI
  • WebView.subproj/WebViewInternal.h:
  • WebView.subproj/WebViewPrivate.h:
13:31 Changeset [8505] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3986013> Assertion failure going back after page load error (no apparent problem in nondebug build)

Reviewed by rjw.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]): don't set the data source data when the main client is nil
11:53 Changeset [8504] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by me

  • khtml/editing/markup.cpp: (khtml::createMarkup): Removed debug spam I committed earlier in error.
11:23 Changeset [8503] by kocienda
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Missed adding changelog comments for one of a batch of fixes I landed

11:09 Changeset [8502] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/3823109> WebKit should support -toggleBaseWritingDirection: (bidi editing support)

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]): New function that calls through to new feature that allows callers to force all properties in a style to be applied as block styles. (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): Removed FIXME comment for something that has been fixed. (-[WebHTMLView toggleBaseWritingDirection:]): Implemented.
11:09 Changeset [8501] by kocienda
  • 11 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3823109> WebKit should support -toggleBaseWritingDirection: (bidi editing support)

Since base writing direction is a paragraph-level property in AppKit, and we use the CSS direction
property in WebCore, which can be applied to inline elements as well as blocks, a new notion has
been added to the WebCore apply style logic. It is now possible to force all properties in a
style declaration to be applied as though they were block properties.

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::ApplyStyleCommand): Add an enum and a flag to this command that controls whether to force all properties in the style to be applied as block styles. Default is "no", retaining previous behavior. (khtml::ApplyStyleCommand::doApply): Switch on new flag to apply styles as before, or force all preoperties to be applied as block styles.
  • khtml/editing/htmlediting.h: (khtml::ApplyStyleCommand::): Add an enum and a flag, as above.
  • khtml/khtml_part.cpp: (KHTMLPart::applyParagraphStyle): New method to force application of all style properties as block styles.
  • khtml/khtml_part.h: Update header declarations.
  • kwq/KWQKHTMLPart.h: Update header declarations.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::baseWritingDirectionForSelectionStart): Accessor to help WebKit do a toggle operation on writing direction.
  • kwq/WebCoreBridge.h: Update header declarations.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge applyParagraphStyle:withUndoAction:]): New method to force application of all style properties as block styles. (-[WebCoreBridge baseWritingDirectionForSelectionStart]): Accessor to help WebKit do a toggle operation on writing direction.
Note: See TracTimeline for information about the timeline view.