Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Feb 14, 2005:

5:52 PM Changeset in webkit [8592] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4004305> REGRESSION (Mail): Command-right-arrow on wrapped text goes to end of previous line

• khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::advance): Add BR in for <rdar://problem/3917929> fix only if leaving a visible text node.

• khtml/editing/visible_units.cpp: (khtml::endOfWord): Do not move left over a paragraph boundary.

1:09 PM Changeset in webkit [8591] by darin

• 6 edits
  4 deletes in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3686434> Safari uses too much RAM on file upload, leading to malloc errors and crashes (HP printers)

• khtml/html/html_formimpl.cpp: (DOM::FormDataList::begin): Updated to use a list of FormDataListItem instead of QCString. (DOM::FormDataList::end): Ditto. (DOM::HTMLFormElementImpl::formData): Same here, and also use appendFile rather than appendData when we encounter a path name rather than data. (DOM::HTMLInputElementImpl::appendFormData): Use appendFile here rather than reading the file in; the reading now happens inside WebKit. (DOM::FormDataList::appendString): Updated for FormDataListItem. (DOM::FormDataList::appendFile): Added.

• ForwardingHeaders/kfileitem.h: Emptied out the file; no longer includes KWQKFileItem.h.
• ForwardingHeaders/netaccess.h: Emptied out the file; no longer includes KWQKIONetAccess.h.
• kwq/KWQKFileItem.h: Removed.
• kwq/KWQKFileItem.mm: Removed.
• kwq/KWQKIONetAccess.h: Removed.
• kwq/KWQKIONetAccess.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed the 4 files above.

• small unrelated fix (not reviewed by John)

• khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Put some logging code outside if statements so it works all the time.

12:06 PM Changeset in webkit [8590] by darin

• 8 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3686434> Safari uses too much RAM on file upload, leading to malloc errors and crashes (HP printers)

• WebView.subproj/WebFormDataStream.h: Added webSetHTTPBody, which creates and connects an appropriate stream to an NSMutableURLRequest.
• WebView.subproj/WebFormDataStream.m: Added implementation here.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Use webSetHTTPBody.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Use webSetHTTPBody.
• WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Use webSetHTTPBody. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.

• English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.

10:19 AM Changeset in webkit [8589] by harrison

• 28 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4004305> REGRESSION (Mail): Command-right-arrow on wrapped text goes to end of previous line

Fixed nextLinePosition to calculate affinity rather than take it as a parameter. Propagated the parameter change out to related methods.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertTextCommand::input): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::applyStyleToInsertedNodes):
• khtml/editing/selection.cpp: (khtml::Selection::modifyExtendingRightForward): (khtml::Selection::modifyMovingRightForward): (khtml::Selection::modifyExtendingLeftBackward): (khtml::Selection::modifyMovingLeftBackward): (khtml::Selection::modify): (khtml::Selection::validate):
• khtml/editing/visible_position.cpp: (khtml::visiblePositionsOnDifferentLines):
• khtml/editing/visible_units.cpp: (khtml::rootBoxForLine): (khtml::startOfLine): (khtml::endOfLine): (khtml::inSameLine): (khtml::isStartOfLine): (khtml::isEndOfLine): (khtml::previousLinePosition): (khtml::nextLinePosition): (khtml::previousSentencePosition): (khtml::nextSentencePosition): (khtml::previousParagraphPosition): (khtml::nextParagraphPosition):
• khtml/editing/visible_units.h:
• khtml/khtml_events.cpp: (khtml::MouseEvent::offset):
• khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates):
• khtml/rendering/render_block.h:
• khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates):
• khtml/rendering/render_br.h:
• khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates):
• khtml/rendering/render_container.h:
• khtml/rendering/render_inline.cpp: (RenderInline::positionForCoordinates):
• khtml/rendering/render_inline.h:
• khtml/rendering/render_object.cpp: (RenderObject::caretRect): (RenderObject::positionForCoordinates):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates):
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):
• khtml/rendering/render_text.h:
• khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): (DOM::Position::nextCharacterPosition): (DOM::Position::leadingWhitespacePosition): (DOM::Position::trailingWhitespacePosition):
• khtml/xml/dom_position.h:
• kwq/KWQAccObject.mm: (-[KWQAccObject value]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]):
• kwq/KWQKHTMLPart.mm:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _visiblePositionForPoint:]):

Feb 12, 2005:

8:08 PM Changeset in webkit [8588] by mjs

• 2 edits in trunk/WebCore

Reviewed by Ken and John.

Re-fixed a specific case of the following:

<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration

Oddly, Cmd-B, Cmd-U, type some text, return, Cmd-U, Cmd-B, type
some text, worked fine. But hitting the second Cmd-B before the
second Cmd-U still failed to remove underlining. The reason for
this is that our code to compute the style of the current position
did not work when you had a typing style and were positioned right
at a <br> element. For various reasons, this did not show up for
bold and italic, since those are handled through the font manager.

The following change fixes this - for elements that can't have
children, we add the dummy span after the element of interest,
rather than as a child of it.

• khtml/khtml_part.cpp: (KHTMLPart::selectionComputedStyle):

Feb 11, 2005:

5:51 PM Changeset in webkit [8587] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/4002505> 8A378: Endlessly animating gif's on ​http://www.entropy.ch

If animated images had no loop count property we were incorrectly
looping forver. Note, that in the course of fixing this bug
I found that ImageIO is incorrectly NOT reporting the loop count
for a whole class of animated GIFs.

Reviewed by Ken Kocienda.

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _repetitionCount]):

5:03 PM Changeset in webkit [8586] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3978980> Double Clicking on a line in Mail selected the entire body

• khtml/editing/visible_units.cpp: (khtml::startOfWord): (khtml::endOfWord): Pay attention to being at the end of a paragraph.

(khtml::previousLinePosition):
(khtml::nextLinePosition):
(khtml::endOfParagraph):
Use DOWNSTREAM per recent affinity changes.

4:58 PM Changeset in webkit [8585] by rjw

• 17 edits
  1 add in trunk

WebCore:

Fixed <rdar://problem/3985118> DOM objects not being marshaled on JS->native calls

Re-factored how 'native' wrappers for JS objects are created. The interpreter now
creates these wrappers. The WebCore subclass of the interpreter now overrides
createLanguageInstanceForValue() and creates a DOM ObjC wrapper for DOM objects.

• WebCore.pbproj/project.pbxproj:
• khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::createLanguageInstanceForValue):
• khtml/ecma/kjs_binding.h:
• kwq/DOMUtility.mm: Added. (KJS::ScriptInterpreter::createObjcInstanceForValue):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView): (getInstanceForView): (KWQKHTMLPart::getEmbedInstanceForView): (KWQKHTMLPart::getObjectInstanceForView):

JavaScriptCore:

Fixed <rdar://problem/3985118> DOM objects not being marshaled on JS->native calls

Re-factored how 'native' wrappers for JS objects are created. The interpreter now
creates these wrappers. The WebCore subclass of the interpreter now overrides
createLanguageInstanceForValue() and creates a DOM ObjC wrapper for DOM objects.

Reviewed by Ken.

• bindings/c/c_utility.cpp: (convertValueToNPVariant):
• bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
• bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
• bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setExecutionContext:KJS::Bindings::]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
• bindings/objc/WebScriptObjectPrivate.h:
• bindings/objc/objc_utility.h:
• bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::createObjcInstanceForValue):
• bindings/runtime.cpp: (Instance::createBindingForLanguageInstance): (Instance::createRuntimeObject): (Instance::createLanguageInstanceForValue):
• bindings/runtime.h:
• kjs/interpreter.cpp: (Interpreter::createLanguageInstanceForValue):
• kjs/interpreter.h:

3:50 PM Changeset in webkit [8584] by cblu

• 4 edits in trunk/WebCore

Fixed: <rdar://problem/3937352> Quote level not maintained when copied and pasted within a Mail message

Reviewed by harrison.

• khtml/editing/markup.cpp: (khtml::isMailBlockquote): new (khtml::createMarkup): retain the Mail quote level by including all ancestor mail block quotes
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): default to downstream for the affinity since the affinity is only upstream when the cursor is clicked to the right of a wrapped line
• khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): ditto

3:22 PM Changeset in webkit [8583] by adele

• 2 edits in trunk/WebCore

Reviewed by Darin.

fix for <rdar://problem/4004004> no need to add body element for xml documents

In the fix for <rdar://problem/3758785> we decided to add a body element when closing a document
to ensure that the onload handler would fire. This is unnecessary for xml documents,
so now we also check to see if we're dealing with an html document before adding the body element.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):

2:59 PM Changeset in webkit [8582] by adele

• 3 edits in trunk

Reviewed by Darin.

• layout-tests/apple-only/base/www.excite.com/index-expected.txt: updates tests because of custom tag change.
• layout-tests/apple-only/base/www.msnbc.com/index-expected.txt:
• layout-tests/apple-only/base/www.time.com/index-expected.txt:
• layout-tests/apple-only/base/www.travelocity.com/index-expected.txt:
• layout-tests/apple-only/base/www.zdnet.com/index-expected.txt:
• layout-tests/fast/overflow/003-expected.txt:

• layout-tests/fast/js/window-object-cross-frame-calls-expected.txt: updated test because of added Body (see rdar://problem/3758785)

2:47 PM Changeset in webkit [8581] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (186+)

2:22 PM Changeset in webkit [8580]

• 1 copy in tags/Safari-186

This commit was manufactured by cvs2svn to create tag 'Safari-186'.

2:22 PM Changeset in webkit [8579] by vicki

• 6 edits in trunk

Safari-186 stamp

11:59 AM Changeset in webkit [8578] by vicki

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fix deployment build on Panther

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView changeBaseWritingDirection:]): ifdef out NSWritingDirectionNatural (-[WebHTMLView toggleBaseWritingDirection:]): fix a spacing issue

9:05 AM Changeset in webkit [8577] by darin

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3915449> paths are relative to the old src URL after document.open, which is supposed to clear the document, including the URL

• khtml/xml/dom_docimpl.h: Added a new openInternal function for use by KHTMLPart.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::open): Changed to do everything we did before, but also clear the URL and set the base URL based on the enclosing document. This is the basic JavaScript/DOM operation of opening a document, which is supposed to clear the document, including the URL. In the long run we might want to do even more document "resetting and clearing" in here, but this URL clearing is what's needed now to fix the most important problem. (DocumentImpl::openInternal): Moved the old open code in here, except for the "parsing" check, which is unnecessary and inappropriate in the one place we call this.

• khtml/khtml_part.cpp: (KHTMLPart::begin): Call openInternal instead of open.

Feb 10, 2005:

6:37 PM Changeset in webkit [8576]

• 10 copies
  4 deletes in tags/JavaScriptCore-125~6~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~6~2'.

6:37 PM Changeset in webkit [8575] by adele

• 2 edits in branches/Safari-1-2-branch/JavaScriptCore

Versioning for JavaScriptCore-125.6.2 for the Panther Security Update 2005-002

6:24 PM Changeset in webkit [8574] by rjw

• 3 edits in branches/Safari-1-2-branch/JavaScriptCore

Fixed <rdar://problem/4002366> Safari crashes leaving ​https://www.entrust.com

Fixed binary incompatiblity inined a member function that used
to NOT be inline.

Reviewed by Darin.

• bindings/runtime_root.cpp: (RootObject::removeAllJavaReferencesForRoot):
• bindings/runtime_root.h:

5:38 PM Changeset in webkit [8573] by harrison

• 2 edits in trunk/WebKit

Reviewed by Richard.

<rdar://problem/3991652> REGRESSION (Mail): Deleting entire line in reply deletes extra blank line and moves insertion point

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): (-[WebHTMLView selectToMark:]): (-[WebHTMLView swapWithMark:]): (-[WebHTMLView transpose:]): (-[WebHTMLView _selectMarkedText]): (-[WebHTMLView _selectRangeInMarkedText:]): Adopt new default affinity of NSSelectionAffinityDownstream as of <rdar://problem/3937447>.

4:35 PM Changeset in webkit [8572] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3992092> 8A374: Mail crash while pasting - RemoveNodeCommand

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Code tried to remove a node that was no longer in the document. We try to do a good job of detecting all these cases, and generally do. This one was missed. Fixed.

3:50 PM Changeset in webkit [8571] by darin

• 2 edits in trunk/WebKit

Reviewed by Harrison.

• fixed <rdar://problem/4002084> Setting ResourceLoadDelegate to nil can cause a crash

• WebView.subproj/WebView.m: (-[WebView _cacheResourceLoadDelegateImplementations]): Set booleans to either YES or NO, rather than setting them only in the YES case.

3:48 PM Changeset in webkit [8570] by darin

• 2 edits in trunk/WebKit

Reviewed by Harrison.

• fixed <rdar://problem/3991225> Format->Style->Underline menu item does not get checked when selected text is underlined

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView validateUserInterfaceItem:]): Added tons of additional cases in here for all the "action" style methods in this class that don't always want to be valid. For the ones where state makes sense, added the state-checking code too for the menu item case. (-[WebHTMLView ignoreSpelling:]): Removed unnecessary "editable text only" check since this command would work fine on a non-editable selection. (-[WebHTMLView swapWithMark:]): Ditto. (-[WebHTMLView changeBaseWritingDirection:]): Added. Like toggle, but based on the sender's tag.

3:47 PM Changeset in webkit [8569] by darin

• 3 edits in trunk/WebCore

Reviewed by Harrison.

• added support needed to fix <rdar://problem/3991225> Format->Style->Underline menu item does not get checked when selected text is underlined

• kwq/WebCoreBridge.h: Added selectionHasStyle: method.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionHasStyle:]): Added. Calls selectionHasStyle on the part.

2:51 PM Changeset in webkit [8568] by darin

• 5 edits in trunk/WebCore

Reviewed by Harrison.

• fixed <rdar://problem/3990484> cursor changes to I-beam when moving over text in widgets, even when selection off via CSS

• khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Changed code to check canSelect when deciding whether to show an I-beam cursor.

• khtml/rendering/render_object.h: Added canSelect.
• khtml/rendering/render_object.cpp: (selectStartNode): Added. Helper function with the guts of shouldSelect. (RenderObject::canSelect): Added. Like shouldSelect, but does not call the "start selecting" event handler. (RenderObject::shouldSelect): Refactored to use selectStartNode.

• khtml/css/cssvalues.c: Regnerated with newer gperf.

2:30 PM Changeset in webkit [8567] by hyatt

• 3 edits in trunk/WebCore

Fix for 3867759, .mac regression where scrollers don't show up. Make sure you can set the .width and
.height properties on the Image object.

Reviewed by John Sullivan

• khtml/ecma/kjs_html.cpp: (ImageConstructorImp::construct): (Image::getValueProperty): (Image::putValue): (Image::Image):
• khtml/ecma/kjs_html.h:

2:25 PM Changeset in webkit [8566] by kocienda

• 10 edits
  4 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3965158> Drag-n-drop within a rich text message sometimes changes the color of the dragged text

This change fixes the bug....and much more. Now, for the first time, the paste code can do "smart merging"
or "smooshing" of styles during its operation. Since this new code is actively, rather than passively
working with styles, it fixes the bug, and lays the groundwork for similar work we need to do to
preserve quote levels in Mail.

• khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::clear): New method. (DOM::CSSMutableStyleDeclarationImpl::removeBlockProperties): Ditto. (DOM::CSSMutableStyleDeclarationImpl::removePropertiesInSet): Ditto. (DOM::operator==): Add operator for CSSProperty.
• khtml/css/css_valueimpl.h: Declare new functions.
• khtml/editing/htmlediting.cpp: (khtml::isEmptyStyleSpan): Improved the test in this function, rolling together the old implementation with some code that did this work inline elsewhere. Sum of the parts is better than either test was by itself. (khtml::isStyleSpan): Check for ID_SPAN. (khtml::ApplyStyleCommand::removeCSSStyle): Call isEmptyStyleSpan. This was the place with an inline implementation before. (khtml::ReplacementFragment::ReplacementFragment): Now takes a DocumentImpl argument. No longer does a "default style" check, but rather calls functions which do a similar check to that, and much more. (khtml::ReplacementFragment::~ReplacementFragment): Deref document, and computed styles. (khtml::ReplacementFragment::styleForNode): New helper. Looks up and returns computed style for a node. (khtml::ReplacementFragment::removeNodePreservingChildren): New helper. (khtml::ReplacementFragment::computeStylesForNodes): New function which computes the "desired" style for every node in the fragment. This information is used later after paste is done as a reference for testing what styles need to be added, and which can be removed as redundant, from all the nodes inserted by the replacement code. (khtml::ReplacementFragment::removeStyleNodes): Clears out all style nodes from the fragment. They are no longer needed after the call to computeStylesForNodes(), (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): Add a document to the call to initialize the command's ReplacementFragment. (khtml::ReplaceSelectionCommand::doApply): Call applyStyleToInsertedNodes() after inserting nodes to make styles come out right. (khtml::ReplaceSelectionCommand::applyStyleToInsertedNodes): This is the "style smooshing" function. It computes the styles that need to be added to each node inserted, comparing the style it gets from just being inserted into its correct destination with the computed "desired style" done in the ReplacementFragment constructor. It then adds in all the necessary styles, and will also remove redundant styles.
• khtml/editing/htmlediting.h: Update declarations and member variables as needed.
• khtml/editing/markup.cpp: (khtml::startMarkup): Add additional style annotations to the markup we generate, so that paste code can preserve it. (khtml::markup): Ditto. (khtml::createMarkup): Ditto.

These test results are subtly better with this change. They no longer have an unneeded empty span.
Visually the same as before.

• layout-tests/editing/style/remove-underline-across-paragraph-expected.txt
• layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt
• layout-tests/editing/style/remove-underline-expected.txt
• layout-tests/editing/style/remove-underline-from-stylesheet-expected.txt

New tests:

• layout-tests/editing/style/smoosh-styles-001-expected.txt
• layout-tests/editing/style/smoosh-styles-002-expected.txt
• layout-tests/editing/style/smoosh-styles-001.html
• layout-tests/editing/style/smoosh-styles-002.html

1:29 PM Changeset in webkit [8565] by darin

• 2 edits in trunk/WebCore

Reviewed by Adele.

• fixed <rdar://problem/3974988> WebHTMLView drops scroll wheel events when deltas are 0

• kwq/WebCoreScrollView.m: (-[WebCoreScrollView autoforwardsScrollWheelEvents]): Added, for Tiger only. For Tiger, removed the override of scrollWheel:, which doesn't work quite right because of how the delta attributes return all 0 for newfangled scrolling events from the new trackpads.

11:46 AM Changeset in webkit [8564] by darin

• 1 edit
  1 delete in trunk/JavaScriptCore

"Reviewed" by Richard (he told me the file was obsolete).

• got rid of an obsolete file

• bindings/npsap.h: Removed.

11:45 AM Changeset in webkit [8563] by darin

• 2 edits
  1 delete in trunk/WebKit

"Reviewed" by Richard (he told me the file was obsolete).

• got rid of an obsolete file

• Plugins.subproj/npsap.h: Removed.
• copy-webcore-files-to-webkit: Removed npsap.h.

11:12 AM Changeset in webkit [8562] by harrison

• 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3991532> REGRESSION (Mail): Triple-click on trailing blank line should select previous line but doesn't

• khtml/css/cssvalues.c: (hash_val): (findValue):
• khtml/editing/selection.cpp: (khtml::Selection::validate): Do moral equiavalent of LeftWordIfOnBoundary for PARAGRAPH.

11:03 AM Changeset in webkit [8561] by harrison

• 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3991848> Double-click on first character selects wrong item

• khtml/editing/selection.cpp: (khtml::Selection::validate): Honor the fact that clicking on a character positions the cursor on the left side of the character.

2:21 AM Changeset in webkit [8560] by hyatt

• 2 edits in trunk/WebCore

Fix for 3980778, repro crash in RootInlineBox::paint. Make sure that when merging blocks we dirty them for layout
up front. That way as we do the merge, we dont attempt to examine the lines in dirtyLinesForChangedChild.

Reviewed by mjs

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):

1:55 AM Changeset in webkit [8559] by hyatt

• 2 edits in trunk/WebCore

Fix for 3987010, fix a bug that caused the self-collapsing-block-cleared-float bit to never get set correctly.

Reviewed by mjs

• khtml/rendering/render_block.h: (khtml::RenderBlock::MarginInfo::setSelfCollapsingBlockClearedFloat):

1:34 AM Changeset in webkit [8558] by hyatt

• 2 edits in trunk/WebCore

Fix for 3992440, text not wrapping correctly on half moon bay web site. Refine an incorrect optimization I
added to be less restrictive.

Reviewed by mjs

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):

12:40 AM Changeset in webkit [8557] by mjs

• 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3977973> pages on ebay leak referenced JavaScript objects -- over time browsing becomes super-slow

I fixed this by removing all event listeners for a document, it's
children, and any disconnected nodes that used to be in the
document at document detach time. Mozilla temporarily disables
event listeners on such nodes, but re-enables them if you
re-parant a node into a new document. However, in WebCore, you
can't re-parent a node into another document, so there is no
observable change in behavior.

We have to do this to break the possible reference cycles between
event listeners and the dom nodes they are attached to (e.g. via
scope chain, as in this case).

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): (DocumentImpl::removeAllEventListenersFromAllNodesx): (DocumentImpl::registerDisconnectedNodeWithEventListeners): (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): (DocumentImpl::removeAllDisconnectedNodeEventListeners):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::~NodeImpl): (NodeImpl::addEventListener): (NodeImpl::removeEventListener): (NodeImpl::removeAllEventListeners): (NodeImpl::removeHTMLEventListener): (NodeImpl::insertedIntoDocument): (NodeImpl::removedFromDocument):
• khtml/xml/dom_nodeimpl.h: